Repository navigation
fix(firestore): graduate pipeline search from preview to GA - #9700
Merged
Merged
Conversation
MarkDuckworth
commented
Oct 22, 2026
MarkDuckworth
commented
Contributor
- Remove beta/preview annotations and documentation from Pipeline.search, SearchStage/SearchStageOptions, documentMatches, score, and geoDistance.
- Update API reports and reference documentation.
- Remove beta/preview annotations and documentation from Pipeline.search, SearchStage/SearchStageOptions, documentMatches, score, and geoDistance. - Update API reports and reference documentation.
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request promotes several Firestore pipeline features, including documentMatches, geoDistance, score, and search, from beta to public by removing or updating @beta tags across the codebase. The feedback suggests improving a TSDoc link in firestore.d.ts by using standard relative link syntax and referencing the correct SDK.
| /** | ||
| * @beta | ||
| * | ||
| * Options defining how a SearchStage is evaluated. See {@link @firebase/firestore/pipelines#Pipeline.(search)}. |
Contributor
There was a problem hiding this comment.
The TSDoc link references @firebase/firestore, which is the Web SDK package, but this is the Node.js SDK (@google-cloud/firestore). Additionally, the syntax Pipeline.(search) is non-standard. Since Pipeline is defined within the same namespace, we can simplify this to a relative link {@link Pipeline.search}.
Suggested change
| * Options defining how a SearchStage is evaluated. See {@link @firebase/firestore/pipelines#Pipeline.(search)}. | |
| * Options defining how a SearchStage is evaluated. See {@link Pipeline.search}. |
dlarocque
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.