Repository navigation
Conversation
`handwritten/bigquery` and `handwritten/pubsub` no longer have local `samples/quickstart.js` files (removed in PR googleapis#7256), and neither `bigquery_quickstart` nor `pubsub_quickstart_create_topic` exists in `GoogleCloudPlatform/nodejs-docs-samples`. As a result, `@googleapis/api-documenter` fails during `docs-devsite` generation with `Error: could not find sample ...`. Remove the obsolete `include:samples/quickstart.js` and `region_tag:` JSDoc blocks from `handwritten/bigquery/src/bigquery.ts`, `handwritten/pubsub/src/index.ts`, and `handwritten/pubsub/src/pubsub.ts`.
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes outdated or unused JSDoc @example annotations referencing quickstart samples from bigquery.ts, pubsub/src/index.ts, and pubsub.ts. As there are no review comments, I have no feedback to provide.
Contributor
Author
|
I reviewed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handwritten/bigqueryandhandwritten/pubsubno longer have localsamples/quickstart.jsfiles (removed in PR #7256), and neitherbigquery_quickstartnorpubsub_quickstart_create_topicexists inGoogleCloudPlatform/nodejs-docs-samples. As a result,@googleapis/api-documenterfails duringdocs-devsitegeneration withError: could not find sample ....This removes the obsolete
include:samples/quickstart.jsandregion_tag:JSDoc blocks fromhandwritten/bigquery/src/bigquery.ts,handwritten/pubsub/src/index.ts, andhandwritten/pubsub/src/pubsub.ts.