Repository navigation
Conversation
product-auto-label
Bot
added
the
api: bigquerystorage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery Storage README partials by removing the retrieval of streamId from the connection object and its subsequent passing to the JSONWriter constructor. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the cleanup.
Description
Removes unused
streamIdoption from theJSONWriterquickstart example in BigQuery Storage.Impact
Prevents TypeScript type errors when developers copy the
JSONWriterREADME example.Changes
streamIdvariable andJSONWriterconstructor property fromhandwritten/bigquery-storage/.readme-partials.yaml.Testing
JSONWriterconstructor options againstWriterOptionsinhandwritten/bigquery-storage.Alternatives
streamIdin the example causes TypeScript compilation errors for users becauseWriterOptionsonly acceptsconnectionandprotoDescriptor.Fixes #7520