Skip to content

fix(datastore): align Transaction JSDoc @extends tag with DatastoreRequest #9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quirogas merged 1 commit into from
Oct 21, 2026
Merged

fix(datastore): align Transaction JSDoc @extends tag with DatastoreRequest #9671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion handwritten/datastore/src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
* @see {@link https://cloud.google.com/datastore/docs/concepts/transactions| Transactions Reference}
*
* @class
* @extends {Request}
* @extends {DatastoreRequest}
* @param {Datastore} datastore A Datastore instance.
* @mixes module:datastore/request
*
Expand Down Expand Up @@ -1005,7 +1005,7 @@
* arguments.
* @private
*/
#withBeginTransaction<T extends any[]>(

Check warning on line 1008 in handwritten/datastore/src/transaction.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
gaxOptions: CallOptions | undefined,
fn: () => void,
callback: (...args: [Error | null, ...T] | [Error | null]) => void,
Expand All @@ -1029,7 +1029,7 @@
// Now the wrapped function fn will be called.
}
});
} catch (err: any) {

Check warning on line 1032 in handwritten/datastore/src/transaction.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
// Handle an error produced by the beginTransactionAsync call
return callback(err);
}
Expand Down
Loading