Skip to content

chore(deps): upgrade @google-cloud/common dependency floor to ^8.2.2 - #9669

Draft
quirogas wants to merge 1 commit into
mainfrom
chore/bump-common-dep-floor
Draft

quirogas wants to merge 1 commit into
mainfrom
chore/bump-common-dep-floor

Conversation

@quirogas

@quirogas quirogas commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

This change upgrades the @google-cloud/common dependency floor across consumer packages.

Impact

Consumers receive URI path encoding and project ID token handling fixes.

Changes

  • Upgrade "@google-cloud/common" dependency floor to "^8.2.2" across handwritten/{bigquery,cloud-profiler,error-reporting,google-cloud-dns,logging,logging-bunyan,logging-winston,spanner}, packages/{google-cloud-speech,google-cloud-translate}, and librarian.yaml.
  • Regenerate pnpm-lock.yaml to resolve @google-cloud/common@8.2.2 (published via #9684 with the {{projectId}} URI path encoding fix from #9668).

Testing

  • Verified CI=true NPM_CONFIG_REGISTRY=https://registry.npmjs.org/ npx pnpm@10 install --frozen-lockfile --ignore-scripts passes with zero errors.
  • Verified GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strict passes with zero errors and zero warnings.
  • Verified unit tests in handwritten/bigquery (596 passing) and handwritten/google-cloud-dns (99 passing) under both Node.js and JS_RUNTIME=bun.
  • Verified live GCP system tests in handwritten/bigquery against node-testbench-sandbox-789145.

Alternatives

  • Not merging this pull request would leave consumer packages pinning @google-cloud/common at ^8.0.0 / ^8.0.1 instead of picking up the URI path encoding and {{projectId}} token handling fixes in @google-cloud/common@8.2.2.

@quirogas
quirogas added this pull request to stack #9670 October 20, 2026 04:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @google-cloud/common dependency to version ^8.2.0 across several package files and librarian.yaml. However, the reviewer notes that version 8.2.0 contains a bug that percent-encodes {{projectId}} and breaks token replacement. To avoid this issue, it is highly recommended to bump the dependency floor directly to ^8.2.1 instead of ^8.2.0.

Comment thread handwritten/bigquery/package.json Outdated
},
"dependencies": {
"@google-cloud/common": "^8.0.0",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

Comment thread handwritten/cloud-profiler/package.json Outdated
"license": "Apache-2.0",
"dependencies": {
"@google-cloud/common": "^8.0.0",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

},
"dependencies": {
"@google-cloud/common": "^8.0.0",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

},
"dependencies": {
"@google-cloud/common": "^8.0.0",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

Comment thread handwritten/logging-bunyan/package.json Outdated
},
"devDependencies": {
"@google-cloud/common": "^8.0.0",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

Comment thread handwritten/spanner/package.json Outdated
"@babel/helpers": "7.27.6",
"@babel/traverse": "7.27.7",
"@google-cloud/common": "^8.0.0",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

Comment thread librarian.yaml Outdated
default_version: v1
dependencies:
'@google-cloud/common': ^6.0.0
'@google-cloud/common': ^8.2.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

        '@google-cloud/common': ^8.2.1

Comment thread librarian.yaml Outdated
default_version: v3
dependencies:
'@google-cloud/common': ^6.0.0
'@google-cloud/common': ^8.2.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

        '@google-cloud/common': ^8.2.1

},
"dependencies": {
"@google-cloud/common": "^8.0.1",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

},
"dependencies": {
"@google-cloud/common": "^8.0.1",
"@google-cloud/common": "^8.2.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.

Suggested change
"@google-cloud/common": "^8.2.0",
"@google-cloud/common": "^8.2.1",

Base automatically changed from fix/common-preserve-project-id-token to main October 21, 2026 23:15
@quirogas
quirogas force-pushed the chore/bump-common-dep-floor branch 3 times, most recently from 132432c to 63158f6 Compare October 23, 2026 19:05
@quirogas quirogas changed the title chore(deps): upgrade @google-cloud/common dependency floor to ^8.2.0 chore(deps): upgrade @google-cloud/common dependency floor to ^8.2.2 Oct 23, 2026
@quirogas
quirogas force-pushed the chore/bump-common-dep-floor branch from 63158f6 to 1480b7a Compare October 23, 2026 22:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant