abseil-cpp: fix stale-variable round-trip checks in string_escape_fuzzer - #16079
Open
JasonGross wants to merge 1 commit into
Open
JasonGross wants to merge 1 commit into
JasonGross wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
JasonGross is a new contributor to projects/abseil-cpp. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, derekmauro, junyer, DonggeLiu, PiotrSikora, inferno-chromium, kabeer27 |
JasonGross
force-pushed
the
fix-string-escape-fuzzer-stale-vars
branch
from
August 30, 2026 05:29
0274ada to
eab78f1
Compare
The Base64 check compared unescaped (last written by the earlier CUnescape round trip) instead of decoded, and the hex check compared decoded (last written by the WebSafeBase64 round trip) instead of bytes_result. Both comparisons were pinned true by the immediately preceding abort()-guarded checks, so neither abort was reachable and the two round trips were never verified. Fixes google#16078.
JasonGross
force-pushed
the
fix-string-escape-fuzzer-stale-vars
branch
from
September 21, 2026 06:21
eab78f1 to
aac2aa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Base64 and hex round-trip checks compared variables not written by the transformation under test (
unescapedinstead ofdecoded, anddecodedinstead ofbytes_result), and each was pinned true by the immediately preceding check, so neitherabort()was reachable. Fixes #16078.🤖 Generated with Claude Code