deploy: add lib/go.mod to the image build's dependency cache - #3898
Merged
Merged
Conversation
The root go.mod replaces github.com/google/cadvisor/lib => ./lib, so the dependency-cache `go mod download` needs lib/go.mod present. The cmd submodule was handled but lib was not, so the container image build failed with "reading lib/go.mod: no such file or directory". Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dgalanberasaluce
pushed a commit
to dgalanberasaluce/infra-personal
that referenced
this pull request
Jul 12, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/google/cadvisor](https://github.com/google/cadvisor) | minor | `0.56.2` → `v0.60.1` | --- ### Release Notes <details> <summary>google/cadvisor (ghcr.io/google/cadvisor)</summary> ### [`v0.60.1`](https://github.com/google/cadvisor/releases/tag/v0.60.1): cAdvisor v0.60.1 [Compare Source](google/cadvisor@v0.60.1...v0.60.1) ##### What's Changed - cpuload/netlink: report the real error and skip the reader on cgroup v2 by [@​dims](https://github.com/dims) in [#​3896](google/cadvisor#3896) - deploy: add lib/go.mod to the image build's dependency cache by [@​dims](https://github.com/dims) in [#​3898](google/cadvisor#3898) **Full Changelog**: <google/cadvisor@v0.60.0...v0.60.1> ##### What's Changed - cpuload/netlink: report the real error and skip the reader on cgroup v2 by [@​dims](https://github.com/dims) in [#​3896](google/cadvisor#3896) - deploy: add lib/go.mod to the image build's dependency cache by [@​dims](https://github.com/dims) in [#​3898](google/cadvisor#3898) **Full Changelog**: <google/cadvisor@v0.60.0...v0.60.1> ### [`v0.60.1`](https://github.com/google/cadvisor/releases/tag/v0.60.1): cAdvisor v0.60.1 [Compare Source](google/cadvisor@v0.57.0...v0.60.1) ##### What's Changed - cpuload/netlink: report the real error and skip the reader on cgroup v2 by [@​dims](https://github.com/dims) in [#​3896](google/cadvisor#3896) - deploy: add lib/go.mod to the image build's dependency cache by [@​dims](https://github.com/dims) in [#​3898](google/cadvisor#3898) **Full Changelog**: <google/cadvisor@v0.60.0...v0.60.1> ##### What's Changed - cpuload/netlink: report the real error and skip the reader on cgroup v2 by [@​dims](https://github.com/dims) in [#​3896](google/cadvisor#3896) - deploy: add lib/go.mod to the image build's dependency cache by [@​dims](https://github.com/dims) in [#​3898](google/cadvisor#3898) **Full Changelog**: <google/cadvisor@v0.60.0...v0.60.1> ### [`v0.57.0`](https://github.com/google/cadvisor/releases/tag/v0.57.0): cAdvisor v0.57.0 [Compare Source](google/cadvisor@v0.57.0...v0.57.0) ##### What's Changed - integration: add more Docker container handler tests by [@​dims](https://github.com/dims) in [#​3817](google/cadvisor#3817) - integration: add containerd container handler tests by [@​dims](https://github.com/dims) in [#​3818](google/cadvisor#3818) - integration: add Prometheus metrics endpoint tests by [@​dims](https://github.com/dims) in [#​3819](google/cadvisor#3819) - fix: support podman `volatile-containers.json` and/or `containers.json` by [@​sirno](https://github.com/sirno) in [#​3726](google/cadvisor#3726) - proposed roadmap for cAdvisor by [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) in [#​3826](google/cadvisor#3826) - remove log message when you can't read productName by [@​kannon92](https://github.com/kannon92) in [#​3840](google/cadvisor#3840) - Refactor Github Action per b/485167538 by [@​google-admin](https://github.com/google-admin) in [#​3841](google/cadvisor#3841) - fix crio deadlock in getting crio sandbox containers by [@​olyazavr](https://github.com/olyazavr) in [#​3838](google/cadvisor#3838) - Add container\_creation\_time\_seconds (previously: container\_start\_time\_seconds); use runtime start time for container\_start\_time\_seconds (podman & docker) by [@​ultinous-akos](https://github.com/ultinous-akos) in [#​3808](google/cadvisor#3808) - deps: github.com/moby/moby/client v0.4.0, moby/api v1.54.1, containerd/ttrpc v1.2.8 by [@​thaJeztah](https://github.com/thaJeztah) in [#​3863](google/cadvisor#3863) - fix(build): update k8s-staging-test-infra image in integ tests by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3865](google/cadvisor#3865) - feat(manager/container): add configurable initial splay and max jitter factors by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3854](google/cadvisor#3854) - feat(manager): add constraint data in OOM events by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3861](google/cadvisor#3861) - fix: add v-prefixed GHCR image tags for release consistency by [@​hwan515](https://github.com/hwan515) in [#​3857](google/cadvisor#3857) - build(deps): bump the go\_modules group across 2 directories with 1 update by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3855](google/cadvisor#3855) - Expose cgroup v2 memory.events as Prometheus metrics by [@​sohankunkerkar](https://github.com/sohankunkerkar) in [#​3870](google/cadvisor#3870) - deploy: bump base images to Alpine 3.23 by [@​dims](https://github.com/dims) in [#​3872](google/cadvisor#3872) ##### New Contributors - [@​sirno](https://github.com/sirno) made their first contribution in [#​3726](google/cadvisor#3726) - [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) made their first contribution in [#​3826](google/cadvisor#3826) - [@​google-admin](https://github.com/google-admin) made their first contribution in [#​3841](google/cadvisor#3841) - [@​olyazavr](https://github.com/olyazavr) made their first contribution in [#​3838](google/cadvisor#3838) - [@​ultinous-akos](https://github.com/ultinous-akos) made their first contribution in [#​3808](google/cadvisor#3808) - [@​hwan515](https://github.com/hwan515) made their first contribution in [#​3857](google/cadvisor#3857) - [@​sohankunkerkar](https://github.com/sohankunkerkar) made their first contribution in [#​3870](google/cadvisor#3870) **Full Changelog**: <google/cadvisor@v0.56.2...v0.57.0> ##### What's Changed - integration: add more Docker container handler tests by [@​dims](https://github.com/dims) in [#​3817](google/cadvisor#3817) - integration: add containerd container handler tests by [@​dims](https://github.com/dims) in [#​3818](google/cadvisor#3818) - integration: add Prometheus metrics endpoint tests by [@​dims](https://github.com/dims) in [#​3819](google/cadvisor#3819) - fix: support podman `volatile-containers.json` and/or `containers.json` by [@​sirno](https://github.com/sirno) in [#​3726](google/cadvisor#3726) - proposed roadmap for cAdvisor by [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) in [#​3826](google/cadvisor#3826) - remove log message when you can't read productName by [@​kannon92](https://github.com/kannon92) in [#​3840](google/cadvisor#3840) - Refactor Github Action per b/485167538 by [@​google-admin](https://github.com/google-admin) in [#​3841](google/cadvisor#3841) - fix crio deadlock in getting crio sandbox containers by [@​olyazavr](https://github.com/olyazavr) in [#​3838](google/cadvisor#3838) - Add container\_creation\_time\_seconds (previously: container\_start\_time\_seconds); use runtime start time for container\_start\_time\_seconds (podman & docker) by [@​ultinous-akos](https://github.com/ultinous-akos) in [#​3808](google/cadvisor#3808) - deps: github.com/moby/moby/client v0.4.0, moby/api v1.54.1, containerd/ttrpc v1.2.8 by [@​thaJeztah](https://github.com/thaJeztah) in [#​3863](google/cadvisor#3863) - fix(build): update k8s-staging-test-infra image in integ tests by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3865](google/cadvisor#3865) - feat(manager/container): add configurable initial splay and max jitter factors by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3854](google/cadvisor#3854) - feat(manager): add constraint data in OOM events by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3861](google/cadvisor#3861) - fix: add v-prefixed GHCR image tags for release consistency by [@​hwan515](https://github.com/hwan515) in [#​3857](google/cadvisor#3857) - build(deps): bump the go\_modules group across 2 directories with 1 update by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3855](google/cadvisor#3855) - Expose cgroup v2 memory.events as Prometheus metrics by [@​sohankunkerkar](https://github.com/sohankunkerkar) in [#​3870](google/cadvisor#3870) - deploy: bump base images to Alpine 3.23 by [@​dims](https://github.com/dims) in [#​3872](google/cadvisor#3872) ##### New Contributors - [@​sirno](https://github.com/sirno) made their first contribution in [#​3726](google/cadvisor#3726) - [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) made their first contribution in [#​3826](google/cadvisor#3826) - [@​google-admin](https://github.com/google-admin) made their first contribution in [#​3841](google/cadvisor#3841) - [@​olyazavr](https://github.com/olyazavr) made their first contribution in [#​3838](google/cadvisor#3838) - [@​ultinous-akos](https://github.com/ultinous-akos) made their first contribution in [#​3808](google/cadvisor#3808) - [@​hwan515](https://github.com/hwan515) made their first contribution in [#​3857](google/cadvisor#3857) - [@​sohankunkerkar](https://github.com/sohankunkerkar) made their first contribution in [#​3870](google/cadvisor#3870) **Full Changelog**: <google/cadvisor@v0.56.2...v0.57.0> ### [`v0.57.0`](https://github.com/google/cadvisor/releases/tag/v0.57.0): cAdvisor v0.57.0 [Compare Source](google/cadvisor@v0.56.2...v0.57.0) ##### What's Changed - integration: add more Docker container handler tests by [@​dims](https://github.com/dims) in [#​3817](google/cadvisor#3817) - integration: add containerd container handler tests by [@​dims](https://github.com/dims) in [#​3818](google/cadvisor#3818) - integration: add Prometheus metrics endpoint tests by [@​dims](https://github.com/dims) in [#​3819](google/cadvisor#3819) - fix: support podman `volatile-containers.json` and/or `containers.json` by [@​sirno](https://github.com/sirno) in [#​3726](google/cadvisor#3726) - proposed roadmap for cAdvisor by [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) in [#​3826](google/cadvisor#3826) - remove log message when you can't read productName by [@​kannon92](https://github.com/kannon92) in [#​3840](google/cadvisor#3840) - Refactor Github Action per b/485167538 by [@​google-admin](https://github.com/google-admin) in [#​3841](google/cadvisor#3841) - fix crio deadlock in getting crio sandbox containers by [@​olyazavr](https://github.com/olyazavr) in [#​3838](google/cadvisor#3838) - Add container\_creation\_time\_seconds (previously: container\_start\_time\_seconds); use runtime start time for container\_start\_time\_seconds (podman & docker) by [@​ultinous-akos](https://github.com/ultinous-akos) in [#​3808](google/cadvisor#3808) - deps: github.com/moby/moby/client v0.4.0, moby/api v1.54.1, containerd/ttrpc v1.2.8 by [@​thaJeztah](https://github.com/thaJeztah) in [#​3863](google/cadvisor#3863) - fix(build): update k8s-staging-test-infra image in integ tests by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3865](google/cadvisor#3865) - feat(manager/container): add configurable initial splay and max jitter factors by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3854](google/cadvisor#3854) - feat(manager): add constraint data in OOM events by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3861](google/cadvisor#3861) - fix: add v-prefixed GHCR image tags for release consistency by [@​hwan515](https://github.com/hwan515) in [#​3857](google/cadvisor#3857) - build(deps): bump the go\_modules group across 2 directories with 1 update by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3855](google/cadvisor#3855) - Expose cgroup v2 memory.events as Prometheus metrics by [@​sohankunkerkar](https://github.com/sohankunkerkar) in [#​3870](google/cadvisor#3870) - deploy: bump base images to Alpine 3.23 by [@​dims](https://github.com/dims) in [#​3872](google/cadvisor#3872) ##### New Contributors - [@​sirno](https://github.com/sirno) made their first contribution in [#​3726](google/cadvisor#3726) - [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) made their first contribution in [#​3826](google/cadvisor#3826) - [@​google-admin](https://github.com/google-admin) made their first contribution in [#​3841](google/cadvisor#3841) - [@​olyazavr](https://github.com/olyazavr) made their first contribution in [#​3838](google/cadvisor#3838) - [@​ultinous-akos](https://github.com/ultinous-akos) made their first contribution in [#​3808](google/cadvisor#3808) - [@​hwan515](https://github.com/hwan515) made their first contribution in [#​3857](google/cadvisor#3857) - [@​sohankunkerkar](https://github.com/sohankunkerkar) made their first contribution in [#​3870](google/cadvisor#3870) **Full Changelog**: <google/cadvisor@v0.56.2...v0.57.0> ##### What's Changed - integration: add more Docker container handler tests by [@​dims](https://github.com/dims) in [#​3817](google/cadvisor#3817) - integration: add containerd container handler tests by [@​dims](https://github.com/dims) in [#​3818](google/cadvisor#3818) - integration: add Prometheus metrics endpoint tests by [@​dims](https://github.com/dims) in [#​3819](google/cadvisor#3819) - fix: support podman `volatile-containers.json` and/or `containers.json` by [@​sirno](https://github.com/sirno) in [#​3726](google/cadvisor#3726) - proposed roadmap for cAdvisor by [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) in [#​3826](google/cadvisor#3826) - remove log message when you can't read productName by [@​kannon92](https://github.com/kannon92) in [#​3840](google/cadvisor#3840) - Refactor Github Action per b/485167538 by [@​google-admin](https://github.com/google-admin) in [#​3841](google/cadvisor#3841) - fix crio deadlock in getting crio sandbox containers by [@​olyazavr](https://github.com/olyazavr) in [#​3838](google/cadvisor#3838) - Add container\_creation\_time\_seconds (previously: container\_start\_time\_seconds); use runtime start time for container\_start\_time\_seconds (podman & docker) by [@​ultinous-akos](https://github.com/ultinous-akos) in [#​3808](google/cadvisor#3808) - deps: github.com/moby/moby/client v0.4.0, moby/api v1.54.1, containerd/ttrpc v1.2.8 by [@​thaJeztah](https://github.com/thaJeztah) in [#​3863](google/cadvisor#3863) - fix(build): update k8s-staging-test-infra image in integ tests by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3865](google/cadvisor#3865) - feat(manager/container): add configurable initial splay and max jitter factors by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3854](google/cadvisor#3854) - feat(manager): add constraint data in OOM events by [@​sambhav-jain-16](https://github.com/sambhav-jain-16) in [#​3861](google/cadvisor#3861) - fix: add v-prefixed GHCR image tags for release consistency by [@​hwan515](https://github.com/hwan515) in [#​3857](google/cadvisor#3857) - build(deps): bump the go\_modules group across 2 directories with 1 update by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3855](google/cadvisor#3855) - Expose cgroup v2 memory.events as Prometheus metrics by [@​sohankunkerkar](https://github.com/sohankunkerkar) in [#​3870](google/cadvisor#3870) - deploy: bump base images to Alpine 3.23 by [@​dims](https://github.com/dims) in [#​3872](google/cadvisor#3872) ##### New Contributors - [@​sirno](https://github.com/sirno) made their first contribution in [#​3726](google/cadvisor#3726) - [@​SergeyKanzhelev](https://github.com/SergeyKanzhelev) made their first contribution in [#​3826](google/cadvisor#3826) - [@​google-admin](https://github.com/google-admin) made their first contribution in [#​3841](google/cadvisor#3841) - [@​olyazavr](https://github.com/olyazavr) made their first contribution in [#​3838](google/cadvisor#3838) - [@​ultinous-akos](https://github.com/ultinous-akos) made their first contribution in [#​3808](google/cadvisor#3808) - [@​hwan515](https://github.com/hwan515) made their first contribution in [#​3857](google/cadvisor#3857) - [@​sohankunkerkar](https://github.com/sohankunkerkar) made their first contribution in [#​3870](google/cadvisor#3870) **Full Changelog**: <google/cadvisor@v0.56.2...v0.57.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My43My4yIiwidXBkYXRlZEluVmVyIjoiNDMuNzMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=--> Reviewed-on: https://forgejo.internal/forgejo_admin/infra-personal/pulls/91 Co-authored-by: Renovate Bot <renovatebot@forgejo.internal> Co-committed-by: Renovate Bot <renovatebot@forgejo.internal>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container-image build fails at
go mod download:The root
go.modreplaces thelibsubmodule with./lib, so the dependency-cache step needslib/go.modpresent beforego mod download. Thecmdsubmodule was already handled this way; do the same forlib.This broke the v0.60.0 image publish.