Skip to content

fix(mcp): validate action parameter before database check in mobile_inspect_trace - #142

Open
Mahesh-Abeykoon wants to merge 1 commit into
google:mainfrom
Mahesh-Abeykoon:fix/inspect-trace-action-validation
Open

Mahesh-Abeykoon wants to merge 1 commit into
google:mainfrom
Mahesh-Abeykoon:fix/inspect-trace-action-validation

Conversation

@Mahesh-Abeykoon

Copy link
Copy Markdown

Summary

Validates the action parameter at the start of mobile_inspect_trace before checking if the trace database file exists on disk.

Problem

Previously, mobile_inspect_trace checked for data_engine.db on disk before validating the requested action.

When an unsupported action was passed in an environment where no trace database existed yet (such as on a fresh clone or in an isolated test run), the function returned:

{
  "error": "Database not found",
  "message": "Data engine database does not exist at ... yet."
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant