Repository navigation
Document current limits of model-level and global determinism controls - #1922
Closed
huster-wgm wants to merge 1 commit into
Closed
huster-wgm wants to merge 1 commit into
huster-wgm wants to merge 1 commit into
Conversation
huster-wgm
marked this pull request as ready for review
November 8, 2026 07:46
2 tasks
Author
|
Closing this documentation-only proposal in favor of issue #1925, which records the model-level ordering gaps, evidence, validation limits and acceptance criteria. Implementation is split between #1923 (contacts) and #1924 (constraints/address remapping); both are needed. The unsupported global Warp RUN_TO_RUN path remains a separate concern, as discussed in #1635. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
DeterminismType.ALLoption can be mistaken for a guarantee of bitwise-identical trajectories. However,_sort_contactsand_sort_constraintsare still TODO/pass hooks on main, as noted in the future work of #1687. The README now makes that limitation explicit and distinguishes model-level controls from Warp's unsupported global deterministic mode, referring readers to #562 and #1635.This is a documentation clarification, not a physics fix. In a downstream G1 GPU replay on MJWarp/MuJoCo 4.0.0 and Warp 1.19.0, model-level ALL still diverged between native runs; enabling global RUN_TO_RUN raised WarpDeterminismError in the convex CCD kernel. Those observations motivated checking the implementation, but are not presented as an isolated engine bug reproduction.
Validation: checked the statements against current main (4d1c64b), #1687 and the maintainer response in #1635; git diff --check passes. No runtime code changes. Full pytest/pre-commit checks were attempted but could not start in the isolated checkout because the test tools were not installed; keeping this draft pending CI/review.