Skip to content

Keep achromatic HSL gradients finite #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 3 commits into from
Oct 28, 2026
Merged

Keep achromatic HSL gradients finite #132

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f8b59
Refine HSL gradient regression test structure
sylvesterkaczmarek Oct 27, 2026
9c8b484
Merge branch 'master' into fix/achromatic-hsl-gradients
claudiofantacci Oct 27, 2026
2881e23
Fix chromatic gradient test after upstream sync
sylvesterkaczmarek Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dm_pix/_src/color_conversion_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ def test_mixed_image_values_and_gradients(self):
@chex.all_variants
def test_chromatic_gradients_match_finite_differences(self):
x = jnp.array([0.2, 0.6, 0.9])
x64 = np.asarray(x, dtype=np.float64)
numerical = np.zeros((3, 3))
x64 = np.asarray(x).astype(np.float64)
for index in range(3):
delta = np.zeros(3)
delta[index] = 1e-5
Expand Down
Loading