fix(api): enforce mustNotBeArchived on repo topics routes - #39260
Open
rathinadev wants to merge 1 commit into
Open
fix(api): enforce mustNotBeArchived on repo topics routes#39260rathinadev wants to merge 1 commit into
rathinadev wants to merge 1 commit into
Conversation
UpdateTopics/AddTopic/DeleteTopic lacked the archived guard the web routes and sibling API write groups enforce, so topics were mutable on an archived repo. Add the guard; reads stay allowed.
GiteaBot
added
the
lgtm/need 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
mustNotBeArchivedto the API repo-topics write routes.They lacked the archived-repo guard the web UI and sibling API write groups
(branches/tags/wiki) enforce, so PUT/DELETE /repos/{owner}/{repo}/topics
succeeded on an archived repo, mutating metadata that should be read-only.
Now returns 423 Locked; reads (GET) unchanged.
Adds an integration test covering the archived case.