Git LFS files are sometimes shown with their reference file as plaintext

[bartvdbraak]

Gitea Version

1.28.2

What happened?

One of our developers was reviewing and came across this anomaly where it was showing a changed Git LFS file their content as the reference file in plaintext while the same page viewed from the fork itself was showing the file as binary data.

Scenario 1	Scenario 2
view	view

Any idea why this inconsistency happens?

How are you running Gitea?

Docker

[Harsh-128]

Hi @bartvdbraak, I looked into this issue and found that the LFS object lookup is not scoped to the repository when the diff is generated.

I made a fix for this and added a regression test to make sure an LFS object from another repository isn't incorrectly treated as an LFS file.

I've tested the changes locally and the relevant tests are passing.

The issue isn't assigned, so I wanted to check first if anyone is already working on it. If not, I'd be happy to open a PR with the fix.

[bartvdbraak]

@Harsh-128 Thanks!