Skip to content

bug(cli): upgrade must not replace customized squad-ci workflows #2361

Done

Description

@tamirdresher

Bug

A real Squad 0.9.x workspace reported that an earlier upgrade replaced a customized .github/workflows/squad-ci.yml with Squad's generated Linux placeholder. The replacement workflow exited successfully without running the repository's actual tests.

Preview.2 now classifies workflow files through the squad-owned plan and creates .local-backup for customized or provenance-unknown content, but it still overwrites the live customized workflow after the backup succeeds. Workflows should be user-owned, use a clearly delimited generated block, or require an explicit confirmation before replacement.

Expected

  • Never replace a customized workflow during unattended upgrade.
  • Preserve the active test commands and workflow triggers.
  • Dry-run must identify the file as user-owned/customized and state the exact action.
  • Add regression coverage for a customized .NET workflow.

Current code

packages/squad-cli/src/cli/core/upgrade.ts includes squad-ci.yml in the project-sensitive Squad-owned workflow set. squad-owned-files.ts backs up customized files and then overwrites them.

Activity

  1. added a commit that references this issue on Nov 1, 2026
    80ed002
  2. added a commit that references this issue on Nov 4, 2026
    d3cf753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions