Skip to content

Docs: Remove Cursor from CLI check list in README#3184

Merged
mnriem merged 2 commits into
github:mainfrom
DyanGalih:docs/3178-cursor-cli-check
Jul 8, 2026
Merged

Docs: Remove Cursor from CLI check list in README#3184
mnriem merged 2 commits into
github:mainfrom
DyanGalih:docs/3178-cursor-cli-check

Conversation

@DyanGalih

Copy link
Copy Markdown
Contributor

Fixes #3178

This PR removes Cursor CLI from the list of agents checked by specify check in the README, as Cursor is an IDE-based integration and is not checked by the CLI tool.

@DyanGalih DyanGalih requested a review from mnriem as a code owner June 26, 2026 02:28
Copilot AI review requested due to automatic review settings June 26, 2026 02:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the README to accurately describe which agent tools are probed during the CLI’s agent-tool check, aligning the docs with how integrations are classified (requires_cli: True/False) in the codebase.

Changes:

  • Removed “Cursor CLI” from the README list of tools checked by the CLI (Cursor is an IDE-first integration and is not prechecked as a required CLI tool).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread README.md Outdated

@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback

@DyanGalih DyanGalih force-pushed the docs/3178-cursor-cli-check branch from cedf298 to 53e84d3 Compare June 30, 2026 15:09
@mnriem mnriem requested a review from Copilot June 30, 2026 15:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread README.md Outdated
@mnriem

mnriem commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Please address Copilot feedback

@DyanGalih

Copy link
Copy Markdown
Contributor Author

Checked the latest two feedback items, and they appear addressed in the current head commit. The README wording now explicitly says the CLI tool must be installed, and the earlier conditional wording has already been reworded. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread README.md Outdated

@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback

@DyanGalih

Copy link
Copy Markdown
Contributor Author

Follow-up update: I pushed commit cb289fb which clarifies README wording to match implementation behavior. The text now states that specify init checks the selected integration tool is installed only when requires_cli is true, and the ignore-agent-tools guidance remains unchanged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Low

@mnriem mnriem self-requested a review July 8, 2026 12:47
@mnriem mnriem merged commit ba1ce36 into github:main Jul 8, 2026
12 checks passed
@mnriem

mnriem commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

kanfil added a commit to tikalk/agentic-sdlc-spec-kit that referenced this pull request Jul 8, 2026
Upstream commits merged (7):

- 94c7ec2 escape TOML control chars so generated command files parse (github#3341)

- 5a901a6 fall through to grep/sed when python3 is a broken stub (github#3312)

- 295eb22 port update-agent-context to Python (github#3387)

- ba1ce36 remove Cursor from CLI check list in README (github#3184)

- 13d2cca document missing CLI flags and integrations (github#3182)

- 0da969d add LLM Wiki extension to community catalog (github#3361)

- a7b4391 release 0.12.8, begin 0.12.9.dev0 (github#3410)

New file: src/specify_cli/_toml_string.py

Conflicts: pyproject.toml (trivial version); base.py (import block —

combined fork accent() with upstream _toml_string imports).

Assisted-by: OpenCode (model: glm-5.2, autonomous)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: README incorrectly lists Cursor as a CLI-checked agent in specify check

3 participants