Skip to content

Consider adding webrick to the whitelist of allowed GitHub Pages dependencies to avoid build warnings #887

Description

@daattali

There are a few issues regarding updating the documentation around webrick not being available in Ruby 3, but this issue is about a different problem.

If I want to support local builds, I must manually add webrick to the Gemfile. However, because of a recent change in jekyll-build-pages, this now results in a warning "github-pages can't satisfy your Gemfile's dependencies" for every build. This means that anyone who wants to host a GitHub Pages repo that uses the default jekyll builder, and also wants to be able to run locally, will always have to see a warning on every GitHub Actions build.

I don't know the security implications of allowing webrick in GitHub Pages, but I hope it can be done. If not, perhaps we should be able to remove that warning message somehow.

Activity

  1. ohadschn commented on Oct 20, 2023

    @ohadschn

    I believe there is a simple workaround, in your Gemfile:

    install_if -> { ENV["GITHUB_ACTIONS"] != "true" } do
        puts "Is GitHub action: #{ENV["GITHUB_ACTIONS"] == "true"}"
        gem "webrick", "~> 1.8"
    end 
  2. janbrasna commented on Aug 17, 2024

    @janbrasna

    No workaround should be needed since v232.

  3. parkr commented on Sep 8, 2024

    @parkr
    Contributor

    @yoannchaudet This issue can be marked completed.

  4. yoannchaudet commented on Sep 10, 2024

    @yoannchaudet
    Contributor

    Fixed via #914 then later #919!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions