Skip to content

Allow Claude docs review to publish its discussion - #77177

Merged
pelikhan merged 6 commits into
mainfrom
copilot/aw-review-claude-code-docs
Nov 12, 2026
Merged

pelikhan merged 6 commits into
mainfrom
copilot/aw-review-claude-code-docs

Conversation

Copilot AI commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

The review workflow finished without a terminal safe output because its discussion call was blocked by the Bash allowlist.

  • Allow safe outputs: Add the safeoutputs CLI to the workflow’s permitted Bash commands.
tools:
  bash:
    - "cat *"
    - "ls *"
    - "grep *"
    - "safeoutputs *"
  • Regenerate the workflow lock to include the updated permission.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix missing terminal safe output in Claude Code documentation review Allow Claude docs review to publish its discussion Nov 12, 2026
Copilot AI requested a review from pelikhan November 12, 2026 15:44
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot we need specialized diagnostics to detect that safeoutputs were blocked.

Copilot AI and others added 3 commits November 12, 2026 15:58
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot we need specialized diagnostics to detect that safeoutputs were blocked.

Added the safeoutputs_command_blocked audit finding, which correlates Claude Bash permission denials with attempted safeoutputs calls and recommends the narrow safeoutputs * allowlist entry. Commit: 82646a29.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot when the CLI proxy is enabled, Bash* is disabled, and specific tools are configured, we should automatically enable safe-outputs CLI. If Bash is explicitly set to false while the CLI proxy is enabled, we should raise an error because these settings are incompatible: CLI calls won’t be available.

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot when the CLI proxy is enabled, Bash* is disabled, and specific tools are configured, we should automatically enable safe-outputs CLI. If Bash is explicitly set to false while the CLI proxy ...

This behavior is already implemented: with safe outputs configured, restricted Bash allowlists receive safeoutputs:* (including with cli-proxy enabled), and explicit bash: false or bash: [] with cli-proxy: true fails validation. The focused compiler tests for both behaviors pass, so no additional changes were needed.

@pelikhan
pelikhan marked this pull request as ready for review November 12, 2026 17:47
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

Copilot AI dynamic review requested due to automatic review settings November 12, 2026 17:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The audit can miss denied safeoutputs calls in stdin pipelines and native permission-denial events without a final result, leaving blocked calls unreported.

2 open issues
What changed in this PR

This PR addresses #77149 by explicitly allowing the Claude documentation-review workflow to invoke safeoutputs. It also adds audit diagnostics for blocked safe-output commands.

Changes:

  • Add safeoutputs * to the workflow’s Bash allowlist and regenerate its lock file.
  • Detect denied Claude safe-output commands and recommend an allowlist update.
  • Add audit tests and document the new finding code.
File Description
pkg/​cli/​audit_safeoutputs.go Detects blocked commands and generates findings and recommendations.
pkg/​cli/​audit_safeoutputs_test.go Tests denial detection and audit reporting.
pkg/​cli/​audit_report_analysis.go Integrates the new audit diagnostics.
pkg/​cli/​audit_finding_codes.go Defines the blocked-command finding code.
.github/​workflows/​claude-code-user-docs-review.md Explicitly allows the safeoutputs CLI.
.github/​workflows/​claude-code-user-docs-review.lock.yml Updates compiled permissions and workflow hashes.
.github/​aw/​debug-playbook.md Documents the finding and recommended remediation.

Review effort: Balanced (auto)

Comment on lines +70 to +71
case "result":
for _, denial := range entry.PermissionDenials {
Comment on lines +89 to +91
return command == "safeoutputs" ||
strings.HasPrefix(command, "safeoutputs ") ||
strings.HasPrefix(command, "safeoutputs\t") ||
…ude-code-docs

# Conflicts:
#	.github/workflows/claude-code-user-docs-review.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts on this branch.

Resolved the generated workflow lock conflict, regenerated workflow locks, and merged main. Merge commit: 7459220.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot run pr-finisher skill

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot run pr-finisher skill

Finisher checks: formatting, lint, and selected unit tests passed locally; the latest completed CI checks pass, and the PR is cleanly mergeable. Two existing review threads remain unresolved, so this is not yet ready for merge. No files were changed.

@pelikhan
pelikhan merged commit 241b6ca into main Nov 12, 2026
67 checks passed
@pelikhan
pelikhan deleted the copilot/aw-review-claude-code-docs branch November 12, 2026 20:13
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Claude Code User Documentation Review: finished without a terminal safe output

3 participants