Repository navigation
Allow Claude docs review to publish its discussion - #77177
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot we need specialized diagnostics to detect that safeoutputs were blocked. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Added the |
|
@copilot when the CLI proxy is enabled, Bash* is disabled, and specific tools are configured, we should automatically enable safe-outputs CLI. If Bash is explicitly set to |
This behavior is already implemented: with safe outputs configured, restricted Bash allowlists receive |
|
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
🟡 Changes recommended
The audit can miss denied safeoutputs calls in stdin pipelines and native permission-denial events without a final result, leaving blocked calls unreported.
2 open issues
What changed in this PR
This PR addresses #77149 by explicitly allowing the Claude documentation-review workflow to invoke safeoutputs. It also adds audit diagnostics for blocked safe-output commands.
Changes:
- Add
safeoutputs *to the workflow’s Bash allowlist and regenerate its lock file. - Detect denied Claude safe-output commands and recommend an allowlist update.
- Add audit tests and document the new finding code.
| File | Description |
|---|---|
pkg/cli/audit_safeoutputs.go |
Detects blocked commands and generates findings and recommendations. |
pkg/cli/audit_safeoutputs_test.go |
Tests denial detection and audit reporting. |
pkg/cli/audit_report_analysis.go |
Integrates the new audit diagnostics. |
pkg/cli/audit_finding_codes.go |
Defines the blocked-command finding code. |
.github/workflows/claude-code-user-docs-review.md |
Explicitly allows the safeoutputs CLI. |
.github/workflows/claude-code-user-docs-review.lock.yml |
Updates compiled permissions and workflow hashes. |
.github/aw/debug-playbook.md |
Documents the finding and recommended remediation. |
Review effort: Balanced (auto)
| case "result": | ||
| for _, denial := range entry.PermissionDenials { |
| return command == "safeoutputs" || | ||
| strings.HasPrefix(command, "safeoutputs ") || | ||
| strings.HasPrefix(command, "safeoutputs\t") || |
…ude-code-docs # Conflicts: # .github/workflows/claude-code-user-docs-review.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Resolved the generated workflow lock conflict, regenerated workflow locks, and merged |
|
@copilot run pr-finisher skill |
Finisher checks: formatting, lint, and selected unit tests passed locally; the latest completed CI checks pass, and the PR is cleanly mergeable. Two existing review threads remain unresolved, so this is not yet ready for merge. No files were changed. |
|
🎉 This pull request is included in a new release. Release: |

The review workflow finished without a terminal safe output because its discussion call was blocked by the Bash allowlist.
safeoutputsCLI to the workflow’s permitted Bash commands.