Skip to content

[static-analysis] RGS-006/RGS-012: suppress false positives in windows.lock.yml WSL Node.js bootstrap - #77079

Merged
pelikhan merged 2 commits into
mainfrom
static-analysis/runner-guard-windows-wsl-node-ignore-4acddfeec7dd6d55
Nov 12, 2026
Merged

pelikhan merged 2 commits into
mainfrom
static-analysis/runner-guard-windows-wsl-node-ignore-4acddfeec7dd6d55

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Warning

Changes to workflow YAML files were excluded from this changeset to avoid GitHub token workflow-write restrictions. Run gh aw compile again on this branch and commit the regenerated .lock.yml files using credentials permitted to update GitHub Actions workflows before merging.

🚨 Runner-Guard Security Finding

Rules: RGS-006 (Curl-Pipe-Bash RCE), RGS-012 (Secret Exfiltration via Outbound HTTP) — both High
File: .github/workflows/windows.lock.yml
Line: 1074 (Setup Node.js in WSL)

Evidence

The 2026-11-12 scan (run 43156253715) reports both findings on the generated Setup Node.js in WSL step. The previous scan attributed them to #76731 as a likely false positive; that PR merged on 2026-11-11 and the findings still fire, so nothing currently covers them. I found no open PR for these rule/file pairs.

The flagged step (generated by windowsWSLNodeBootstrapStep in pkg/workflow/windows_runner.go) does the following:

  • Downloads the Node.js archive, SHASUMS256.txt.asc, and a keyring pinned to a nodejs/release-keys commit with curl -fsSL into a staging directory.
  • Verifies the signed manifest with gpgv, then verifies the archive with sha256sum -c.
  • Only then extracts the archive with tar.

Nothing is piped into a shell (RGS-006), and the requests are plain GETs that carry no secrets or job data (RGS-012).

Remediation

Use the existing inline suppression convention (# runner-guard:ignore <RULE> -- <reason>, honoured by filterRunnerGuardIgnoredFindings; same approach as mcp_setup_scripts.go and central_slash_command_workflow.go):

  • Add two justified runner-guard:ignore comments to the generated pwsh step in pkg/workflow/windows_runner.go.
  • Extend TestRenderStepForRunner* in pkg/workflow/jobs_test.go to assert the markers are emitted.
  • Regenerate windows.lock.yml. A maintainer needs to re-run gh aw compile and commit the lock, because lock files are stripped from PR delivery.

Validation

  • ✅ go test ./pkg/workflow -run Windows|RenderStepForRunner passes.
  • ✅ gh aw compile windows succeeds (1 workflow, 0 warnings).
  • ✅ A throwaway Go test (not committed) confirmed hasRunnerGuardInlineIgnore matches both rules for the regenerated lock at step line 1074. The markers sit within the 35-line look-ahead.
  • ✅ make fmt, custom Go linters and the schema freshness check pass.
  • ⚠️ make agent-report-progress exited non-zero only because golangci-lint is not installed in this sandbox, so the Go lint gate did not run. Impacted tests (sampled, ./pkg/workflow) passed.
  • ⚠️ The runner-guard scanner itself needs Docker, which is unavailable here, so I did not re-run it end to end.

Detected by runner-guard v2.6.0 — CI/CD source-to-sink vulnerability scanner
Workflow run: https://github.com/github/gh-aw/actions/runs/43156253715

🤖 Generated with [Claude Code]((claude.com/redacted)

Generated by 📊 Static Analysis Report · claude · routed: sonnet55 high · ~80 AIC · ⌖ ~2 AIC · ⊞ 10.5K · ◷

  • expires on Nov 18, 2026, 9:34 PM UTC-08:00

@github-actions github-actions Bot added automation cookie Issue Monster Loves Cookies! security labels Nov 12, 2026
@pelikhan
pelikhan marked this pull request as ready for review November 12, 2026 05:58
Copilot AI dynamic review requested due to automatic review settings November 12, 2026 05:58
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: haiku55 xhigh · ~1 AIC · ⌖ ~2 AIC · ◇ ~1 AIC · ⊞ 7.2K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: haiku55 xhigh · ~1 AIC · ⌖ ~2 AIC · ◇ ~1 AIC · ⊞ 8.5K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt61 medium · ~3 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 181 · ◷

Generated by Ponytail Reviewer for #77079

@github-actions

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills...

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~2 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 1.6K · ◷

Generated by PR Specification Reviewer for #77079

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found in the changed lines. The additions place narrowly scoped RGS-006/RGS-012 suppressions in the generated PowerShell step and add regression assertions that both markers are emitted. Static review only; tests were not run per review constraints. The specialist pass was unavailable due to tool-permission rejection, so this assessment is based on the independent diff review.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the targeted Runner-Guard suppressions and accompanying rendering-test assertions.

No open issues 🎉

What changed in this PR

This PR adds targeted Runner-Guard suppressions to gh-aw’s generated Windows WSL Node.js bootstrap, addressing false positives without changing installation behavior.

Changes:

  • Add justified RGS-006 and RGS-012 suppression comments for the existing verified downloads.
  • Extend rendering tests to assert that both suppression markers are emitted.

The generated windows.lock.yml update remains a documented maintainer follow-up before merging.

File Description
pkg/​workflow/​windows_runner.go Emit two justified suppression comments in the WSL bootstrap step.
pkg/​workflow/​jobs_test.go Assert that rendered output contains both suppression markers.

Review effort: Balanced (auto)

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Fix failing check agent (FAILURE): Check run.
  3. Fix failing check conclusion (FAILURE): Check run.

Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering.

Structured data
{
  "completed_task": 0,
  "head": "f1bb3700be30c06919167c6cbe1c6ab0d1070a36",
  "kind": "requested",
  "schema_version": "1",
  "state": "11d018bc12eeb05619adf6a694bfca9b265c4411edb5122b83dbbe2be8457cd6",
  "work": [
    "34f38971738f6a752a646bd7797a6c8d47fb096e4eb6f91e946a91255433c8c4",
    "51e2287c3d1ee41b7e13769862add61dcd292a623cf943abc5968c984e246bcf"
  ],
  "workflow": "pr-sous-chef"
}

Generated by 👨🍳 PR Sous Chef · pi · routed: haiku55 xhigh · ~2 AIC · ⌖ ~2 AIC · ⊞ 6.9K · ◷
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:...

make merge-main completed; main was already up to date. The merge build, 365-workflow recompilation, and final pre-PR validation passed. The failed agent job is due to the runner lacking a reachable Docker daemon for --network-isolation; the conclusion failure is downstream, so there is no repository change that can fix it. I did not trigger CI. The existing lockfile update is committed as c90ade1.

Copilot AI requested a review from gh-aw-bot November 12, 2026 07:11
@pelikhan
pelikhan merged commit df9b5c6 into main Nov 12, 2026
46 checks passed
@pelikhan
pelikhan deleted the static-analysis/runner-guard-windows-wsl-node-ignore-4acddfeec7dd6d55 branch November 12, 2026 13:01
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation cookie Issue Monster Loves Cookies! security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants