Repository navigation
[static-analysis] RGS-006/RGS-012: suppress false positives in windows.lock.yml WSL Node.js bootstrap - #77079
Conversation
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
No blocking issues found in the changed lines. The additions place narrowly scoped RGS-006/RGS-012 suppressions in the generated PowerShell step and add regression assertions that both markers are emitted. Static review only; tests were not run per review constraints. The specialist pass was unavailable due to tool-permission rejection, so this assessment is based on the independent diff review.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the targeted Runner-Guard suppressions and accompanying rendering-test assertions.
No open issues 🎉
What changed in this PR
This PR adds targeted Runner-Guard suppressions to gh-aw’s generated Windows WSL Node.js bootstrap, addressing false positives without changing installation behavior.
Changes:
- Add justified RGS-006 and RGS-012 suppression comments for the existing verified downloads.
- Extend rendering tests to assert that both suppression markers are emitted.
The generated windows.lock.yml update remains a documented maintainer follow-up before merging.
| File | Description |
|---|---|
pkg/workflow/windows_runner.go |
Emit two justified suppression comments in the WSL bootstrap step. |
pkg/workflow/jobs_test.go |
Assert that rendered output contains both suppression markers. |
Review effort: Balanced (auto)
|
🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:
Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering. Structured data{
"completed_task": 0,
"head": "f1bb3700be30c06919167c6cbe1c6ab0d1070a36",
"kind": "requested",
"schema_version": "1",
"state": "11d018bc12eeb05619adf6a694bfca9b265c4411edb5122b83dbbe2be8457cd6",
"work": [
"34f38971738f6a752a646bd7797a6c8d47fb096e4eb6f91e946a91255433c8c4",
"51e2287c3d1ee41b7e13769862add61dcd292a623cf943abc5968c984e246bcf"
],
"workflow": "pr-sous-chef"
}
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
|
🎉 This pull request is included in a new release. Release: |
Warning
Changes to workflow YAML files were excluded from this changeset to avoid GitHub token workflow-write restrictions. Run
gh aw compileagain on this branch and commit the regenerated.lock.ymlfiles using credentials permitted to update GitHub Actions workflows before merging.🚨 Runner-Guard Security Finding
Rules: RGS-006 (Curl-Pipe-Bash RCE), RGS-012 (Secret Exfiltration via Outbound HTTP) — both High
File:
.github/workflows/windows.lock.ymlLine: 1074 (
Setup Node.js in WSL)Evidence
The 2026-11-12 scan (run 43156253715) reports both findings on the generated
Setup Node.js in WSLstep. The previous scan attributed them to #76731 as a likely false positive; that PR merged on 2026-11-11 and the findings still fire, so nothing currently covers them. I found no open PR for these rule/file pairs.The flagged step (generated by
windowsWSLNodeBootstrapStepinpkg/workflow/windows_runner.go) does the following:SHASUMS256.txt.asc, and a keyring pinned to anodejs/release-keyscommit withcurl -fsSLinto a staging directory.gpgv, then verifies the archive withsha256sum -c.tar.Nothing is piped into a shell (RGS-006), and the requests are plain GETs that carry no secrets or job data (RGS-012).
Remediation
Use the existing inline suppression convention (
# runner-guard:ignore <RULE> -- <reason>, honoured byfilterRunnerGuardIgnoredFindings; same approach asmcp_setup_scripts.goandcentral_slash_command_workflow.go):runner-guard:ignorecomments to the generated pwsh step inpkg/workflow/windows_runner.go.TestRenderStepForRunner*inpkg/workflow/jobs_test.goto assert the markers are emitted.windows.lock.yml. A maintainer needs to re-rungh aw compileand commit the lock, because lock files are stripped from PR delivery.Validation
go test ./pkg/workflow -run Windows|RenderStepForRunnerpasses.gh aw compile windowssucceeds (1 workflow, 0 warnings).hasRunnerGuardInlineIgnorematches both rules for the regenerated lock at step line 1074. The markers sit within the 35-line look-ahead.make fmt, custom Go linters and the schema freshness check pass.make agent-report-progressexited non-zero only becausegolangci-lintis not installed in this sandbox, so the Go lint gate did not run. Impacted tests (sampled,./pkg/workflow) passed.Detected by runner-guard v2.6.0 — CI/CD source-to-sink vulnerability scanner
Workflow run: https://github.com/github/gh-aw/actions/runs/43156253715
🤖 Generated with [Claude Code]((claude.com/redacted)