Skip to content

[WIP] Refactor to extract shared Go and Node CI toolchain setup - #77049

Closed
gh-aw-bot with Copilot wants to merge 7 commits into
mainfrom
copilot/refactoring-extract-shared-ci-toolchain
Closed

gh-aw-bot with Copilot wants to merge 7 commits into
mainfrom
copilot/refactoring-extract-shared-ci-toolchain

Conversation

Copilot AI commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor
  • Add shared Go/Node setup primitives and a combined importer; action versions are centralized and unused toolchains are not added.
  • Migrate compatible workflows while preserving versions, cache choices, dependency paths, and setup locations; leave pre-agent and nested-job cases local.
  • Full make recompile succeeded (365 workflows); changed workflows compile and generated lock files are current. Final impacted-test gate reports no Go files/tests impacted.
  • CodeQL review could not complete because the tool request timed out; it must not be retried.

Copilot AI and others added 3 commits November 12, 2026 04:10
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Triage result

  • Category: refactor
  • Risk: medium
  • Total score: 49/100
  • Score breakdown: impact 26, urgency 9, quality 14
  • Recommended action: batch_review
  • Reason: Shared CI toolchain refactor; successful make recompile and no impacted Go tests, but CodeQL timeout and draft status keep it out of auto-merge.

Generated by 🔧 PR Triage Agent · copilot · mai11 · ~5 AIC · ⌖ ~1 AIC · ⊞ 14.9K · ◷

@github-actions

Copy link
Copy Markdown
Contributor

Category: refactor
Risk: medium
Score: 49/100 (impact 26 + urgency 9 + quality 14)
Recommended action: batch_review
Batch: pr-batch:ci-shared-setup
Reason: shared CI toolchain consolidation is moderate-weight but matches the current automation-refactor cluster and should be reviewed with the related setup extraction PRs.

Generated by 🔧 PR Triage Agent · copilot · mai11 · ~6 AIC · ⌖ ~2 AIC · ⊞ 15.9K · ◷

@pelikhan
pelikhan marked this pull request as ready for review November 12, 2026 13:20
Copilot AI dynamic review requested due to automatic review settings November 12, 2026 13:20
@github-actions

Copy link
Copy Markdown
Contributor

🔎 PR Code Quality Reviewer is reviewing code quality for this pull request...

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: haiku55 xhigh · ~2 AIC · ⌖ ~2 AIC · ⊞ 7.2K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: sonnet55 high · ~6 AIC · ⌖ ~2 AIC · ⊞ 8.5K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~3 AIC · ⌖ ~2 AIC · ⊞ 1.6K · ◷

Generated by PR Specification Reviewer for #77049

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Generated by Ponytail Reviewer for #77049

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this change does: It shares Go and Node setup across CI workflows. The combined importer forwards options to the individual setup files.

Should fix

  1. Remove the combined wrapper. It repeats the individual input schemas and forwarding. Importing both setup files directly in its seven callers keeps the same choices and removes about 28 lines. Otherwise, new options must be maintained in two places.

Verdict: Ship.
Lean: -28 lines possible.

Generated by ✂️ Ponytail Reviewer for #77049 · codex · routed: gpt61 medium · ~5 AIC · ⌖ ~1 AIC · ⊞ 181
Comment /ponytail to run again

node-step-name:
type: string
default: "Setup Node.js"
imports:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix: Drop this combined wrapper and import the Go and Node setup files directly: its seven callers need only nine extra lines, while this file repeats both input schemas and forwarding, so each new option otherwise needs changes in two places (about 28 lines saved).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the combined wrapper and migrated its callers to import the Go and Node setup components directly. Commit: 529e8a4.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The imported Node setup runs before the full repository checkout, leaving docs/package-lock.json unavailable for cache hashing and stopping the job before the documentation build.

1 open issue
What changed in this PR

This PR centralizes Go and Node.js setup for gh-aw’s agentic workflows, reducing duplicated action versions and configuration as proposed in #77040.

Changes:

  • Adds configurable Go-only, Node-only, and combined toolchain imports.
  • Migrates workflow setup blocks while retaining version, cache, dependency-path, and step-name options.
  • Updates generated lock files to reflect imports and resulting step ordering.
File Description
.github/​workflows/​visual-regression-checker.md Imports Node setup with docs caching.
.github/​workflows/​visual-regression-checker.lock.yml Updates import metadata and hashes.
.github/​workflows/​unbloat-docs.md Replaces local Node setup with an import.
.github/​workflows/​unbloat-docs.lock.yml Moves imported Node setup before local checkout.
.github/​workflows/​tidy.md Imports combined Go and Node setup.
.github/​workflows/​tidy.lock.yml Emits Go setup before Node setup.
.github/​workflows/​technical-doc-writer.md Imports Node setup with docs caching.
.github/​workflows/​technical-doc-writer.lock.yml Updates import metadata and hashes.
.github/​workflows/​slide-deck-maintainer.md Reuses shared Node setup.
.github/​workflows/​slide-deck-maintainer.lock.yml Updates import metadata and hashes.
.github/​workflows/​shared/​mcp-debug.md Reuses shared Go setup.
.github/​workflows/​shared/​ci-toolchain-setup.md Combines Go and Node imports with forwarded inputs.
.github/​workflows/​shared/​ci-node-setup.md Defines configurable shared Node setup.
.github/​workflows/​shared/​ci-go-setup.md Defines shared Go setup with configurable caching.
.github/​workflows/​shared/​ci-data-analysis.md Imports both toolchains for CI analysis.
.github/​workflows/​semantic-function-refactor.md Imports Go setup with its existing step name.
.github/​workflows/​semantic-function-refactor.lock.yml Updates import metadata and hashes.
.github/​workflows/​purelock.md Imports Go setup with caching disabled.
.github/​workflows/​purelock.lock.yml Records the shared Go import.
.github/​workflows/​pr-finisher.md Reuses combined toolchain setup.
.github/​workflows/​pr-finisher.lock.yml Places setup before branch attachment.
.github/​workflows/​hourly-ci-cleaner.md Imports both toolchains with npm caching.
.github/​workflows/​hourly-ci-cleaner.lock.yml Moves Go setup before Make installation.
.github/​workflows/​go-logger.md Replaces duplicated setup with the combined import.
.github/​workflows/​go-logger.lock.yml Moves Go setup before manifest generation.
.github/​workflows/​deepsec-security-scan.md Imports Node setup with a Node 22 override.
.github/​workflows/​deepsec-security-scan.lock.yml Emits imported Node setup before local checkout.
.github/​workflows/​daily-workflow-security-model.md Imports named Go setup for verification.
.github/​workflows/​daily-workflow-security-model.lock.yml Updates import metadata and hashes.
.github/​workflows/​daily-tlc-test-expert.md Imports named Go setup for implementation tests.
.github/​workflows/​daily-tlc-test-expert.lock.yml Updates import metadata and hashes.
.github/​workflows/​daily-rendering-scripts-verifier.md Imports Node setup with existing cache and name options.
.github/​workflows/​daily-rendering-scripts-verifier.lock.yml Updates imports, hashes, and experiment metadata.
.github/​workflows/​ci-coach.lock.yml Reflects shared analysis imports and earlier Go setup.
.github/​workflows/​avenger.md Imports both toolchains with npm caching.
.github/​workflows/​avenger.lock.yml Moves Go setup before Make installation.
.github/​workflows/​auditor.md Imports both toolchains with custom step names.
.github/​workflows/​auditor.lock.yml Places toolchain setup before collection download.

Review effort: Balanced (auto)

Comment thread .github/workflows/unbloat-docs.md Outdated
Comment on lines +52 to +55
- path: shared/ci-node-setup.md
inputs:
node-cache: npm
node-cache-dependency-path: docs/package-lock.json

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /diagnosing-bugs and /codebase-design. Requesting changes on one confirmed regression.

📋 Key Themes & Highlights

Key Themes

  • Ordering regression (blocking): the compiler prepends imported steps before the workflow own steps:. In unbloat-docs, the imported Setup Node.js with a repo-relative cache-dependency-path now runs before Checkout repository. The committed lock file confirms this order.
  • Duplicated defaults: ci-toolchain-setup.md repeats the defaults of the leaf components, so they can drift.
  • Unused import: shared/mcp-debug.md gains a Go setup import but has no importers in the repo.

Positive Highlights

  • ✅ Pinned action SHAs are kept consistent across the new components.
  • ✅ The purelock go-cache: false comment explains the sandbox Go module cache, which is useful context.
  • ✅ Most other agent jobs keep checkout before setup, so the regression is limited to the cases above.

Notes

  • Skill selection was done by direct classification of the diff. The pr-triage agent was not invoked.
  • The base commit was not fetchable here, so I compared against the pre-PR unbloat-docs.md diff, not the base lock file.

@copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~9 AIC · ⌖ ~2 AIC · ⊞ 6.6K
Comment /matt to run again

default: "Setup Go"
node-version:
type: string
default: "24"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/codebase-design] The defaults are duplicated: node-version (24), node-step-name, go-step-name, and go-cache appear here and again in ci-go-setup.md and ci-node-setup.md. A default changed in one place silently diverges for combined importers. Consider letting the leaf components own the defaults, or adding a check that they match.

@copilot please address this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the combined wrapper, so the Go and Node defaults are now defined only by their leaf components. Commit: 529e8a4.

return;
}
}
imports:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/codebase-design] No workflow in this repo imports shared/mcp-debug.md (it is only referenced from .github/aw/debug-bootstrap.md), and that doc describes it as an executable import that changes tools and outputs. This Go setup import gives any future importer an unexpected side effect. Consider removing it, or documenting why this shared component needs the Go toolchain.

@copilot please address this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented that the Go setup is required by the following dependency/build steps that build the local gh-aw MCP server. Commit: 529e8a4.

Comment thread .github/workflows/unbloat-docs.md Outdated
expires: "2d"
labels: [documentation, automation, doc-unbloat]
reviewers: [copilot]
- path: shared/ci-node-setup.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/diagnosing-bugs] Regression: imported steps are placed before the workflow own steps:, so the imported Setup Node.js now runs before Checkout repository. Its cache-dependency-path: docs/package-lock.json is resolved before the repo is checked out, so setup-node cannot find the lockfile and the cache step fails. Before this PR the step ran after checkout. The committed unbloat-docs.lock.yml shows the broken order (Setup Node.js is emitted before Checkout repository).

💡 Suggested fix

Keep Setup Node in this workflow steps: after Checkout repository and drop the import for this workflow. Then recompile and confirm the agent job order in the lock file. Imports are prepended, so an import cannot run after checkout here.

@copilot please address this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved Node setup into the workflow’s local steps immediately after repository checkout and regenerated the lock; the docs lockfile is now available for cache hashing. Commit: 529e8a4.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Review (.github/workflows/shared/ci-toolchain-setup.md:26): address unresolved feedback - Review comment
  3. Review (.github/workflows/shared/ci-toolchain-setup.md:14): address unresolved feedback - Review comment
  4. Review (.github/workflows/shared/mcp-debug.md:132): address unresolved feedback - Review comment
  5. Review (.github/workflows/unbloat-docs.md:52): address unresolved feedback - Review comment
  6. Fix failing check conclusion (FAILURE): Check run.

Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering.

Structured data
{
  "completed_task": 0,
  "head": "a695771ae08edad61d49a1cd22617b0dcd2f39d1",
  "kind": "requested",
  "schema_version": "1",
  "state": "d945863a2066fd31f0d529e52ff326f39609914b429da0870b3f3028bd3d4f65",
  "work": [
    "284d1005c7569ff069fdcff72dcfad7e30ba04bdf3179a807f72bb0ee723ea82",
    "51e2287c3d1ee41b7e13769862add61dcd292a623cf943abc5968c984e246bcf",
    "553506e7174b99d9cd305b0272bf217e5ebf39303d703e1198958f5835b3a5a3",
    "6a8629b400a767d35e666913851479f5188b67cd4ae3103bcd4df2b752779ee6",
    "793de646e3f5c0b63419e1e6932997719a9219d570f3cb557f9ee03259c2abda"
  ],
  "workflow": "pr-sous-chef"
}

Generated by 👨🍳 PR Sous Chef · pi · routed: haiku55 xhigh · ~3 AIC · ⌖ ~2 AIC · ⊞ 6.9K · ◷
Comment /souschef to run again

Copilot AI and others added 2 commits November 12, 2026 14:10
…xtract-shared-ci-toolchain

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:...

Merged the latest main and addressed the four assigned review comments in 529e8a4. All 365 workflows compiled and the final pre-PR validation passed. The reported reviewer conclusion failure was the tool-failure-count=6 grader; I did not trigger a rerun. CodeQL timed out; I did not retry it.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.

Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering.

Structured data
{
  "completed_task": 0,
  "head": "529e8a48343bef8c1ce409f3cc5721a5fd6ad684",
  "kind": "requested",
  "schema_version": "1",
  "state": "b0ed87fb82cafe64986371e5241b8db6f9d0d09c85de3ccf7ca0639bc056a73f",
  "work": [],
  "workflow": "pr-sous-chef"
}

Generated by 👨🍳 PR Sous Chef · pi · routed: haiku55 xhigh · ~4 AIC · ⌖ ~2 AIC · ⊞ 6.9K · ◷
Comment /souschef to run again

…xtract-shared-ci-toolchain

# Conflicts:
#	.github/workflows/auditor.lock.yml
#	.github/workflows/avenger.lock.yml
#	.github/workflows/ci-coach.lock.yml
#	.github/workflows/daily-rendering-scripts-verifier.lock.yml
#	.github/workflows/daily-tlc-test-expert.lock.yml
#	.github/workflows/daily-workflow-security-model.lock.yml
#	.github/workflows/deepsec-security-scan.lock.yml
#	.github/workflows/go-logger.lock.yml
#	.github/workflows/hourly-ci-cleaner.lock.yml
#	.github/workflows/pr-finisher.lock.yml
#	.github/workflows/purelock.lock.yml
#	.github/workflows/semantic-function-refactor.lock.yml
#	.github/workflows/slide-deck-maintainer.lock.yml
#	.github/workflows/technical-doc-writer.lock.yml
#	.github/workflows/tidy.lock.yml
#	.github/workflows/unbloat-docs.lock.yml
#	.github/workflows/visual-regression-checker.lock.yml

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:...

Merged latest main using make merge-main and pushed 4d7fe2cd. Resolved 17 generated lock-file conflicts by recompiling; existing PR changes are preserved. All 365 workflows compile, final validation and secret scans pass. CodeQL timed out and was not retried. No CI was triggered manually.

@github-actions

Copy link
Copy Markdown
Contributor

Triage

  • Category: refactor
  • Risk: medium
  • Total score: 49 (impact 26 + urgency 9 + quality 14)
  • Recommended action: batch_review
  • Batch: pr-batch:ci-shared-setup
  • Reason: shared CI toolchain extraction is well-scoped but broader in blast radius; grouped review keeps risk manageable and aligns with the adjacent workflow consolidation batch.

Generated by 🔧 PR Triage Agent · copilot · mai11 · ~4 AIC · ⌖ ~2 AIC · ⊞ 15.9K · ◷

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.

Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering.

Structured data
{
  "completed_task": 0,
  "head": "4d7fe2cd5f15f591536974c49b3894f552f10b8d",
  "kind": "requested",
  "schema_version": "1",
  "state": "536d2c737f483f66b3e114421ae51a21d667d0f57a3538663974d9fdc3e88931",
  "work": [],
  "workflow": "pr-sous-chef"
}

Generated by 👨🍳 PR Sous Chef · pi · routed: haiku55 xhigh · ~2 AIC · ⌖ ~2 AIC · ⊞ 6.9K · ◷
Comment /souschef to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactoring] Extract shared Go and Node CI toolchain setup into a shared component

4 participants