Repository navigation
[log] Add debug logging to cli package and audit search files - #77033
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the changes are limited to diagnostic logging across the specified CLI paths without altering functional behavior.
No open issues 🎉
What changed in this PR
Adds namespace-specific pkg/logger debug instrumentation to five pkg/cli files, improving diagnostics for package resolution, audit search processing, and threat-detection log parsing without changing functional behavior.
Changes:
- Adds package-specific logging for local and remote workflow package resolution and asset discovery.
- Logs audit search inputs, ranking results, and clustering sizes.
- Logs quota details and missing or conflicting threat-detection conclusions.
| File | Description |
|---|---|
| pkg/cli/audit_threat_detection_logs.go | Logs quota details and missing or conflicting conclusion-log outcomes. |
| pkg/cli/audit_search.go | Logs audit search inputs, ranking results, and clustering metrics. |
| pkg/cli/add_workflow_package_specs.go | Logs local and remote workflow package specification counts. |
| pkg/cli/add_workflow_package_assets.go | Logs explicit and auto-scanned skill and agent asset resolution. |
| pkg/cli/add_workflow_local_package.go | Logs local package resolution, manifest discovery, and resolved asset counts. |
Review effort: Lite (auto)
pelikhan
deleted the
log/go-logger-cli-package-audit-280c560109d8a35a
branch
November 12, 2026 03:35
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds
pkg/loggerdebug logging to 5pkg/clifiles that had none. The pre-flight manifest listed many files that already log through package-level loggers, so I picked files confirmed to have no logging calls.Changes
add_workflow_local_package.gocli:add_workflow_local_packageadd_workflow_package_assets.gocli:add_workflow_package_assetsadd_workflow_package_specs.gocli:add_workflow_package_specsaudit_search.gocli:audit_searchaudit_threat_detection_logs.gocli:audit_threat_detection_logsValidation
make buildandmake fmtpass.len()calls, with no side effects.steercomments.🤖 Generated with [Claude Code]((claude.com/redacted)