Repository navigation
[safe-output-integrator] test: cover remaining safe-output types in handler config tests and fixtures - #76931
Merged
pelikhan merged 1 commit intoNov 11, 2026
Conversation
…ixtures Add handler config test cases for create-security-advisory, add-security-advisory-comment, create-agent-session, and set-issue-field, and add fixtures for the two security advisory safe-output types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two security-advisory workflow fixtures lack the required authentication configuration and will fail compilation, while the added test cases duplicate existing coverage without asserting the new fields.
3 open issues
What changed in this PR
This pull request expands safe-output handler configuration coverage and adds Copilot workflow fixtures for security advisory operations.
Changes:
- Adds handler configuration test cases for security advisories, agent sessions, and issue fields.
- Adds fixtures for creating security advisories and commenting on existing advisories.
- The new advisory fixtures lack required authentication and complete tool-input guidance, while two added test cases duplicate existing coverage.
| File | Description |
|---|---|
| pkg/workflow/compiler_safe_outputs_config_test.go | Extends handler configuration tests with security advisory cases and duplicate agent-session and issue-field cases. |
| pkg/cli/workflows/test-copilot-create-security-advisory.md | Adds a Copilot fixture for creating a security advisory. |
| pkg/cli/workflows/test-copilot-add-security-advisory-comment.md | Adds a Copilot fixture for commenting on an existing security advisory. |
Review effort: Lite (auto)
Comment on lines
+8
to
+9
| add-security-advisory-comment: | ||
| max: 1 |
Comment on lines
+8
to
+9
| create-security-advisory: | ||
| max: 1 |
Comment on lines
+1016
to
+1020
| name: "create agent session config", | ||
| safeOutputs: &SafeOutputsConfig{ | ||
| CreateAgentSessions: &CreateAgentSessionConfig{ | ||
| BaseSafeOutputConfig: BaseSafeOutputConfig{ | ||
| Max: strPtr("1"), |
pelikhan
deleted the
safe-output-coverage-security-advisory-agent-session-8a81fc6d671f7074
branch
November 11, 2026 21:46
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Fills coverage gaps for supported safe-output types.
New workflow fixtures
test-copilot-create-security-advisory.md(create-security-advisory)test-copilot-add-security-advisory-comment.md(add-security-advisory-comment)New Go test cases (
TestAddHandlerManagerConfigEnvVar)create_security_advisoryadd_security_advisory_commentcreate_agent_sessionset_issue_fieldNewly covered types: 6
Validation
gofmtclean on the edited test file.go testcould not run in this environment: the module requires Go 1.27.4 and the toolchain download failed (TLS error). CI should confirm.Notes
noopandreport_incomplete/missing_datareport keys are handled by the diagnostics registry and were not added to the handler-config test..github/skills/reporting/SKILL.mdwas left uncommitted.