Repository navigation
Use Microsoft-approved npm feed across repository projects - #76921
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review. PR Code Quality ReviewerOutcome: The agent completed and reported one or more actions. The no-op output is a completion signal, not a claim that no action was taken. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Specification Reviewer completed successfully!
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
Review
The repository-wide registry override introduces a potentially breaking dependency on a Microsoft-specific endpoint for forks, external contributors, and hosted CI. Please verify universal reachability or scope the override to environments that can access the feed.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again
| @@ -0,0 +1 @@ | |||
| registry=https://packagefeedproxy.microsoft.io/npm/ | |||
There was a problem hiding this comment.
Using this Microsoft-specific proxy as the repository-wide default can make ordinary forked PRs and GitHub-hosted CI unable to install dependencies when the runner cannot reach the feed.
💡 Make availability explicit or preserve a public fallback
The new root config applies to root-level npm commands, including installs invoked by workflows, while the per-project files apply to every local install. Please verify this endpoint is reachable from all supported contributors and runners (not only the author’s environment), or scope it to an internal CI/user configuration rather than committing it as the universal default.
There was a problem hiding this comment.
Reviewed PR head a46343b69c08e5fd0d40c9111acd16e69cfac873 (open, non-draft, same-repository). Applicable contract: specs/security-architecture-spec.md SG-03; supporting network contract: .github/aw/network.md (node ecosystem allowlist).
Blocking finding: the PR makes (packagefeedproxy.microsoft.io/redacted) the committed registry for all npm projects, but the curated node allowlist does not include that host. Workflows using network: [node]` will therefore block npm access, contrary to the stated approved-feed behavior. The inline comment identifies the changed documentation line and the required fix: synchronize the runtime allowlist and conformance evidence, or keep the feed command-scoped.
Coverage: reviewed the captured metadata, complete prefetched diff, PR-head documents, and existing review comments; no code, tests, or specifications were modified by this review.
Generated by PR Specification Reviewer for #76921 · copilot · gpt50 · ~3 AIC · ⌖ ~2 AIC · ⊞ 1.6K
Comment /review-specs to run again
| Use this skill when npm downloads are blocked by the Microsoft corporate network or VPN. Run commands in the affected package directory. Prefer `npm ci` with the existing lockfile and default registry when access works; do not change dependency versions to solve a network failure. | ||
| Use this skill when npm downloads are blocked by the Microsoft corporate network or VPN. Run commands in the affected package directory. Prefer `npm ci` with the existing lockfile and configured registry when access works; do not change dependency versions to solve a network failure. | ||
|
|
||
| This repository configures the Microsoft-approved `https://packagefeedproxy.microsoft.io/npm/` registry in the root and each npm project's `.npmrc`, following [githubnext.com](https://github.com/githubnext/githubnext.com/blob/main/.npmrc). Keep the per-project settings: npm does not inherit the root `.npmrc` when a nested package is the project root. npm's default `replace-registry-host=npmjs` routes existing npmjs lockfile URLs through the configured registry without rewriting lockfiles. |
There was a problem hiding this comment.
SG-03 in specs/security-architecture-spec.md requires network access to be restricted to explicitly allowed domains. The repository's node allowlist in .github/aw/network.md currently covers registry.npmjs.org, npmjs.com, and yarnpkg.com, but not packagefeedproxy.microsoft.io. As written, workflows using network: [node] will block the newly configured registry, so this change does not provide a working approved-feed path. Please either add the feed to the curated runtime allowlist (with corresponding implementation and conformance evidence) or keep the feed command-scoped rather than committing it as the default registry; update the affected contract and docs consistently.
There was a problem hiding this comment.
🟡 Changes recommended
The registry changes introduce critical active issues because affected sandboxed workflows lack firewall allowlist access to packagefeedproxy.microsoft.io, causing their npm installs to be denied.
2 open issues
What changed in this PR
This pull request configures the Microsoft-approved npm registry across the repository root and seven nested npm projects while preserving existing dependency versions, lockfiles, and the docs project's legacy peer-dependency setting.
Changes:
- Added the approved registry to all reviewed npm configuration files.
- Preserved
legacy-peer-deps=truefor the docs project. - Updated npm troubleshooting guidance for registry configuration and lockfile URL routing.
- Existing lockfiles in three projects still reference the old feed, and applicable workflow network policies do not allow the new registry host.
- The docs README still contains guidance for the old registry.
| File | Description |
|---|---|
| specs/otel/.npmrc | Configures the approved npm registry for the OpenTelemetry specification project. |
| pkg/workflow/taint/javascript/.npmrc | Configures the approved npm registry for the JavaScript taint-analysis project. |
| pkg/workflow/actionslanguageservice/conformance/.npmrc | Configures the approved npm registry for the action language service conformance project. |
| eslint-factory/.npmrc | Configures the approved npm registry for the ESLint factory project. |
| docs/.npmrc | Adds the approved registry while preserving the docs project's legacy peer-dependency setting. |
| actions/setup/js/.npmrc | Configures the approved npm registry for the JavaScript setup project. |
| .npmrc | Configures the approved npm registry for repository-root npm commands. |
| .github/workflows/.npmrc | Configures the approved npm registry for the workflow tooling project. |
| .github/skills/npm/SKILL.md | Documents the configured npm registry and lockfile URL routing behavior. |
Review effort: Lite (auto)
| @@ -0,0 +1 @@ | |||
| registry=https://packagefeedproxy.microsoft.io/npm/ | |||
| @@ -0,0 +1 @@ | |||
| registry=https://packagefeedproxy.microsoft.io/npm/ | |||
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design and /grill-with-docs (selected via pr-triage). Requesting changes on consistency gaps between the new registry and existing tooling.
📋 Key Themes
- Three lockfiles still pin
ms-feed-25URLs.replace-registry-host=npmjsdoes not rewrite them. make check-npm-1esandscripts/check-npm-1es.mjsstill validate againstms-feed-25.docs/README.md:45passes an explicitms-feed-25registry override.- The root
.npmrcalso applies to workflow steps that runnpm installfromGITHUB_WORKSPACE, including theagentjob.
✅ Positive highlights
- Per-project
.npmrcfiles are needed because npm does not inherit a parent config for nested project roots. docs/.npmrckeepslegacy-peer-deps=true.
Caveat: CI reachability of packagefeedproxy.microsoft.io was not verified. The local working tree was dirty, so these findings are based on PR head content.
@copilot please address the review comments above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~9 AIC · ⌖ ~2 AIC · ⊞ 6.6K
Comment /matt to run again
| Use this skill when npm downloads are blocked by the Microsoft corporate network or VPN. Run commands in the affected package directory. Prefer `npm ci` with the existing lockfile and default registry when access works; do not change dependency versions to solve a network failure. | ||
| Use this skill when npm downloads are blocked by the Microsoft corporate network or VPN. Run commands in the affected package directory. Prefer `npm ci` with the existing lockfile and configured registry when access works; do not change dependency versions to solve a network failure. | ||
|
|
||
| This repository configures the Microsoft-approved `https://packagefeedproxy.microsoft.io/npm/` registry in the root and each npm project's `.npmrc`, following [githubnext.com](https://github.com/githubnext/githubnext.com/blob/main/.npmrc). Keep the per-project settings: npm does not inherit the root `.npmrc` when a nested package is the project root. npm's default `replace-registry-host=npmjs` routes existing npmjs lockfile URLs through the configured registry without rewriting lockfiles. |
There was a problem hiding this comment.
[/grill-with-docs] The new paragraph says replace-registry-host=npmjs routes existing lockfile URLs through the configured registry. That only applies to registry.npmjs.org entries. Lockfiles in actions/setup/js (79 entries), pkg/workflow/actionslanguageservice/conformance (31) and pkg/workflow/taint/javascript (8) still pin ms-feed-25.pkgs.visualstudio.com, and npm leaves those URLs unchanged.
💡 Suggested fix
State the limitation explicitly, for example: lockfile entries that already point at ms-feed-25 are not rerouted, so those projects still need that host reachable. In the arborist reify logic, the host match only applies to registry.npmjs.org when the setting is npmjs.
@copilot please address this.
|
|
||
| This repository configures the Microsoft-approved `https://packagefeedproxy.microsoft.io/npm/` registry in the root and each npm project's `.npmrc`, following [githubnext.com](https://github.com/githubnext/githubnext.com/blob/main/.npmrc). Keep the per-project settings: npm does not inherit the root `.npmrc` when a nested package is the project root. npm's default `replace-registry-host=npmjs` routes existing npmjs lockfile URLs through the configured registry without rewriting lockfiles. | ||
|
|
||
| ## Use the 1ES public npm feed |
There was a problem hiding this comment.
[/grill-with-docs] This skill now names two feeds. The new paragraph (line 10) says the configured registry is packagefeedproxy.microsoft.io, but this section still tells users to retry through ms-feed-25.pkgs.visualstudio.com (line 17, outside the diff). The escalation text at line 48 also names ms-feed-25.
💡 Suggested fix
Decide which feed is the approved fallback and state it in one place. If ms-feed-25 remains the verified fallback for pinned versions, explain why it differs from the configured registry, and update line 48 to match.
@copilot please address this.
| @@ -1 +1,2 @@ | |||
| legacy-peer-deps=true | |||
| registry=https://packagefeedproxy.microsoft.io/npm/ | |||
There was a problem hiding this comment.
[/codebase-design] make check-npm-1es validates against ms-feed-25, hardcoded in scripts/check-npm-1es.mjs:11. The docs/README.md:52 instructions tell contributors to run it after dependency updates. Installs now use packagefeedproxy, so the check can pass while installs fail, or the reverse.
💡 Suggested fix
Either point the check at the same registry as .npmrc, or document that it deliberately validates the 1ES feed. Also update the explicit --registry=ms-feed-25 command in docs/README.md:45, which now overrides this setting.
@copilot please address this.
| @@ -0,0 +1 @@ | |||
| registry=https://packagefeedproxy.microsoft.io/npm/ | |||
There was a problem hiding this comment.
[/grill-with-docs] This root .npmrc has no sibling package.json, so it affects only npm commands run from the repository root. Generated workflow steps do this, for example cd "${GITHUB_WORKSPACE}" && npm install --ignore-scripts --no-save ... in .github/workflows/architecture-guardian.lock.yml:800. Those now fetch from packagefeedproxy.microsoft.io, which the PR does not mention. The passing head CI checks (JS Tests, macOS build) do not cover the agent network allowlist.
💡 Suggested fix
Confirm that packagefeedproxy.microsoft.io is reachable from the runners and sandboxes that execute these steps, and that the allowlist in .github/aw/network.md covers it. Alternatively, keep root-level commands on npmjs and document that choice.
@copilot please address this.
ok
|
🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:
Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering. Structured data{
"completed_task": 0,
"head": "a46343b69c08e5fd0d40c9111acd16e69cfac873",
"kind": "requested",
"schema_version": "1",
"state": "42e796f7d97399e778ea910634dc6a57488508ba0e9928b913516ef1341bc494",
"work": [
"4ad0af867eb2e8f20a7cfa3518c1e743b710b3cc6bc92bb46f45444d797e5672",
"8ed558537c0c74042dcc6cdd25749bfe42e14d4d6b44d4245e2824060d29ca29",
"92ba94f801f568965dc9d395cc5ab179ea17fe361442bc9673b5706e22ddb5d8",
"b65ee61542b06bcafc4b1f6157b3251fbf7bee26d7ea92e8d13e632627af78b1",
"cf29ce14453a75d50dbf65dd748a051355d7fca1f2d695722bcdd3ae33a83a75",
"e6616c9edd4c236abc8e15b8848b71f084cc522fce4d3c05d66cc83f1a2cee4a"
],
"workflow": "pr-sous-chef"
}
|
|
🎉 This pull request is included in a new release. Release: |

Summary
Use the Microsoft-approved npm registry at
https://packagefeedproxy.microsoft.io/npm/, matching the githubnext.com configuration.Configure the repository root and all seven npm projects explicitly because npm does not inherit a parent project's
.npmrc. Preserve the docs'legacy-peer-depssetting and existing dependency versions and lockfiles. Update npm troubleshooting guidance to document the configured feed and npm's existing lockfile URL routing.Validation
replace-registry-host=npmjssettings for the root and all seven npm projects with user/global npm configuration isolated.yaml@2.8.1metadata and tarball through the approved feed.make agent-report-progresspassed.