Repository navigation
Fix visual review capture contract and incomplete-report processing - #76585
Conversation
Keep browser capture on sandbox loopback with provisioned build artifacts and supported CLI commands. Preserve unavailable baseline status without blocking capture. Limit the lifecycle-read exemption to the built-in diagnostic handler identity, and retain HTTP/request context for empty API errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
SDK permissions block the readiness probe, contract tests still require the removed setup step, and substring-based error classification can incorrectly turn publication failures into successful skips.
3 open issues
What changed in this PR
Updates gh-aw’s visual review workflow and safe-output processing to address the capture and incomplete-report failures described in #76555.
Changes:
- Moves preview startup into the sandbox, corrects Playwright CLI instructions, and distinguishes missing baselines from capture failures.
- Exempts only the built-in
report_incompletehandler from PR-state reads while retaining checks for custom and mutating handlers. - Adds sanitized fallback API diagnostics, regression coverage, and a regenerated workflow lock.
| File | Description |
|---|---|
actions/setup/js/visual_regression_workflow.test.cjs |
Adds workflow contract checks for preview, capture, baseline handling, and isolation. |
actions/setup/js/safe_output_handler_manager.test.cjs |
Covers diagnostic exemptions, once-only publication, and custom/deferred handler checks. |
actions/setup/js/safe_output_handler_manager.cjs |
Registers the built-in diagnostic exemption by function identity. |
actions/setup/js/error_helpers.test.cjs |
Tests empty-message fallbacks and sanitized request IDs. |
actions/setup/js/error_helpers.cjs |
Adds HTTP status and request identity to empty-error diagnostics. |
.github/workflows/visual-regression-checker.md |
Replaces runner-host serving with sandbox-local preview and revised capture instructions. |
.github/workflows/visual-regression-checker.lock.yml |
Regenerates execution configuration without the host exception or server setup steps. |
Review effort: Max (auto)
Update build-only checkout contracts and grant the exact bounded readiness command. Classify API errors using structured HTTP status so request IDs cannot mask publication failures or produce incorrect authentication guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:
Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering. Structured data{
"completed_task": 0,
"head": "87ee21a1f620599c1f9fa2f9c20eebda53a2b0b8",
"kind": "requested",
"schema_version": "1",
"state": "9d1852961bf3646db92495ddba876cd3ecdc2c47c1f0ac4266b1c073ced8e0f5",
"work": [
"b855fc6fcb55b78d8a97b8924885cae846819f33bbc1dec6e0b470fbcf24991c"
],
"workflow": "pr-sous-chef"
}
|
…w-reporting-failure Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Merged the latest |
|
🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:
Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering. Structured data{
"completed_task": 0,
"head": "657da81b8d991730494f2a5f3e119097620b2e76",
"kind": "requested",
"schema_version": "1",
"state": "b339c51b9fb8beae1023db56a6c3d5b0b478aa4dcad3d3d95b77d94369f65ca9",
"work": [],
"workflow": "pr-sous-chef"
}
|
|
@copilot resolve the merge conflicts on this branch. |
…w-reporting-failure # Conflicts: # .github/workflows/visual-regression-checker.lock.yml Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Merged the latest |
The merge conflicts were resolved in |
|
🎉 This pull request is included in a new release. Release: |


Summary
Fixes the two distinct boundaries observed in Visual Regression Checker run 42849185332, relating to #76555:
report_incompletehandler from unnecessary PR lifecycle reads, using private function-identity registration. Custom replacements and every mutating handler retain fresh fail-closed checks in initial and deferred processing.Evidence and validation
066a23d0ff56421f5ed7d43475145a7d63845e4c, not evidence of a current-main regression. The agent stopped before navigation; later PR GET 500 occurred after successful comment publication.make fmt,make build,make recompile, static typecheck, and finalmake agent-report-progresspassed. Final workflow drift check compiled 365 workflows; existing repository-wide warnings remain.Overlap check and scope
Checked open PR inventory and candidate file patches before implementation and again before publication. #76537 (now merged) changes tool lists only; #76425 touches a different manager claim-settlement path; #76538 concerns CLI-proxy capture, and #76580 provisioning does not touch these paths. No equivalent fix found; generated-lock/shared-file merge conflicts are possible, but their behavior is not duplicated here.
No workflow dispatch/rerun or production-write replay performed. Actual hosted preview startup, permission matching (owned by separate work), browser rendering/proxy/reachability, and screenshot output remain unverified; this PR does not claim live recovery.
Authored Markdown security overview
.github/workflows/visual-regression-checker.mdfrontmatter/setup