Skip to content

[avenger] Fix stale activity_report permissions assertion in side-repo test - #75710

Merged
pelikhan merged 1 commit into
mainfrom
avenger/fix-side-repo-activity-report-assertion-fd291c6c519c5a91
Nov 7, 2026
Merged

pelikhan merged 1 commit into
mainfrom
avenger/fix-side-repo-activity-report-assertion-fd291c6c519c5a91

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

Potential security threats were detected in the agent output.

Review the workflow run logs for details.

CI failure found

CI run 42388583213 failed on job Integration: Workflow Misc Part 2, step Run integration tests - Workflow Misc Part 2.

The failing test was TestSideRepoMaintenanceWorkflowGenerated_EndToEnd. Commit 8322593 added inline comments to the activity_report permission lines (for example actions: read # Read workflow runs...). The test asserted the exact substring actions: read\n contents: read\n issues: write, which no longer matches.

Fix

The generator output is correct. I changed only the assertion in pkg/workflow/side_repo_maintenance_integration_test.go to a regex that matches the three permission lines and tolerates trailing comments.

Validation

  • make fmt: passes
  • go vet -tags integration ./pkg/workflow: passes
  • make test-unit: passes
  • TestSideRepoMaintenanceWorkflowGenerated_EndToEnd (and the TestSideRepo* group): passes

Not addressed (environmental, sandbox-only)

make lint was not run because golangci-lint is not installed in this sandbox. The remaining integration failures reproduce only here and are not code regressions:

  • TestNVXStagedMuslCopilotInvokesAPIProxy: needs a working Docker daemon.
  • TestDocumentationGalleryWorkflowsCompile: TLS certificate error fetching raw.githubusercontent.com.
  • TestCredentialFreePromptEnvironment: fails when GITHUB_TOKEN is inherited from the sandbox environment.

The CI job log could not be read through the Actions log tool (blocked by integrity policy), so the failing signal was reproduced locally from the step command in ci.yml.

Generated by 🦸 Avenger · copilot · routed: haiku55 xhigh · ~4 AIC · ⌖ ~2 AIC · ⊞ 3.9K · ◷

  • expires on Nov 9, 2026, 8:39 AM UTC-08:00

@pelikhan
pelikhan marked this pull request as ready for review November 7, 2026 17:32
Copilot AI dynamic review requested due to automatic review settings November 7, 2026 17:32
@pelikhan
pelikhan merged commit 4d86b73 into main Nov 7, 2026
18 of 22 checks passed
@pelikhan
pelikhan deleted the avenger/fix-side-repo-activity-report-assertion-fd291c6c519c5a91 branch November 7, 2026 17:33
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: opus55 medium · ~11 AIC · ⌖ ~2 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

Warning

Threat detection engine error

Threat detection could not complete its analysis due to a tooling error. This is not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs to troubleshoot the error.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: gpt56 max · ~1 AIC · ⌖ ~2 AIC · ⊞ 6.3K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt56 max · ~3 AIC · ⌖ ~1 AIC · ⊞ 118 · ◷

Generated by Ponytail Reviewer for #75710

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active moderate finding remains because the regression test accepts malformed permission values instead of requiring exact matches.

1 open issue
What changed in this PR

Updates the side-repository maintenance integration test so the activity_report permission assertion tolerates inline YAML comments.

Changes:

  • Replaces the brittle exact permission substring check with a regular expression.
  • Continues validating the expected permission order and values.
  • The regex should match exact permission values while allowing optional YAML comments; the current pattern may accept malformed values.
File Summary Review status
pkg/​workflow/​side_repo_maintenance_integration_test.go Relaxes the activity_report permission assertion to accommodate trailing comments. Moderate issue: tighten the regex to reject malformed permission values.

This pull request requires changes.

Review effort: Lite (auto)

assert.Contains(t, contentStr, "title: '[aw] agentic status report'",
"generated workflow should create the activity_report issue with the expected title")
assert.Contains(t, contentStr, "actions: read\n contents: read\n issues: write",
assert.Regexp(t, `actions: read[^\n]*\n contents: read[^\n]*\n issues: write`, contentStr,
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants