Skip to content

Enable scoped specification updates on PR branches - #75697

Merged
pelikhan merged 1 commit into
mainfrom
copilot/update-pull-request-branch-access
Nov 7, 2026
Merged

pelikhan merged 1 commit into
mainfrom
copilot/update-pull-request-branch-access

Conversation

Copilot AI commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

PR Specification Reviewer currently posts specification replacements as review proposals. This change enables it to commit eligible updates to the triggering PR branch, including protected Markdown files.

  • Publication: Add push-to-pull-request-branch, limited to one push and five files within the existing specification Markdown allowlist. Disable fallback PR creation.
  • Boundaries: Keep contributor forks comment-only, retain stale-head checks, and prohibit implementation changes or weakened normative/security requirements.
  • Reviewer behavior: Enable editing, update synchronization instructions and evals, and regenerate the workflow lock and slash-command help.
push-to-pull-request-branch:
  target: triggering
  max: 1
  allowed-files:
    - 'specs/*.md'
    - 'docs/src/content/docs/specs/*.md'
    - 'docs/src/content/docs/experimental/experiments-specification.md'
  protected-files: allowed
  fallback-as-pull-request: false

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Allow PR specification reviewer to push scoped Markdown updates Enable scoped specification updates on PR branches Nov 7, 2026
Copilot AI requested a review from pelikhan November 7, 2026 15:12
@pelikhan
pelikhan marked this pull request as ready for review November 7, 2026 15:12
Copilot AI dynamic review requested due to automatic review settings November 7, 2026 15:12
@pelikhan
pelikhan merged commit a61b719 into main Nov 7, 2026
26 of 27 checks passed
@pelikhan
pelikhan deleted the copilot/update-pull-request-branch-access branch November 7, 2026 15:12
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt56 max · ~5 AIC · ⌖ ~1 AIC · ⊞ 118 · ◷

Generated by Ponytail Reviewer for #75697

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: gpt56 max · ~1 AIC · ⌖ ~2 AIC · ⊞ 6.3K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: opus55 xhigh · ~13 AIC · ⌖ ~2 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~1 AIC · ⌖ ~1 AIC · ⊞ 1.6K · ◷

Generated by PR Specification Reviewer for #75697

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing regression tests reject the new edit/push configuration, breaking required test targets, while unresolved publication safeguards risk unintended PR creation and overwriting concurrent changes.

7 open issues
What changed in this PR

Enables gh-aw’s PR Specification Reviewer to publish eligible specification updates to same-repository PR branches, while keeping fork PRs on the comment-only proposal path.

Changes:

  • Adds editing and one branch-push request scoped to specification Markdown.
  • Updates synchronization instructions, publication safeguards, and evaluation questions.
  • Regenerates the compiled workflow and /review-specs help description.

Validation was limited to static inspection; compilation and tests were not run.

File Description
.github/​workflows/​pr-specification-reviewer.md Adds scoped publication settings and updates reviewer instructions and evaluations.
.github/​workflows/​pr-specification-reviewer.lock.yml Generates push handling, write permissions, patch checkout, and updated prompts.
.github/​workflows/​agentic_commands.yml Updates the /review-specs help description.

Review effort: Max (auto)

max-diff-lines: "2000"
tools:
cli-proxy: true
edit:
- tail
- wc
safe-outputs:
max-patch-files: 5
Comment on lines +69 to +71
push-to-pull-request-branch:
target: triggering
max: 1
- 'specs/*.md'
- 'docs/src/content/docs/specs/*.md'
- 'docs/src/content/docs/experimental/experiments-specification.md'
protected-files: allowed
- 'docs/src/content/docs/specs/*.md'
- 'docs/src/content/docs/experimental/experiments-specification.md'
protected-files: allowed
fallback-as-pull-request: false
Comment on lines +230 to +232
or scratchpads. Verify the local diff contains only the approved specification
updates, then commit exactly those files on top of the captured PR head without
rebasing, merging, or rewriting existing commits.
Comment on lines +247 to +248
If eligible specification edits were committed for a same-repository PR, call
`safeoutputs push_to_pull_request_branch` once. A recorded output ID acknowledges
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants