Repository navigation
Enable scoped specification updates on PR branches - #75697
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
There was a problem hiding this comment.
🟡 Changes recommended
Existing regression tests reject the new edit/push configuration, breaking required test targets, while unresolved publication safeguards risk unintended PR creation and overwriting concurrent changes.
7 open issues
Update regression tests for scoped same-repository pushes · New Enforce the five-file cap across the full push changeset · New Prevent push-triggered runs from canceling publication · New Block writes to protected specification files · New Stop publication on threat-detection failures · New Validate and stage only explicit specification paths · New Reject publication when the PR head differs from the reviewed SHA · New
What changed in this PR
Enables gh-aw’s PR Specification Reviewer to publish eligible specification updates to same-repository PR branches, while keeping fork PRs on the comment-only proposal path.
Changes:
- Adds editing and one branch-push request scoped to specification Markdown.
- Updates synchronization instructions, publication safeguards, and evaluation questions.
- Regenerates the compiled workflow and
/review-specshelp description.
Validation was limited to static inspection; compilation and tests were not run.
| File | Description |
|---|---|
.github/workflows/pr-specification-reviewer.md |
Adds scoped publication settings and updates reviewer instructions and evaluations. |
.github/workflows/pr-specification-reviewer.lock.yml |
Generates push handling, write permissions, patch checkout, and updated prompts. |
.github/workflows/agentic_commands.yml |
Updates the /review-specs help description. |
Review effort: Max (auto)
| max-diff-lines: "2000" | ||
| tools: | ||
| cli-proxy: true | ||
| edit: |
| - tail | ||
| - wc | ||
| safe-outputs: | ||
| max-patch-files: 5 |
| push-to-pull-request-branch: | ||
| target: triggering | ||
| max: 1 |
| - 'specs/*.md' | ||
| - 'docs/src/content/docs/specs/*.md' | ||
| - 'docs/src/content/docs/experimental/experiments-specification.md' | ||
| protected-files: allowed |
| - 'docs/src/content/docs/specs/*.md' | ||
| - 'docs/src/content/docs/experimental/experiments-specification.md' | ||
| protected-files: allowed | ||
| fallback-as-pull-request: false |
| or scratchpads. Verify the local diff contains only the approved specification | ||
| updates, then commit exactly those files on top of the captured PR head without | ||
| rebasing, merging, or rewriting existing commits. |
| If eligible specification edits were committed for a same-repository PR, call | ||
| `safeoutputs push_to_pull_request_branch` once. A recorded output ID acknowledges |
|
🎉 This pull request is included in a new release. Release: |


PR Specification Reviewer currently posts specification replacements as review proposals. This change enables it to commit eligible updates to the triggering PR branch, including protected Markdown files.
push-to-pull-request-branch, limited to one push and five files within the existing specification Markdown allowlist. Disable fallback PR creation.