Skip to content

[file-diet] Split run artifact processor into focused files - #75620

Merged
pelikhan merged 2 commits into
mainfrom
copilot/file-diet-refactor-logs-run-processor
Nov 7, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/file-diet-refactor-logs-run-processor

Conversation

Copilot AI commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

pkg/cli/logs_run_processor.go had grown to 1,221 lines, combining orchestration, downloads, cache handling, analysis, summaries, and artifact probing.

  • Implementation: Split the processor into six focused files for concurrent downloads, single-run downloads, cache, analysis, summaries, and artifact probes; preserve existing behavior.
  • Tests: Organize tests by responsibility and add malformed safe-output JSON coverage. Retain existing coverage for cache behavior, cancellation, and result ordering.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor logs_run_processor.go into focused files [file-diet] Split run artifact processor into focused files Nov 7, 2026
Copilot AI requested a review from gh-aw-bot November 7, 2026 06:20
@pelikhan
pelikhan marked this pull request as ready for review November 7, 2026 13:54
Copilot AI dynamic review requested due to automatic review settings November 7, 2026 13:54
@pelikhan
pelikhan merged commit b5d8d79 into main Nov 7, 2026
59 checks passed
@pelikhan
pelikhan deleted the copilot/file-diet-refactor-logs-run-processor branch November 7, 2026 13:55
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~1 AIC · ⌖ ~1 AIC · ⊞ 1.6K · ◷

Generated by PR Specification Reviewer for #75620

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: gpt56 max · ~1 AIC · ⌖ ~2 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: gpt56 max · ~1 AIC · ⌖ ~2 AIC · ⊞ 6.3K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt56 max · ~6 AIC · ⌖ ~1 AIC · ⊞ 118 · ◷

Generated by Ponytail Reviewer for #75620

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified, with responsibilities separated into focused files and coverage retained for key behaviors and malformed input handling.

No open issues 🎉

What changed in this PR

This pull request refactors the 1,221-line run artifact processor into focused files while preserving existing download, caching, analysis, summary, and artifact-probing behavior.

Changes:

  • Split processing responsibilities into dedicated files for downloads, caching, analysis, summaries, and artifact probing.
  • Reorganized related tests alongside their implementation files.
  • Added malformed safe-output JSON coverage while retaining cache, cancellation, ordering, and backfill coverage.
File Description
pkg/​cli/​logs_run_summary.go Builds and persists run summaries and performs cache backfills.
pkg/​cli/​logs_run_summary_test.go Tests token-usage backfill and gateway steering-event propagation.
pkg/​cli/​logs_run_processor.go Removes the former monolithic processor implementation.
pkg/​cli/​logs_run_download_single.go Contains single-run download processing, workflow validation, rate limiting, and evals fallback handling.
pkg/​cli/​logs_run_download_single_test.go Tests single-run workflow-path and download-error behavior.
pkg/​cli/​logs_run_download_concurrent.go Contains concurrent download orchestration, worker coordination, result ordering, and repository resolution.
pkg/​cli/​logs_run_download_concurrent_test.go Tests concurrent-download parameter construction.
pkg/​cli/​logs_run_cache.go Contains cached-run loading, metadata refresh, and cache workflow-path validation.
pkg/​cli/​logs_run_cache_test.go Retains cache-hit, cache-bypass, metadata-refresh, and backfill coverage.
pkg/​cli/​logs_run_artifact_probe.go Contains safe-output, DIFC, evals, and workflow-path artifact probes.
pkg/​cli/​logs_run_artifact_probe_test.go Tests evals discovery and malformed safe-output JSON handling.
pkg/​cli/​logs_run_analysis.go Contains artifact metrics, security, behavioral, and usage analysis.

Review effort: Lite (auto)

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[file-diet] Refactor pkg/cli/logs_run_processor.go (1221 lines) into focused files

4 participants