Repository navigation
[file-diet] Split run artifact processor into focused files - #75620
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, with responsibilities separated into focused files and coverage retained for key behaviors and malformed input handling.
No open issues 🎉
What changed in this PR
This pull request refactors the 1,221-line run artifact processor into focused files while preserving existing download, caching, analysis, summary, and artifact-probing behavior.
Changes:
- Split processing responsibilities into dedicated files for downloads, caching, analysis, summaries, and artifact probing.
- Reorganized related tests alongside their implementation files.
- Added malformed safe-output JSON coverage while retaining cache, cancellation, ordering, and backfill coverage.
| File | Description |
|---|---|
pkg/cli/logs_run_summary.go |
Builds and persists run summaries and performs cache backfills. |
pkg/cli/logs_run_summary_test.go |
Tests token-usage backfill and gateway steering-event propagation. |
pkg/cli/logs_run_processor.go |
Removes the former monolithic processor implementation. |
pkg/cli/logs_run_download_single.go |
Contains single-run download processing, workflow validation, rate limiting, and evals fallback handling. |
pkg/cli/logs_run_download_single_test.go |
Tests single-run workflow-path and download-error behavior. |
pkg/cli/logs_run_download_concurrent.go |
Contains concurrent download orchestration, worker coordination, result ordering, and repository resolution. |
pkg/cli/logs_run_download_concurrent_test.go |
Tests concurrent-download parameter construction. |
pkg/cli/logs_run_cache.go |
Contains cached-run loading, metadata refresh, and cache workflow-path validation. |
pkg/cli/logs_run_cache_test.go |
Retains cache-hit, cache-bypass, metadata-refresh, and backfill coverage. |
pkg/cli/logs_run_artifact_probe.go |
Contains safe-output, DIFC, evals, and workflow-path artifact probes. |
pkg/cli/logs_run_artifact_probe_test.go |
Tests evals discovery and malformed safe-output JSON handling. |
pkg/cli/logs_run_analysis.go |
Contains artifact metrics, security, behavioral, and usage analysis. |
Review effort: Lite (auto)
|
🎉 This pull request is included in a new release. Release: |
pkg/cli/logs_run_processor.gohad grown to 1,221 lines, combining orchestration, downloads, cache handling, analysis, summaries, and artifact probing.