Repository navigation
Mark four GitHub safe outputs as stable - #73916
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
Review: comment
Found two documentation inconsistencies: the authoring guidance still labels dispatch-repository and merge-pull-request experimental and says compilation emits warnings, despite this PR removing those warnings. Inline comments identify both stale sections.
Details
No runtime correctness issues were identified in the changed implementation. The review was static; tests were not run.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~4 AIC · ⌖ ~1 AIC · ⊞ 1.7K
Comment /review to run again
There was a problem hiding this comment.
🟡 Changes recommended
The change removes warnings for still-experimental merge-pull-request and leaves dispatch-repository guidance describing a warning that no longer exists.
2 open issues
What changed in this PR
This PR aims to promote four GitHub safe outputs to stable status in gh-aw by updating compiler notices, tests, and documentation without changing runtime handlers or policy safeguards.
Changes:
- Removes experimental warning entries and updates warning assertions, including normal and batch-mode coverage.
- Updates reference documentation, authoring guidance, schema descriptions, and agent-facing tool text.
- Adds a minor-release changeset.
| File | Description |
|---|---|
pkg/workflow/replace_label_experimental_warning_test.go |
Expects no experimental warning for label replacement. |
pkg/workflow/publish_code_coverage_test.go |
Expects no experimental warning for coverage uploads. |
pkg/workflow/merge_pull_request_experimental_warning_test.go |
Changes merge tests to expect no experimental warning. |
pkg/workflow/js/safe_outputs_tools.json |
Removes coverage tool’s experimental label. |
pkg/workflow/dispatch_repository_experimental_warning_test.go |
Expects warning-free repository dispatch. |
pkg/workflow/compiler_validators.go |
Removes five safe-output warning entries. |
pkg/workflow/compiler_experimental_warning_test.go |
Adds normal and batch-mode warning-free assertions. |
pkg/workflow/approve_workflow_run_experimental_warning_test.go |
Expects warning-free workflow approval. |
pkg/parser/schemas/main_workflow_schema.json |
Updates coverage-upload schema descriptions. |
docs/src/content/docs/specs/safe-outputs-specification.md |
Removes approval and merge warning statements. |
docs/src/content/docs/reference/safe-outputs.md |
Updates safe-output status labels and dispatch guidance. |
docs/src/content/docs/reference/safe-outputs-pull-requests.md |
Removes approval and merge experimental notices and merge graduation criteria. |
docs/src/content/docs/reference/glossary.md |
Updates dispatch, approval, and merge descriptions. |
docs/src/content/docs/reference/frontmatter-full.md |
Updates generated coverage-upload descriptions. |
actions/setup/js/safe_outputs_tools.json |
Synchronizes coverage tool description. |
.github/aw/test-coverage.md |
Removes experimental coverage-upload guidance. |
.github/aw/safe-outputs-management.md |
Removes merge’s experimental heading qualifier. |
.github/aw/safe-outputs-automation.md |
Removes repository dispatch’s experimental heading qualifier. |
.changeset/minor-stable-github-safe-outputs.md |
Adds the stability-promotion release note. |
Review effort: Balanced (auto)
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /improve-codebase-architecture and /grill-with-docs, with /tdd on the test changes. Requesting changes because two agent reference docs still describe stable tools as experimental.
📋 Key Themes & Highlights
Blocking
-
Stale experimental notes (outside the diff, so no inline anchor):
.github/aw/safe-outputs-management.mdline 52 (merge-pull-request): "⚠️ Experimental: Compilation emits a warning when this feature is used." The PR updated line 38 but not this note..github/aw/safe-outputs-automation.mdline 103 (dispatch-repository): the same stale note. The PR updated line 78 but not this note.- These files are read by agents when they generate workflows, so the stale text will keep steering them. Remove the experimental label and warning sentence in both places.
Test quality
- The new
TestStableSafeOutputsNoExperimentalWarningand the converted tests only assert absence. Add a positive control (for exampleSteer: true) so a broken emitter can not pass silently. See the inline comment oncompiler_experimental_warning_test.go. - Rename
expectedMessagetounexpectedMessageinpublish_code_coverage_test.go. See the inline comment.
Nits (non-blocking)
- Test filenames still say
*_experimental_warning_test.goeven though they now assert no warning. Consider renaming to*_stable_no_warning_test.goor similar. - Mixed capitalization in
dispatch_repository_experimental_warning_test.goerror strings ("Expected..." vs "Did not expect..."). Keep it consistent.
Positive highlights
- ✅ The compiler validator change is a clean five-entry removal in
emitExperimentalFeatureWarningsTo. - ✅ Glossary, safe-outputs-pull-requests, frontmatter-full, and both
safe_outputs_tools.jsoncopies were updated consistently. Both JSON files and the schema parse. - ✅ The new changeset matches sibling format.
- ✅ Focused Go tests pass and gofmt is clean on all touched Go files.
@copilot please address the stale docs and test comments above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~12 AIC · ⌖ ~1 AIC · ⊞ 5.4K
Comment /matt to run again
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Expect zero warnings in the wildcard app-token regression test now that dispatch-repository is stable. Preserve token-scope assertions and keep merge-pull-request experimental. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Regarding the Design Decision Gate notice: it reports no actionable design finding, so no additional ADR or workflow change is needed for this notice. The |
|
Regarding the Test Quality Sentinel notice: no change is needed for the completion notice itself. The actionable test feedback is addressed separately with a positive emitter control and clearer variable naming. |
|
Regarding the Ponytail Reviewer notice: this reports completion without requesting a code change. No repository change is needed for the notice itself. |
|
Regarding the skills-review notice: the actionable dispatch guidance and test feedback is addressed in the review threads, while merge guidance stays experimental as requested. Optional filename and capitalization nits are deferred to keep this correction scoped. |
|
Regarding the code-quality review notice: the stale dispatch warning guidance is corrected, and the merge-status feedback is obsolete because merge remains experimental. The corresponding inline threads have individual responses. |
|
Regarding the comment-memory summary: its underlying dispatch guidance finding is fixed, while the merge guidance correctly remains experimental. No change is made to reviewer-managed memory or workflow metadata. |
|
🎉 This pull request is included in a new release. Release: |

Summary
Promote
dispatch-repository,approve-workflow-run,replace-label, andupload-code-coverageto non-experimental status. Remove their compiler warnings and experimental labels from reference documentation, authoring guidance, the workflow schema, and agent-facing tool descriptions.Keep
merge-pull-requestexperimental, including its compiler warning and documented graduation criteria, following the responsible-AI assessment. Runtime behavior, authentication requirements, and policy safeguards are unchanged. Add regression coverage for warning-free stable outputs and experimental merge notices in normal and batch modes, and a minor changeset.Validation