Skip to content

Mark four GitHub safe outputs as stable - #73916

Merged
pelikhan merged 4 commits into
mainfrom
pelikhan/stable-safe-outputs
Nov 2, 2026
Merged

pelikhan merged 4 commits into
mainfrom
pelikhan/stable-safe-outputs

Conversation

@pelikhan

@pelikhan pelikhan commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Promote dispatch-repository, approve-workflow-run, replace-label, and upload-code-coverage to non-experimental status. Remove their compiler warnings and experimental labels from reference documentation, authoring guidance, the workflow schema, and agent-facing tool descriptions.

Keep merge-pull-request experimental, including its compiler warning and documented graduation criteria, following the responsible-AI assessment. Runtime behavior, authentication requirements, and policy safeguards are unchanged. Add regression coverage for warning-free stable outputs and experimental merge notices in normal and batch modes, and a minor changeset.

Validation

  • The original stability changes passed build, formatting, focused unit tests, compilation integration tests, and change-scoped validation.
  • The schema documentation generator test has two unrelated model-routing assertion failures. Full regeneration exposed unrelated existing documentation drift, so only the relevant coverage descriptions were updated.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review November 2, 2026 00:59
Copilot AI dynamic review requested due to automatic review settings November 2, 2026 00:59
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: gpt56 max · ~1 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · haiku45 · ~6 AIC · ⌖ ~11 AIC · ◇ ~3 AIC · ⊞ 9.2K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~10 AIC · ⌖ ~6 AIC · ⊞ 15.1K · ◷

Generated by Ponytail Reviewer for #73916

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@pelikhan pelikhan changed the title Mark five GitHub safe outputs as stable Mark four GitHub safe outputs as stable Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Comment Memory

Peek at saved memory (pr-code-quality-reviewer)
reviewed_at: 2026-11-02T01:03:56Z
review_event: COMMENT
top_themes:
  - stale experimental labels in authoring guidance
files_reviewed:
  - .github/aw/safe-outputs-automation.md
  - .github/aw/safe-outputs-management.md
  - docs/src/content/docs/reference/safe-outputs-pull-requests.md
  - docs/src/content/docs/reference/safe-outputs.md
  - pkg/workflow/compiler_validators.go
  - pkg/workflow/compiler_experimental_warning_test.go
  - pkg/parser/schemas/main_workflow_schema.json
comment_count: 2

Note

This comment is managed by comment memory.

Expand the saved memory block to view or edit the persistent context for this thread.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~4 AIC · ⌖ ~1 AIC · ⊞ 1.7K · ◷
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: comment

Found two documentation inconsistencies: the authoring guidance still labels dispatch-repository and merge-pull-request experimental and says compilation emits warnings, despite this PR removing those warnings. Inline comments identify both stale sections.

Details

No runtime correctness issues were identified in the changed implementation. The review was static; tests were not run.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~4 AIC · ⌖ ~1 AIC · ⊞ 1.7K
Comment /review to run again

Comment thread .github/aw/safe-outputs-automation.md Resolved
Comment thread .github/aw/safe-outputs-management.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change removes warnings for still-experimental merge-pull-request and leaves dispatch-repository guidance describing a warning that no longer exists.

2 open issues
What changed in this PR

This PR aims to promote four GitHub safe outputs to stable status in gh-aw by updating compiler notices, tests, and documentation without changing runtime handlers or policy safeguards.

Changes:

  • Removes experimental warning entries and updates warning assertions, including normal and batch-mode coverage.
  • Updates reference documentation, authoring guidance, schema descriptions, and agent-facing tool text.
  • Adds a minor-release changeset.
File Description
pkg/​workflow/​replace_label_experimental_warning_test.go Expects no experimental warning for label replacement.
pkg/​workflow/​publish_code_coverage_test.go Expects no experimental warning for coverage uploads.
pkg/​workflow/​merge_pull_request_experimental_warning_test.go Changes merge tests to expect no experimental warning.
pkg/​workflow/​js/​safe_outputs_tools.json Removes coverage tool’s experimental label.
pkg/​workflow/​dispatch_repository_experimental_warning_test.go Expects warning-free repository dispatch.
pkg/​workflow/​compiler_validators.go Removes five safe-output warning entries.
pkg/​workflow/​compiler_experimental_warning_test.go Adds normal and batch-mode warning-free assertions.
pkg/​workflow/​approve_workflow_run_experimental_warning_test.go Expects warning-free workflow approval.
pkg/​parser/​schemas/​main_workflow_schema.json Updates coverage-upload schema descriptions.
docs/​src/​content/​docs/​specs/​safe-outputs-specification.md Removes approval and merge warning statements.
docs/​src/​content/​docs/​reference/​safe-outputs.md Updates safe-output status labels and dispatch guidance.
docs/​src/​content/​docs/​reference/​safe-outputs-pull-requests.md Removes approval and merge experimental notices and merge graduation criteria.
docs/​src/​content/​docs/​reference/​glossary.md Updates dispatch, approval, and merge descriptions.
docs/​src/​content/​docs/​reference/​frontmatter-full.md Updates generated coverage-upload descriptions.
actions/​setup/​js/​safe_outputs_tools.json Synchronizes coverage tool description.
.github/​aw/​test-coverage.md Removes experimental coverage-upload guidance.
.github/​aw/​safe-outputs-management.md Removes merge’s experimental heading qualifier.
.github/​aw/​safe-outputs-automation.md Removes repository dispatch’s experimental heading qualifier.
.changeset/​minor-stable-github-safe-outputs.md Adds the stability-promotion release note.

Review effort: Balanced (auto)

Comment thread .github/aw/safe-outputs-automation.md Resolved
Comment thread pkg/workflow/compiler_validators.go Resolved

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /improve-codebase-architecture and /grill-with-docs, with /tdd on the test changes. Requesting changes because two agent reference docs still describe stable tools as experimental.

📋 Key Themes & Highlights

Blocking

  • Stale experimental notes (outside the diff, so no inline anchor):

    • .github/aw/safe-outputs-management.md line 52 (merge-pull-request): "⚠️ Experimental: Compilation emits a warning when this feature is used." The PR updated line 38 but not this note.
    • .github/aw/safe-outputs-automation.md line 103 (dispatch-repository): the same stale note. The PR updated line 78 but not this note.
    • These files are read by agents when they generate workflows, so the stale text will keep steering them. Remove the experimental label and warning sentence in both places.

Test quality

  • The new TestStableSafeOutputsNoExperimentalWarning and the converted tests only assert absence. Add a positive control (for example Steer: true) so a broken emitter can not pass silently. See the inline comment on compiler_experimental_warning_test.go.
  • Rename expectedMessage to unexpectedMessage in publish_code_coverage_test.go. See the inline comment.

Nits (non-blocking)

  • Test filenames still say *_experimental_warning_test.go even though they now assert no warning. Consider renaming to *_stable_no_warning_test.go or similar.
  • Mixed capitalization in dispatch_repository_experimental_warning_test.go error strings ("Expected..." vs "Did not expect..."). Keep it consistent.

Positive highlights

  • ✅ The compiler validator change is a clean five-entry removal in emitExperimentalFeatureWarningsTo.
  • ✅ Glossary, safe-outputs-pull-requests, frontmatter-full, and both safe_outputs_tools.json copies were updated consistently. Both JSON files and the schema parse.
  • ✅ The new changeset matches sibling format.
  • ✅ Focused Go tests pass and gofmt is clean on all touched Go files.

@copilot please address the stale docs and test comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~12 AIC · ⌖ ~1 AIC · ⊞ 5.4K
Comment /matt to run again

pelikhan and others added 2 commits November 1, 2026 17:12
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Expect zero warnings in the wildcard app-token regression test now that dispatch-repository is stable. Preserve token-scope assertions and keep merge-pull-request experimental.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan

pelikhan commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Regarding the Design Decision Gate notice: it reports no actionable design finding, so no additional ADR or workflow change is needed for this notice. The reported_no_action status is not being treated as proof of completed validation.

@pelikhan

pelikhan commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Regarding the Test Quality Sentinel notice: no change is needed for the completion notice itself. The actionable test feedback is addressed separately with a positive emitter control and clearer variable naming.

@pelikhan

pelikhan commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Regarding the Ponytail Reviewer notice: this reports completion without requesting a code change. No repository change is needed for the notice itself.

@pelikhan

pelikhan commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Regarding the skills-review notice: the actionable dispatch guidance and test feedback is addressed in the review threads, while merge guidance stays experimental as requested. Optional filename and capitalization nits are deferred to keep this correction scoped.

@pelikhan

pelikhan commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Regarding the code-quality review notice: the stale dispatch warning guidance is corrected, and the merge-status feedback is obsolete because merge remains experimental. The corresponding inline threads have individual responses.

@pelikhan

pelikhan commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Regarding the comment-memory summary: its underlying dispatch guidance finding is fixed, while the merge guidance correctly remains experimental. No change is made to reviewer-managed memory or workflow metadata.

@pelikhan
pelikhan merged commit d3bef2d into main Nov 2, 2026
102 of 103 checks passed
@pelikhan
pelikhan deleted the pelikhan/stable-safe-outputs branch November 2, 2026 01:39
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants