Skip to content

Share TLA+/TLC tooling across agentic workflows - #73816

Merged
pelikhan merged 1 commit into
mainfrom
copilot/add-shared-agentic-workflow
Nov 1, 2026
Merged

pelikhan merged 1 commit into
mainfrom
copilot/add-shared-agentic-workflow

Conversation

Copilot AI commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Centralize TLA+/TLC agent setup and add reusable formal-methods instructions.

  • Shared runtime

    • Add shared/tla-plus.md with checksum-pinned Temurin JRE 21 and TLC 1.8.0.
    • Expose sandbox-accessible JAVA_BIN and TLA2TOOLS_JAR.
    • Replace the security-model workflow’s inline installation; retain its model-specific verifier build.
  • Agent guidance

    • Add .github/aw/formal-methods.md, included automatically by the shared import.
    • Cover bounded checks, reproducible evidence, counterexample preservation, and incomplete-search reporting.
  • Compatibility

    • Align the security checker’s checksum, documentation, and regression assertion with the shared runtime.
    • Preserve custom work-queue jobs’ independent TLC 1.7.4 setup; agent imports do not configure custom jobs.

Agent workflows opt in with:

imports:
  - shared/tla-plus.md

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Share TLA+ / TLC agent tooling and formal-methods guidance Share TLA+/TLC tooling across agentic workflows Nov 1, 2026
Copilot AI requested a review from pelikhan November 1, 2026 15:48
@pelikhan
pelikhan marked this pull request as ready for review November 1, 2026 15:55
Copilot AI dynamic review requested due to automatic review settings November 1, 2026 15:55
@pelikhan
pelikhan merged commit f9c9f37 into main Nov 1, 2026
16 of 17 checks passed
@pelikhan
pelikhan deleted the copilot/add-shared-agentic-workflow branch November 1, 2026 15:55
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: gpt56 max · ~1 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · ~16 AIC · ⌖ ~19 AIC · ◇ ~8 AIC · ⊞ 12.7K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~9 AIC · ⌖ ~6 AIC · ⊞ 15.1K · ◷

Generated by Ponytail Reviewer for #73816

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pinned JAR digest is attributed to outdated release-asset and build/source metadata, leaving the upload-log verification claim unsupported.

1 open issue
What changed in this PR

Centralizes TLA+/TLC setup for gh-aw agent workflows and adds reusable guidance for reproducible formal-verification evidence.

Changes:

  • Adds a shared, checksum-pinned Java/TLC runtime with sandbox-accessible paths.
  • Migrates the security-model workflow to the shared setup while retaining its verifier build.
  • Aligns the checker’s checksum and regression assertion, and documents bounded checks and evidence reporting without changing custom jobs’ independent tooling.
File Description
specs/​workflow-security/​README.md Updates the documented TLC checksum.
specs/​workflow-security/​check.py Updates the enforced JAR checksum.
specs/​workflow-security/​check_test.py Checks the shared import and runtime pin.
.github/​workflows/​shared/​tla-plus.md Adds reusable runtime installation and guidance import.
.github/​workflows/​daily-workflow-security-model.md Replaces inline installation with the shared import.
.github/​workflows/​daily-workflow-security-model.lock.yml Regenerates setup steps, prompt imports, and metadata.
.github/​aw/​formal-methods.md Adds bounded-check and evidence-preservation guidance.

Review effort: Balanced (auto)


```text
d15655eeaff4b3f7b3d65c46b838bc0f35d131b2ef4b1e473689b62c98d4726f
011267fca25d0752cf18894dd585cd28b96960c112ea8a20b823ea770e7e10cd
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants