Skip to content

fix: fill model pricing gaps and restore 1ES-compatible Vite - #72414

Merged
pelikhan merged 1 commit into
mainfrom
pelikhan/issue-72194-model-inventory-model-alias-inventory-u-26cd1f
Oct 27, 2026
Merged

pelikhan merged 1 commit into
mainfrom
pelikhan/issue-72194-model-inventory-model-alias-inventory-u-26cd1f

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Summary

The model inventory reported missing pricing for gpt-5.6-luna-utility and gpt-6.1-terra. Add explicit entries so pricing does not depend on prefix fallback, keeping the Go and JavaScript catalogues synchronized.

  • Use official default-tier Terra rates for OpenAI and Copilot, with Responses API routing metadata.
  • Use Luna rates for Copilot's utility variant, as explicitly requested. This is an assumption, not independently published utility pricing.
  • Preserve existing aliases, workflow pins, and historical entries. Long-context pricing support is unchanged.
  • Downgrade Vite from 8.3.5 to 8.3.4 and override its Rolldown dependency to 1.2.14: the newer locked versions are unavailable through the approved 1ES feed. Regenerate the lockfile without changing Vitest.

Validation

  • Clean installation through 1ES succeeds; all 18 changed dependency tarballs, including platform bindings, were verified against the feed.
  • Go pricing regressions, JavaScript model-cost tests (24 tests), and TypeScript checks pass.
  • Formatting, linting, catalogue mirror checks, and repository validation pass. The final gate's initial Go lint attempt hit shared-runner contention; serialized Go lint and the subsequent no-test gate passed without rerunning unit tests.

Fixes: #72194

Add explicit Copilot pricing for gpt-5.6-luna-utility using Luna rates as directed, and published gpt-6.1-terra default pricing for OpenAI and Copilot. Preserve existing alias coverage and routing metadata.

Pin Vite to 8.3.4 and its Rolldown dependency to 1.2.14 so clean installs succeed through the approved 1ES feed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 27, 2026 11:25
Copilot AI max review requested due to automatic review settings October 27, 2026 11:25
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~11 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #72414

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~12 AIC · ⌖ ~38 AIC · ◇ ~3 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · haiku45 · ~6 AIC · ⌖ ~11 AIC · ◇ ~3 AIC · ⊞ 8.9K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@pelikhan
pelikhan merged commit fb11638 into main Oct 27, 2026
120 checks passed
@pelikhan
pelikhan deleted the pelikhan/issue-72194-model-inventory-model-alias-inventory-u-26cd1f branch October 27, 2026 11:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Dependency portability and integrity regressions remain unresolved, and the downgrade conflicts with the repository’s npm guidance.

3 open issues
1 file not reviewed
  • actions/setup/js/package-lock.json: Generated file
What changed in this PR

Adds explicit model pricing to gh-aw’s mirrored catalogues and adjusts the JavaScript test toolchain for 1ES feed availability.

Changes:

  • Add Terra pricing for OpenAI and Copilot, plus assumed Luna pricing for Copilot’s utility variant.
  • Extend Go and JavaScript regression tests for pricing, routing metadata, and provider aliases.
  • Downgrade Vite to 8.3.4, pin Rolldown to 1.2.14, and regenerate the lockfile without changing Vitest.
File Description
pkg/​cli/​model_costs_test.go Adds pricing expectations for the new model entries.
pkg/​cli/​data/​models.json Adds explicit model pricing and Responses API routing metadata.
actions/​setup/​js/​package.json Downgrades Vite and adds the Rolldown override.
actions/​setup/​js/​package-lock.json Updates dependency versions, tarball URLs, and integrity metadata.
actions/​setup/​js/​models.json Mirrors the catalogue additions for JavaScript consumers.
actions/​setup/​js/​model_costs.test.cjs Checks bundled pricing, routing, aliases, and cost calculations.

Review effort: Max

"resolved": "https://registry.npmjs.org/@oxc-project/types/-/types-0.155.0.tgz",
"integrity": "sha512-SeE8JPwW1xs1tHeNycjUtUBdhorRa8o4jlvjwk49R7/Z291i+4DQa7JJIgOm/TaYQZx+QrPQbVJ/9c8dMIZN8Q==",
"version": "0.154.0",
"resolved": "https://ms-feed-25.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/@oxc-project/types/-/types-0.154.0.tgz",
"resolved": "https://registry.npmjs.org/@rolldown/pluginutils/-/pluginutils-1.0.1.tgz",
"integrity": "sha512-2j9bGt5Jh8hj+vPtgzPtl72j0yRxHAyumoo6TNfAjsLB04UtpSvPbPcDcBMxz7n+9CYB0c1GxQFxYRg2jimqGw==",
"resolved": "https://ms-feed-25.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/@rolldown/pluginutils/-/pluginutils-1.0.1.tgz",
"integrity": "sha1-4/zuCT+7XOdl4a0Ij/TeKIn2+b4=",
"ts-json-schema-generator": "2.9.0",
"typescript": "^7.0.2",
"vite": "8.3.5",
"vite": "8.3.4",
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[model-inventory] Model alias inventory update - 2026-10-26

2 participants