Repository navigation
[log] Add debug logging to unlogged branches in cli package-manifest/actionlint code - #72299
Merged
pelikhan merged 1 commit intoOct 27, 2026
Conversation
…ctionlint code These files already had a logger declared but several branchy functions (wildcard expansion, path traversal rejection, icon validation, timeout/ cancel handling, result reporting) had zero log calls, leaving silent gaps in otherwise well-instrumented code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
pelikhan
deleted the
log/cli-package-manifest-actionlint-gaps-f7d4cf35f98946c1
branch
October 27, 2026 09:06
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deterministic candidate manifest this run started from (files_needing_logger, first 38 entries) turned out to be stale: the pkg/actionpins and pkg/agentdrain packages it listed first are already extensively instrumented with loggers at nearly every candidate line, and several other candidates (pkg/actionpins/types.go, pkg/agentdrain/config.go, pkg/agentdrain/types.go, pkg/cli/add_package_manifest.go) are pure type/constant definitions with no branching logic worth logging. Adding more calls there would have been duplicate or trivial logging.
Instead I looked for files that already declare a logger but still have many unlogged functions, i.e. real coverage gaps. Five pkg/cli files stood out:
All 17 new log statements use the existing per-file logger variable, follow the pkg:filename namespace convention already established, and avoid side-effecting arguments.
Validation
Note on the candidate manifest
The pre-flight manifest.json used to seed this run appears generated from a stale snapshot relative to pkg/actionpins and pkg/agentdrain, which are already fully logged in the current tree. Regenerating that backlog would avoid future runs re-surfacing already-saturated files.