Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
383 changes: 156 additions & 227 deletions .github/aw/debug-security-review.md

Large diffs are not rendered by default.

59 changes: 59 additions & 0 deletions .github/skills/agentic-workflows/tests/test_guidance.py
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,65 @@ def test_single_security_reviewer_and_markdown_overview(self):
"debug-security-review.md#annotated-markdown-change-overview", text
)

def test_security_review_plans_for_same_reviewer_followups(self):
gate = (ROOT / ".github/aw/debug-security-review.md").read_text()
reviewer = gate.split("## Single Reviewer\n", 1)[1].split(
"\n## Binary Questions", 1
)[0]
self.assertIn("follow-up support **before launching**", reviewer)
self.assertIn("synchronous or one-shot", reviewer)
self.assertIn("does not guarantee follow-up support", reviewer)
self.assertIn("compiler output before requesting review", reviewer)
self.assertIn("Changed code still needs review before execution", reviewer)
self.assertIn("without repeating unchanged coverage", reviewer)
self.assertIn("cannot receive a required follow-up", reviewer)
self.assertIn("do not apply it to later changes", reviewer)
self.assertIn("no unreviewed execution or upload", reviewer)

def test_security_review_explains_tooling_gaps_without_claiming_defects(self):
gate = (ROOT / ".github/aw/debug-security-review.md").read_text()
reporting = gate.split("### Explain Blocked or Unavailable Debugging\n", 1)[1]
self.assertIn("name the failed capability and the unreviewed delta", reporting)
self.assertIn("does not accept follow-up messages", reporting)
self.assertIn("No code defect was found; upload remains blocked", reporting)
self.assertIn("identify that mistake rather than implying the code is", reporting)

def test_security_review_consumption_budget_and_safety_contract(self):
gate = (ROOT / ".github/aw/debug-security-review.md").read_text()
self.assertLessEqual(len(gate.split()), 1800)
self.assertLessEqual(len(gate.encode()), 14500)
for heading in (
"Dry-Run Dangerous Features", "Agent Ownership", "Session Authorization",
"Runtime Readiness Is Not a Review Gate", "Compile-Only Validation",
"Capture Session Intent First", "Evidence", "Single Reviewer",
"Binary Questions", "Decision", "User-Visible Result",
):
with self.subTest(heading=heading):
self.assertIn(f"## {heading}\n", gate)
questions = gate.split("## Binary Questions\n", 1)[1].split(
"\n## Decision", 1
)[0]
self.assertEqual(
re.findall(r"^\| ([a-z_]+) \|", questions, re.MULTILINE),
[
"intent_alignment", "effect_scope", "secret_destinations",
"secret_disclosure", "payload_execution", "persistence",
"destructive_effects", "untrusted_execution", "access_controls",
"security_controls",
],
)
for required in (
"Any compiler security warning revokes the grant immediately",
"A clean compile alone cannot restore approval",
"never combine `--dry-run` with `--no-emit`",
"Never reset the worktree or overwrite concurrent edits",
"a diagnostic-lock verdict cannot cover a different live lock",
"PASS grants no dispatch",
"Additional user authorization\n cannot replace review",
):
with self.subTest(safety_contract=required):
self.assertIn(required, gate)

def test_customer_case_remedy_order(self):
case = FIXTURES["model_mismatch"]
self.assertIn("v0.89.21", case["lock_header"])
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/pr-sous-chef.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions .github/workflows/pr-sous-chef.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ jobs:
persist-credentials: false
sparse-checkout: |
scripts
actions/setup/js
.github/scripts
- name: Fetch actionable PR queue
id: fetch-prs
Expand Down Expand Up @@ -160,8 +161,10 @@ Explicit `/souschef` invocations may start the agent for acknowledgement only
when the API budgets are healthy. If a refresh finds this flag true, call `noop`
with those budget/reset details and stop
without any writes, including a slash-command acknowledgement or report issue.
The same rule applies to each fresh eligibility check and simulation. An API error
or malformed rate-limit response is a failed read, not a successful no-op.
The same rule applies to each fresh eligibility check and simulation. GitHub CLI
reads retry transient failures at most twice with exponential backoff and jitter;
authentication and permission errors fail immediately. An exhausted API read or
malformed rate-limit response is a failed read, not a successful no-op.

PRs are idle only after at least ten minutes without a commit, PR update, comment,
review, or reply. A fresh Copilot request also restarts this ten-minute interval.
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Everything else should be loaded **lazily** through skills only when needed.

## Critical Rules (Always Applicable)

1. If you changed files, use `report_progress` to commit and push.
1. If you changed files, use `report_progress` to commit and push if available; otherwise, use Git directly after the same validation gates.
2. Before **intermediate** `report_progress` calls, run `make agent-report-progress-no-test` (fast, no tests). Before the **final** `report_progress`, run `make agent-report-progress` (includes `test-unit`).
- `test-unit` is impacted-first by default (~30s target). Use `TEST_UNIT_RUN_FULL=1 make test-unit` or `make test-unit-all` when full-suite coverage is required.
- Run `test-unit` only once per PR — at the final push, not on every intermediate save.
Expand Down
Loading
Loading