Skip to content

Narrowly exempt compiler-generated PR checkouts from artipacked warnings - #71783

Merged
pelikhan merged 9 commits into
mainfrom
pelikhan-psychic-pancake
Oct 25, 2026
Merged

pelikhan merged 9 commits into
mainfrom
pelikhan-psychic-pancake

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Summary

Split the checkout-lint concern out of #71711; addresses only the artipacked portion of #71710.

Suppress only warning-level artipacked diagnostics for retained-credential checkouts in the exact compiler-generated PR checkout/authentication block in safe_outputs. Match the full block against compiler-local provenance, clear provenance between compilations, and decline the exception for modified or ambiguously duplicated blocks.

Runtime authentication, checkout tokens, credential persistence, authored steps, other jobs/rules, and standalone gh aw lint behavior remain unchanged. Document the compiler-only exception.

This PR is independent of the admission-output and repo-memory splits and targets main. Its compile regression deliberately uses admission enabled and no repo-memory configuration, so it does not depend on those fixes.

Validation

  • make fmt passed after restoring the missing pinned JavaScript formatter dependencies with npm ci.
  • make agent-report-progress passed, including build, scoped lint, impacted tests, schema checks, and the workflow drift check (348 workflows compiled; existing warnings remain).
  • Focused compiler lint regressions passed, including authored-step exclusion, modified/duplicate blocks, multi-repository credentials, and provenance reset on compiler reuse.
  • Standalone TestZizmor regressions passed.
  • git diff --check passed.

No workflow source or lock files changed; no workflows were dispatched. Kept draft to match the original PR.

Split the checkout lint concern from #71711. Preserve runtime authentication and standalone lint behavior, with provenance-scoped exceptions and independent regressions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document exact-block provenance, exclusion boundaries, standalone lint behavior, and regression evidence in specification version 1.0.70.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 25, 2026 02:28
Copilot AI max review requested due to automatic review settings October 25, 2026 02:28
Preserve both compiler specification amendments, assigning the checkout lint exception version 1.0.71 after main's admission-gating version 1.0.70.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Later compiler transformations invalidate the saved provenance, preventing the exception from matching supported generated checkout blocks.

1 open issue
What changed in this PR

This PR adds a compiler-only exception for artipacked warnings on generated safe-output PR checkout/authentication steps in gh-aw, without changing runtime authentication or standalone lint behavior.

Changes:

  • Capture and reset per-compilation provenance for the generated checkout block.
  • Require a unique, exact block match before suppressing warning-level diagnostics.
  • Add regression coverage and document the exception in the linter reference and threat-detection specification.
File Description
specs/​compiler-threat-detection-spec.md Defines the exception and advances the specification to 1.0.70.
specs/​compiler-threat-detection-changelog.md Records the exception’s scope and safeguards.
pkg/​workflow/​compiler_yaml.go Resets checkout provenance between compilations.
pkg/​workflow/​compiler_types.go Adds compiler-local checkout provenance storage.
pkg/​workflow/​compiler_safe_outputs_steps.go Captures the generated checkout/authentication block.
pkg/​workflow/​compiler_lint.go Filters eligible warning-level artipacked diagnostics.
pkg/​workflow/​compiler_lint_test.go Adds compilation and compiler-reuse regressions.
pkg/​workflow/​compiler_lint_checkouts.go Matches the complete block and identifies eligible checkout paths.
pkg/​workflow/​compiler_lint_checkouts_test.go Tests exclusions, ambiguity, and multi-repository credentials.
docs/​src/​content/​docs/​reference/​workflow-linters.md Documents the compiler-only exception.

Review effort: Max

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Review (pkg/workflow/compiler_safe_outputs_steps.go:38): This snapshot precedes script finalization and Windows rendering, so rewritten cross-repository/runtime checkout scripts or an added shell: bash make the full-block comparison fail. Those workflows therefore retain the artipacked warnings this exception should remove. Apply the same compiler transformations to the saved provenance without weakening exact matching, and add full-compilation regressions for cross-repository and Windows safe-output jobs. - Narrowly exempt compiler-generated PR checkouts from artipacked warnings #71783 (comment)

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: d84ca87
Sous-chef work: 1107f1df081782e11f6c45effd27c34a9194f8748a9cd0c6e33c3b1bff964f43
Sous-chef state: 8a6ff192de2ae78866aacf7201e7ad11cfe21ff0c42fca0310890e6b8af959c6

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · ~5 AIC · ⌖ ~6 AIC · ⊞ 1.1K · ◷
Comment /souschef to run again

pelikhan and others added 5 commits October 24, 2026 20:09
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
# Conflicts:
#	specs/compiler-threat-detection-changelog.md
#	specs/compiler-threat-detection-spec.md

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Preserve the remote's combined specification history and regenerated workflow locks while retaining local merge ancestry.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged main in f16c9a7 and fixed the provenance mismatch in 0b40ce9; focused tests and the final local gate passed. I replied to the review thread, but could not resolve it because this session has no GH_TOKEN. I did not manually dispatch or rerun CI.

Apply runner and temporary-path rendering to the multi-repository test graph, matching the concurrently merged provenance update.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan merged commit d3a9841 into main Oct 25, 2026
38 checks passed
@pelikhan
pelikhan deleted the pelikhan-psychic-pancake branch October 25, 2026 03:44
pelikhan added a commit that referenced this pull request Oct 25, 2026
All changes in this PR are now included in main, including the generated checkout lint exemption from #71783.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.93.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants