Repository navigation
Narrowly exempt compiler-generated PR checkouts from artipacked warnings - #71783
Conversation
Split the checkout lint concern from #71711. Preserve runtime authentication and standalone lint behavior, with provenance-scoped exceptions and independent regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document exact-block provenance, exclusion boundaries, standalone lint behavior, and regression evidence in specification version 1.0.70. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve both compiler specification amendments, assigning the checkout lint exception version 1.0.71 after main's admission-gating version 1.0.70. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Later compiler transformations invalidate the saved provenance, preventing the exception from matching supported generated checkout blocks.
1 open issue
What changed in this PR
This PR adds a compiler-only exception for artipacked warnings on generated safe-output PR checkout/authentication steps in gh-aw, without changing runtime authentication or standalone lint behavior.
Changes:
- Capture and reset per-compilation provenance for the generated checkout block.
- Require a unique, exact block match before suppressing warning-level diagnostics.
- Add regression coverage and document the exception in the linter reference and threat-detection specification.
| File | Description |
|---|---|
specs/compiler-threat-detection-spec.md |
Defines the exception and advances the specification to 1.0.70. |
specs/compiler-threat-detection-changelog.md |
Records the exception’s scope and safeguards. |
pkg/workflow/compiler_yaml.go |
Resets checkout provenance between compilations. |
pkg/workflow/compiler_types.go |
Adds compiler-local checkout provenance storage. |
pkg/workflow/compiler_safe_outputs_steps.go |
Captures the generated checkout/authentication block. |
pkg/workflow/compiler_lint.go |
Filters eligible warning-level artipacked diagnostics. |
pkg/workflow/compiler_lint_test.go |
Adds compilation and compiler-reuse regressions. |
pkg/workflow/compiler_lint_checkouts.go |
Matches the complete block and identifies eligible checkout paths. |
pkg/workflow/compiler_lint_checkouts_test.go |
Tests exclusions, ambiguity, and multi-repository credentials. |
docs/src/content/docs/reference/workflow-linters.md |
Documents the compiler-only exception. |
Review effort: Max
|
@copilot address the following outstanding work in one pass:
Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI. Sous-chef head: d84ca87
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
# Conflicts: # specs/compiler-threat-detection-changelog.md # specs/compiler-threat-detection-spec.md Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Preserve the remote's combined specification history and regenerated workflow locks while retaining local merge ancestry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Merged |
Apply runner and temporary-path rendering to the multi-repository test graph, matching the concurrently merged provenance update. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
All changes in this PR are now included in main, including the generated checkout lint exemption from #71783. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🎉 This pull request is included in a new release. Release: |

Summary
Split the checkout-lint concern out of #71711; addresses only the
artipackedportion of #71710.Suppress only warning-level
artipackeddiagnostics for retained-credential checkouts in the exact compiler-generated PR checkout/authentication block insafe_outputs. Match the full block against compiler-local provenance, clear provenance between compilations, and decline the exception for modified or ambiguously duplicated blocks.Runtime authentication, checkout tokens, credential persistence, authored steps, other jobs/rules, and standalone
gh aw lintbehavior remain unchanged. Document the compiler-only exception.This PR is independent of the admission-output and repo-memory splits and targets
main. Its compile regression deliberately uses admission enabled and no repo-memory configuration, so it does not depend on those fixes.Validation
make fmtpassed after restoring the missing pinned JavaScript formatter dependencies withnpm ci.make agent-report-progresspassed, including build, scoped lint, impacted tests, schema checks, and the workflow drift check (348 workflows compiled; existing warnings remain).TestZizmorregressions passed.git diff --checkpassed.No workflow source or lock files changed; no workflows were dispatched. Kept draft to match the original PR.