Repository navigation
Skip Design Decision Gate ADR writes for already-closed PRs #69504
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" | ||
| TEST_DIR="$(mktemp -d)" | ||
| trap 'rm -rf "$TEST_DIR"' EXIT | ||
| mkdir -p "$TEST_DIR/bin" "$TEST_DIR/agent" "$TEST_DIR/workspace" | ||
|
|
||
| awk ' | ||
| /^ run: \|$/ { body = 1; next } | ||
| body && /^ / { sub(/^ /, ""); print; next } | ||
| body && /^$/ { print; next } | ||
| body { exit } | ||
|
Contributor
There was a problem hiding this comment. This harness reads the markdown source instead of the compiled 💡 Why this blocks the fixThe regression you are fixing is in the production workflow, but this test extracts the shell body from A safer pattern is to exercise |
||
| ' "$ROOT/.github/workflows/design-decision-gate.md" | | ||
| sed "s|/tmp/gh-aw/agent|$TEST_DIR/agent|g" > "$TEST_DIR/prefetch.sh" | ||
| test -s "$TEST_DIR/prefetch.sh" | ||
|
|
||
| cat > "$TEST_DIR/bin/gh" <<'MOCK' | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
| printf '%s\n' "$*" >> "$TEST_DIR/calls" | ||
| case "$*" in | ||
| "pr view "*) | ||
| [[ "$*" == *",state" ]] | ||
| if [ "$FAIL_PR" = 1 ]; then | ||
| echo 'gh: API request failed (HTTP 403)' >&2 | ||
| exit 1 | ||
| fi | ||
| jq -n --arg state "$PR_STATE" \ | ||
| '{number:42,title:"Implementation",body:"",labels:[],state:$state, | ||
| baseRefName:"main",headRefName:"feature",author:null,url:""}' | ||
| ;; | ||
| "api --paginate repos/owner/repo/pulls/42/files?per_page=100 --jq .[]") | ||
| printf '{"filename":"pkg/implementation.go","additions":553}\n' | ||
| ;; | ||
| "pr diff 42 --repo owner/repo") | ||
| printf 'diff --git a/pkg/implementation.go b/pkg/implementation.go\n' | ||
| ;; | ||
| *) | ||
| echo "Unexpected API request: $*" >&2 | ||
| exit 1 | ||
| ;; | ||
| esac | ||
| MOCK | ||
| chmod +x "$TEST_DIR/bin/gh" | ||
| export TEST_DIR PATH="$TEST_DIR/bin:$PATH" | ||
| export EXPR_GITHUB_EVENT_NAME=pull_request EXPR_GITHUB_REPOSITORY=owner/repo | ||
| export EXPR_GITHUB_WORKSPACE="$TEST_DIR/workspace" PR_NUMBER=42 PR_STATE=OPEN FAIL_PR=0 | ||
| unset GH_TOKEN GITHUB_TOKEN | ||
|
|
||
| run_prefetch() { | ||
| : > "$TEST_DIR/calls" | ||
| rm -f "$TEST_DIR/agent/adr-prefetch-summary.json" | ||
| bash "$TEST_DIR/prefetch.sh" > "$TEST_DIR/output" 2>&1 | ||
| } | ||
|
|
||
| # An open PR still requires an ADR for the same 553-line implementation. | ||
| run_prefetch | ||
| test "$(wc -l < "$TEST_DIR/calls" | tr -d ' ')" = 3 | ||
| jq -e '.pr_number == 42 and .requires_adr_by_default_volume and | ||
| .default_business_additions == 553 and .diff_available and (has("skip_reason") | not)' \ | ||
| "$TEST_DIR/agent/adr-prefetch-summary.json" >/dev/null | ||
|
|
||
| # A stale open webhook must not cause ADR generation on a closed/deleted branch. | ||
| for state in CLOSED MERGED; do | ||
| PR_STATE="$state" run_prefetch | ||
| test "$(wc -l < "$TEST_DIR/calls" | tr -d ' ')" = 1 | ||
| jq -e --arg state "$state" '.pr_number == 42 and | ||
| (.skip_reason | contains($state)) and .file_count == 0 and (.diff_available | not)' \ | ||
| "$TEST_DIR/agent/adr-prefetch-summary.json" >/dev/null | ||
| jq -e 'length == 0' "$TEST_DIR/agent/pr-files.json" >/dev/null | ||
| grep -q '::notice::Pull request #42' "$TEST_DIR/output" | ||
| done | ||
|
|
||
| # Preserve manual dispatch behavior, both with and without a PR number. | ||
| EXPR_GITHUB_EVENT_NAME=workflow_dispatch PR_NUMBER="" run_prefetch | ||
| test ! -s "$TEST_DIR/calls" | ||
| jq -e '.pr_number == null and .skip_reason == "workflow_dispatch did not include inputs.pr_number"' \ | ||
| "$TEST_DIR/agent/adr-prefetch-summary.json" >/dev/null | ||
| EXPR_GITHUB_EVENT_NAME=workflow_dispatch run_prefetch | ||
| jq -e '.requires_adr_by_default_volume and (has("skip_reason") | not)' \ | ||
| "$TEST_DIR/agent/adr-prefetch-summary.json" >/dev/null | ||
|
|
||
| # API failures cannot turn an unverified PR into a successful skip. | ||
| if FAIL_PR=1 run_prefetch; then | ||
| echo 'PR metadata failure unexpectedly succeeded' >&2 | ||
| exit 1 | ||
| fi | ||
| test ! -e "$TEST_DIR/agent/adr-prefetch-summary.json" | ||
| grep -q 'HTTP 403' "$TEST_DIR/output" | ||
| echo 'Design Decision Gate prefetch regressions passed' | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This skip path coerces the raw
workflow_dispatchinput withtonumber, which will abort prefetch if the operator passes a PR URL/ref thatgh pr viewresolves successfully.💡 Why this is a real regression
workflow_dispatchinputs are untyped strings.gh pr view "$PR_NUMBER"accepts more than bare numeric IDs, so a closed PR supplied as a URL or another resolvable selector reaches this branch and then dies while writingadr-prefetch-summary.json. That turns the intended noop skip into a hard failure.Use the validated
.numberalready returned inpr.json, or guard the conversion before callingtonumber.