Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/engine-configuration-conformance.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions .changeset/remove-legacy-genaiscript-engine.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions .github/aw/engines.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
"id": "deepseek-harness",
"import": "github/gh-aw/.github/workflows/shared/deepseek-harness.md"
},
{
"id": "custom",
"import": "github/gh-aw/.github/workflows/shared/genaiscript.md"
},
{
"id": "goose",
"import": "github/gh-aw/.github/workflows/shared/goose.md"
Expand Down
2 changes: 1 addition & 1 deletion .github/aw/syntax-engine.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ See [syntax-agentic.md](syntax-agentic.md) for the full frontmatter field index.
- The experimental `cursor` engine is available through `imports: [shared/cursor.md]`; see [`smoke-cursor.md`](../workflows/smoke-cursor.md) for an example. Requires the `CURSOR_API_KEY` secret. Cursor reads project rules from `.cursor/rules/*.mdc` and respects the root-level `.cursorignore` and `AGENTS.md`; both are protected in the manifest. Use `model: cursor/auto` or a specific model such as `cursor/claude-3-7-sonnet`.
- The experimental `kiro` engine is available through `imports: [shared/kiro.md]`; see [`smoke-kiro.md`](../workflows/smoke-kiro.md) for an example. Requires the `KIRO_API_KEY` secret. Kiro reads steering documents from `.kiro/steering/` and hook definitions from `.kiro/hooks/`; these directories and `AGENTS.md` are protected in the manifest. Model must use `kiro/` prefix, e.g. `model: kiro/claude-sonnet-4-5`.
- The `pydantic-ai` engine is available through `imports: [pydantic/pydantic-ai/src/pydantic_ai_harness/gh-aw/pydantic.md@main]`; see [`smoke-pydantic.md`](../workflows/smoke-pydantic.md) for an example. It runs the Pydantic AI `pai` CLI with the `pydantic-ai-harness` coder agent and uses `provider/model` syntax.
- The experimental `crush`, `aider`, `goose`, and `custom` (GenAIScript) engines are also available through `imports: [shared/<engine>.md]`; see [`smoke-crush.md`](../workflows/smoke-crush.md), [`smoke-aider.md`](../workflows/smoke-aider.md), and [`smoke-goose.md`](../workflows/smoke-goose.md) for examples. Full list of import-based engines: see `.github/aw/engines.json`.
- The experimental `crush`, `aider`, and `goose` engines are also available through `imports: [shared/<engine>.md]`; see [`smoke-crush.md`](../workflows/smoke-crush.md), [`smoke-aider.md`](../workflows/smoke-aider.md), and [`smoke-goose.md`](../workflows/smoke-goose.md) for examples. Full list of import-based engines: see `.github/aw/engines.json`.
- Object format for extended configuration:

```yaml
Expand Down
1,632 changes: 1,632 additions & 0 deletions .github/workflows/engine-conformance-aider.lock.yml

Large diffs are not rendered by default.

39 changes: 39 additions & 0 deletions .github/workflows/engine-conformance-aider.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
name: Engine Conformance Aider
description: Run the shared configuration conformance suite with Aider.
on:
workflow_dispatch:
permissions:
contents: read
copilot-requests: write
strict: true
inlined-imports: true
timeout-minutes: 10
max-ai-credits: 5
features:
gh-aw-detection: false
model: copilot/gpt-5.4
engine:
id: aider
env:
ENGINE_CONFORMANCE_SENTINEL: conformance-aider
imports:
- shared/aider.md
- uses: shared/engine-conformance.md
with:
engine-id: aider
tools:
github:
mode: gh-proxy
toolsets: [repos]
---

Execute the imported engine configuration conformance suite once.

Aider is single-turn: implement the imported probes in a small JavaScript file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/codebase-design] Unlike the other 12 conformance workflows, which just say "Execute the imported suite once" because the shared markdown's embedded JS does all the probe/assertion work, Aider's prompt asks the agent to freehand reimplement the probe-invocation logic (read fixture, spawn mcpscripts, write result.json) in natural language. Any future change to the shared probe's I/O contract (field names, nonce format, etc.) must be manually ported into this prose, and there's no automated check tying the two together.

💡 Suggestion

Worth a one-line comment here (or in engine-conformance.md) flagging that Aider is the one engine whose probe logic lives in prompt text rather than shared JS, so maintainers remember to update this file in lockstep when the shared contract changes.

@copilot please address this.

at `/tmp/gh-aw/agent/engine-conformance/run-probes.cjs` using SEARCH/REPLACE blocks,
then execute it with one `node` command in a bash block. The program must read
the fixture, run the supplied shell probe, invoke
`mcpscripts` with `spawnSync` and an argument array, and write `result.json` with
the actual returned values. Preserve nonzero child exit codes. Do not guess
nonces or replace the supplied probe. Emit the final staged noop in a bash block.
1,579 changes: 1,579 additions & 0 deletions .github/workflows/engine-conformance-claude.lock.yml

Large diffs are not rendered by default.

25 changes: 25 additions & 0 deletions .github/workflows/engine-conformance-claude.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Engine Conformance Claude
description: Run the shared configuration conformance suite with Claude Code.
on:
workflow_dispatch:
permissions:
contents: read
strict: true
inlined-imports: true
timeout-minutes: 10
max-turns: 30
max-ai-credits: 5
features:
gh-aw-detection: false
engine:
id: claude
env:
ENGINE_CONFORMANCE_SENTINEL: conformance-claude
imports:
- uses: shared/engine-conformance.md
with:
engine-id: claude
---

Execute the imported engine configuration conformance suite once.
1,569 changes: 1,569 additions & 0 deletions .github/workflows/engine-conformance-codex.lock.yml

Large diffs are not rendered by default.

25 changes: 25 additions & 0 deletions .github/workflows/engine-conformance-codex.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Engine Conformance Codex
description: Run the shared configuration conformance suite with Codex.
on:
workflow_dispatch:
permissions:
contents: read
strict: true
inlined-imports: true
timeout-minutes: 10
max-turns: 30
max-ai-credits: 5
features:
gh-aw-detection: false
engine:
id: codex
env:
ENGINE_CONFORMANCE_SENTINEL: conformance-codex
imports:
- uses: shared/engine-conformance.md
with:
engine-id: codex
---

Execute the imported engine configuration conformance suite once.
Loading
Loading