Repository navigation
[compiler-threat-spec] Daily compiler threat spec audit (2026-09-15): dispose Opengrep build-reproducibility findings as out of scope - #61014
Conversation
…-reproducibility findings as out of scope Bumped spec to 1.0.36 (audit-only). Reviewed ~260+ open high-severity code-scanning alerts, dominated by Opengrep pr-action rules for npm/uv/pip install determinism and Dockerfile SHA-pinning. All compiler-generated npm install calls already pin exact versions (satisfying the scanner's own documented exception); remaining flagged files are hand-authored or build-tooling outside pkg/workflow/, pkg/parser/, actions/setup/ conformance scope per spec Section 1. No new CTR-* rule required; CTR-014 already covers the adjacent in-scope install-script-execution risk. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Protected files were modified in this pull request and require manual scrutiny before merge.
Please verify that each protected-file change is intentional, policy-compliant, and safe:
- Protected files:
.changeset/threat-spec-audit-2026-09-15.md
|
@copilot Please take another pass on this PR and run the Review feedback:
Run: https://github.com/github/gh-aw/actions/runs/34926826647 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
🎉 This pull request is included in a new release. Release: |
Caution
Protected files were modified in this change.
This pull request is in
request-reviewmode and requires explicit human scrutiny before merge.Protected files:
.changeset/threat-spec-audit-2026-09-15.mdDaily Compiler Threat Spec Optimizer — 2026-09-15
View Details
Threats reviewed
d8e1aa7); no candidate threat surfaced from source changes.github-actions-npm-install-non-deterministic(large majority) — flagsnpm install(vsnpm ci) in generated.lock.ymlfiles.actions-uv-pip-install-non-deterministic(~10 instances) — flagsuv pip installwithout--frozen.dockerfile-non-sha-pinned-image(1 instance) —FROM alpine:3.24in the repoDockerfile.actions-pip-install-inline-no-hash-check,github-actions-setup-node-missing-version.Disposition
npm install(inpkg/workflow/codex_engine.go'sBuildStandardNpmEngineInstallStepsNoCooldown/generateCodexDockerSbxCLIInstallStep, andpkg/workflow/copilot_engine_installation.go) already pins an exact version (e.g.@openai/codex@0.153.4), which is the scanner's own documented exception for global installs. No compiler-side implementation change was required..github/workflows/test-copilot-github-integration.yml(unpinnednpm install -g @github/copilot) — hand-authored, nogh-aw-metadata/generation header..github/workflows/format-and-commit.yml(missingsetup-nodeversion) — hand-authored maintenance workflow..github/workflows/shared/python-dataviz.md/trending-charts-simple.md(uv pip installwithout--frozen) — shared markdown snippet, third-party visualization deps, no untrusted input.Dockerfile(alpine:3.24not SHA-pinned) — repo build tooling, notpkg/workflow//pkg/parser//actions/setup/output.Rule IDs added/changed
CTR-*rule was warranted this run.Files changed
specs/compiler-threat-detection-spec.md— version bump 1.0.35 → 1.0.36, Section 2 sync-table row added.specs/compiler-threat-detection-changelog.md— Version History row + new### Mapping Audit (2026-09-15)entry..changeset/threat-spec-audit-2026-09-15.md— new changeset documenting the audit.Tests run
go build/go testinvocation needed since no.gosource changed.Suppression review
threat-detection-suppressannotations exist in any workflow frontmatter (only illustrative documentation examples), so noSLA_BREACHapplies.Steering issue
#with a blank value), soissue_readwas skipped; no steering feedback was available to incorporate.Run: https://github.com/github/gh-aw/actions/runs/34926826647
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.life-white.ukTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.