Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share API rate-limit state across multi-target logs downloads #60531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Share API rate-limit state across multi-target logs downloads #60531
Changes from all commits
b17bed0d5724f2b5f569bbdbd77ae3b9b96fead99543d2833File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collectSingleLogsTargetsetserr: errLogsAPIRateLimitReachedfor every queued target once the ceiling is reached, unlike the analogous count-limit path a few lines above which returnserr: nil(countLimitedLogsTargetResult(targetOpts)with noerr). InmergeLogsTargetResults, every non-nilerris appended toallErrors, andDownloadWorkflowLogsForTargetshas:So when the ceiling is hit before any target has produced a processed run (e.g. it's reached very early, or
--countis small), every target — the one that detected the ceiling and all the queued ones — contributes an error,allErrorsis non-empty, and the whole multi-target download now returns a hard error viaerrors.Join, instead of taking the gracefulhandleEmptyProcessedRunsbranch that the count-limit case takes (which reports "no runs" plus the built continuations, exit 0). This turns an expected/handled condition (ceiling reached) into a CLI failure and discards the otherwise-correctly-built continuation data for the caller.Suggested fix: don't set
erron thelogsTargetResultfor the rate-limit-reached branches (mirror the count-limit branches), or explicitly filtererrLogsAPIRateLimitReachedout ofallErrorsbefore thelen(allErrors) > 0hard-fail check inDownloadWorkflowLogsForTargets.@copilot please address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in b5f569b and follow-up commits: rate-limit sentinel errors are now excluded from multi-target hard failures, preserving merged continuations.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.