Repository navigation
Fix Dependabot ignores for gh-aw action subpaths - #54812
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🛠️ Agentic Maintenance updated this pull request branch. |
There was a problem hiding this comment.
Pull request overview
Updates Dependabot reconciliation to ignore all gh-aw action subpaths and migrate legacy managed rules.
Changes:
- Generates
<effective-actions-repo>/*rules and migrates legacy patterns. - Adds reconciliation tests and updates documentation.
- Includes unrelated generated smoke-drive routing changes.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/dependabot_reconcile.go |
Implements wildcard reconciliation and migration. |
pkg/workflow/dependabot_test.go |
Expands reconciliation coverage. |
pkg/workflow/schemas/github-workflow.json |
Reorders the drives permission entry. |
docs/src/content/docs/reference/dependabot.md |
Documents wildcard ignores. |
docs/src/content/docs/reference/faq.md |
Updates the FAQ example. |
docs/src/content/docs/reference/compilation-process.md |
Updates the compilation example. |
.github/workflows/agentic_commands.yml |
Adds unrelated smoke-drive routing. |
Review details
Suppressed comments (1)
pkg/workflow/dependabot_reconcile.go:215
- Comment ownership is tracked globally by dependency name, so this removal also deletes unmarked user entries whenever the same legacy pattern is marked in another
github-actionsupdate block. That violates the preservation requirement for valid configs with multiple update blocks. Associate the inline marker with the specific YAML entry before removing it rather than treating every occurrence of the pattern as managed.
if slices.Contains(legacyManagedPatterns, dependencyName) && setutil.Contains(managedPatternsWithComment, dependencyName) {
changed = true
continue
- Files reviewed: 7/7 changed files
- Comments generated: 4
- Review effort level: Balanced
|
|
||
| managedPatterns := []string{c.effectiveActionsRepo()} | ||
| managedPatterns := []string{c.effectiveActionsRepo() + "/*"} | ||
| legacyManagedPatterns := []string{c.effectiveActionsRepo(), c.effectiveActionsRepo() + "/**"} |
| if !strings.Contains(updatedStr, `dependency-name: "github/gh-aw-actions/*"`) { | ||
| t.Fatal("managed github/gh-aw-actions wildcard ignore entry should replace the legacy entry") | ||
| } | ||
| if strings.Contains(updatedStr, `dependency-name: "github/gh-aw-actions" #`) { |
| ## Compiler-managed `gh-aw-actions` ignore rule | ||
|
|
||
| `gh aw compile` always reconciles the compiler-managed ignore rule for `github/gh-aw-actions` when your repository already has a `github-actions` update block in `.github/dependabot.yml` (this is not limited to `--dependabot` runs). | ||
| `gh aw compile` always reconciles the compiler-managed ignore rule for `github/gh-aw-actions/*` when your repository already has a `github-actions` update block in `.github/dependabot.yml` (this is not limited to `--dependabot` runs). |
| # /smoke-crush -> smoke-crush [issue_comment,issues,pull_request,pull_request_comment] reaction=eyes | ||
| # /smoke-cursor -> smoke-cursor [issue_comment,issues,pull_request,pull_request_comment] reaction=rocket | ||
| # /smoke-deepseek-harness -> smoke-deepseek-harness [issue_comment,issues,pull_request,pull_request_comment] reaction=eyes | ||
| # /smoke-drive -> smoke-drive [issue_comment,issues,pull_request,pull_request_comment] reaction=rocket |
|
@copilot no need for legacy migration path, the file is regenerated |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Removed the legacy migration path (exact and |
|
@copilot this PR still needs forward progress before maintainer review.
Run: https://github.com/github/gh-aw/actions/runs/32578995676
|
…d docs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
The legacy migration path was already removed in 5ad1162 per the maintainer's request. In 117acec I additionally reverted the unrelated generated drift in Validations rerun: Maintainer hand-off: the two automated review threads flagging the legacy |
|
🎉 This pull request is included in a new release. Release: |
Dependabot identifies reusable actions by full subpath, so the generated repository-level ignore did not suppress updates for
setup,setup-cli, and other gh-aw actions.Managed ignore reconciliation
<effective-actions-repo>/*rather than the bare repository name./**rules without duplicates.Custom action repositories
effectiveActionsRepo(), including--actions-repo owner/repo.