Repository navigation
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix BehaviorDefinedEngine to emit AWF install for custom engines
Ensure behavior-defined engines always emit AWF install steps under firewall mode
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior-defined engines could compile without any
install_awf_binary.shstep unless they used npm (or a harness script), which makes firewall-mode execution fail deterministically (awf: command not found) for non-npm/custom engines like Pydantic AI. This change makes AWF installation independent of npm-specific install paths.AWF install composition decoupled from npm path
buildAWFInstallationSteps(...).BuildNpmEngineInstallStepsWithAWF(...)now reuses this helper, preserving npm step ordering while removing npm-only coupling.Behavior-defined engine install logic fixed
BehaviorDefinedEngine.GetInstallationSteps(...)now returns AWF install steps (when firewall is enabled) for:installation == nil && harness-script == ""installation.package-manager != "npm"Regression coverage for non-npm and no-installation branches
package-manager: pipinstallationand noharness-scriptCompiled workflow output updated
smoke-pydantic.lock.ymlso firewall-mode jobs now include AWF binary installation before Pydantic execution.