Repository navigation
fix: update pinned commit in TestAddWorkflowWithDispatchWorkflowFromSharedImport - #28851
Conversation
…romSharedImport (#28845) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d0669d61-0137-470c-a089-0afbba61924f Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the pinned workflow reference used by TestAddWorkflowWithDispatchWorkflowFromSharedImport to a newer upstream commit so the integration test can successfully resolve an explicitly-relative shared import during recursive frontmatter fetching.
Changes:
- Bump the pinned
smoke-copilot.mdcommit from15af946toa4237ca. - Update the inline test comment to document why this newer pin is required (strict mode + explicitly-relative
./serena.mdimport behavior).
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/add_integration_test.go | Updates the pinned upstream workflow commit used by an integration test to avoid failing recursive import resolution. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
🧪 Test Quality Sentinel ReportTest Quality Score: 85/100✅ Excellent test quality
Test Classification Details
AnalysisThe change is a pure maintenance update: the pinned commit SHA in the workflow spec string was bumped from No test logic, assertions, or structural changes were made. The test itself verifies strong behavioral contracts:
All assertions carry descriptive messages. The Language SupportTests analyzed:
Verdict
📖 Understanding Test ClassificationsDesign Tests (High Value) verify what the system does:
Implementation Tests (Low Value) verify how the system does it:
Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators. References: §25035448233
|
The integration test was pinned to commit
15af946whereserena-go.mdimportsserena.mdas a non-explicit relative path.fetchFrontmatterImportsRecursiveresolves non-explicit paths againstoriginalBaseDir(.github/workflows), producing.github/workflows/serena.md(HTTP 404) instead of.github/workflows/shared/mcp/serena.md, causing compilation to fail.Changes
pkg/cli/add_integration_test.go: Update pinned SHA from15af946→a4237ca(currentmainHEAD), whereserena-go.mduses./serena.md(explicitly-relative). The explicit-relative branch in the fetcher resolves againstcurrentBaseDir(.github/workflows/shared/mcp), correctly downloading the sibling file.