Skip to content

fix: update pinned commit in TestAddWorkflowWithDispatchWorkflowFromSharedImport - #28851

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-integration-add-workflow-failure
Apr 28, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/fix-integration-add-workflow-failure

Conversation

Copilot AI commented Apr 28, 2026 •

Copy link
Copy Markdown
Contributor

The integration test was pinned to commit 15af946 where serena-go.md imports serena.md as a non-explicit relative path. fetchFrontmatterImportsRecursive resolves non-explicit paths against originalBaseDir (.github/workflows), producing .github/workflows/serena.md (HTTP 404) instead of .github/workflows/shared/mcp/serena.md, causing compilation to fail.

Changes

  • pkg/cli/add_integration_test.go: Update pinned SHA from 15af946 → a4237ca (current main HEAD), where serena-go.md uses ./serena.md (explicitly-relative). The explicit-relative branch in the fetcher resolves against currentBaseDir (.github/workflows/shared/mcp), correctly downloading the sibling file.

…romSharedImport (#28845)

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d0669d61-0137-470c-a089-0afbba61924f

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for integration add workflow fix: update pinned commit in TestAddWorkflowWithDispatchWorkflowFromSharedImport Apr 28, 2026
Copilot AI requested a review from pelikhan April 28, 2026 05:13
@pelikhan
pelikhan marked this pull request as ready for review April 28, 2026 05:21
Copilot AI review requested due to automatic review settings April 28, 2026 05:21
@pelikhan
pelikhan merged commit 38d1131 into main Apr 28, 2026
@pelikhan
pelikhan deleted the copilot/fix-integration-add-workflow-failure branch April 28, 2026 05:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned workflow reference used by TestAddWorkflowWithDispatchWorkflowFromSharedImport to a newer upstream commit so the integration test can successfully resolve an explicitly-relative shared import during recursive frontmatter fetching.

Changes:

  • Bump the pinned smoke-copilot.md commit from 15af946 to a4237ca.
  • Update the inline test comment to document why this newer pin is required (strict mode + explicitly-relative ./serena.md import behavior).
Show a summary per file
File Description
pkg/cli/add_integration_test.go Updates the pinned upstream workflow commit used by an integration test to avoid failing recursive import resolution.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test Quality Sentinel Report

Test Quality Score: 85/100

✅ Excellent test quality

Metric Value
New/modified tests analyzed 1
✅ Design tests (behavioral contracts) 1 (100%)
⚠️ Implementation tests (low value) 0 (0%)
Tests with error/edge cases 1 (100%)
Duplicate test clusters 0
Test inflation detected No
🚨 Coding-guideline violations None

Test Classification Details

Test File Classification Issues Detected
TestAddWorkflowWithDispatchWorkflowFromSharedImport pkg/cli/add_integration_test.go:1010 ✅ Design None — pinned SHA updated, behavioral assertions intact

Analysis

The change is a pure maintenance update: the pinned commit SHA in the workflow spec string was bumped from 15af946 to a4237ca, and the accompanying comment was updated to explain the ./serena.md explicit-relative path behaviour that required the new pin.

No test logic, assertions, or structural changes were made. The test itself verifies strong behavioral contracts:

  1. add command must succeed (exit 0)
  2. Main workflow file (smoke-copilot.md) must exist on disk
  3. Dispatch-workflow dependency (haiku-printer.yml) must be fetched via the .yml fallback
  4. Compiled lock file (smoke-copilot.lock.yml) must be created
  5. Lock file must contain a reference to haiku-printer

All assertions carry descriptive messages. The //go:build integration build tag is present on line 1. No mock libraries are used.


Language Support

Tests analyzed:

  • 🐹 Go (*_test.go): 1 test — integration (//go:build integration)

Verdict

✅ Check passed. 0% of new/modified tests are implementation tests (threshold: 30%). The update is a routine pin bump to keep a live-network integration test aligned with the current repository state.


📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

  • Assert on observable outputs, return values, or state changes
  • Cover error paths and boundary conditions
  • Would catch a behavioral regression if deleted
  • Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

  • Assert on internal function calls (mocking internals)
  • Only test the happy path with typical inputs
  • Break during legitimate refactoring even when behavior is correct
  • Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §25035448233

🧪 Test quality analysis by Test Quality Sentinel · ● 576.1K · ◷

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 85/100. Test quality is acceptable — 0% of new tests are implementation tests (threshold: 30%). The change is a routine pin bump with no degradation to the test's behavioral coverage.

@github-actions github-actions Bot mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants