Repository navigation
rename: copilot driver → harness - #28772
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2fa6a511-a148-4475-a59a-5be5553eaebe Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Renames the “copilot driver” concept to “copilot harness” across the workflow compiler (Go), setup scripts/tests (JavaScript), frontmatter schema, and documentation, and recompiles workflow lock files to reflect the new harness script name.
Changes:
- Renamed engine config plumbing from
driver/DriverScript/DriverProvider→harness/HarnessScript/HarnessProvider(plus related validation and runtime detection updates). - Renamed the Node wrapper script and log prefix from
copilot_driver.cjs/[copilot-driver]→copilot_harness.cjs/[copilot-harness], and updated detection patterns/tests accordingly. - Updated schema/docs/golden outputs and regenerated workflow
*.lock.ymlfiles to reference the new harness script.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/threat_detection_test.go | Updates threat-detection compilation tests to use HarnessScript and new harness filenames. |
| pkg/workflow/threat_detection.go | Propagates HarnessScript into detection engine execution step generation; updates node-setup gating helper name. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Updates golden output to reference actions/copilot_harness.cjs. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates golden output to reference actions/copilot_harness.cjs. |
| pkg/workflow/runtime_setup_test.go | Updates runtime setup tests’ engine config to use HarnessScript. |
| pkg/workflow/runtime_detection.go | Renames runtime requirement helper to harness terminology and switches to EngineConfig.HarnessScript. |
| pkg/workflow/engine_validation_test.go | Updates validation tests to call validateEngineHarnessScript and use HarnessScript. |
| pkg/workflow/engine_validation.go | Renames/updates engine wrapper script validation to engine.harness / HarnessScript. |
| pkg/workflow/engine_config_test.go | Updates engine config extraction tests to use engine.harness and HarnessScript. |
| pkg/workflow/engine.go | Renames EngineConfig.DriverScript to HarnessScript and updates frontmatter extraction key to harness. |
| pkg/workflow/copilot_engine_test.go | Updates Copilot engine tests to expect copilot_harness.cjs and HarnessProvider. |
| pkg/workflow/copilot_engine_execution.go | Switches execution wrapper selection to harness script name and EngineConfig.HarnessScript override. |
| pkg/workflow/copilot_engine.go | Renames GetDriverScriptName() to GetHarnessScriptName() and returns copilot_harness.cjs. |
| pkg/workflow/compiler_types.go | Updates comment referencing code-scanning alert defaults. |
| pkg/workflow/compiler_orchestrator_workflow.go | Calls validateEngineHarnessScript during workflow parsing. |
| pkg/workflow/agentic_engine.go | Renames optional engine interface DriverProvider→HarnessProvider and helper engineRequiresNodeDriver→engineRequiresNodeHarness. |
| pkg/parser/schemas/main_workflow_schema.json | Renames schema field engine.driver→engine.harness and updates description/pattern. |
| pkg/parser/schema_test.go | Updates schema tests for engine.harness field and file naming. |
| pkg/agentdrain/data/default_weights.json | Updates text reference from copilot_driver.cjs to copilot_harness.cjs. |
| docs/src/content/docs/reference/frontmatter-full.md | Updates frontmatter reference docs from driver to harness. |
| docs/src/content/docs/reference/engines.md | Updates engine capability table and documentation section from engine.driver to engine.harness. |
| actions/setup/js/detect_copilot_errors.test.cjs | Updates test fixtures to use [copilot-harness] prefix. |
| actions/setup/js/detect_copilot_errors.cjs | Updates docs/comments referencing harness wrapper logs. |
| actions/setup/js/copilot_harness.test.cjs | Updates unit tests to require/import copilot_harness.cjs and validate harness log prefix. |
| actions/setup/js/copilot_harness.cjs | Introduces/renames wrapper implementation to “harness” and updates usage/log prefix. |
| .github/workflows/workflow-health-manager.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/workflow-generator.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/weekly-blog-post-writer.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/video-analyzer.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/test-workflow.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/test-project-url-default.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/test-dispatcher.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/terminal-stylist.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/sub-issue-closer.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/smoke-ci.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/security-compliance.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/repo-tree-map.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/release.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/refiner.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/pr-triage-agent.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/plan.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/notion-issue-summary.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/metrics-collector.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/jsweep.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/issue-triage-agent.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/issue-monster.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/hippo-embed.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/gpclean.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/firewall.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/example-permissions-warning.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/dictation-prompt.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/dev.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/deployment-incident-monitor.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/dependabot-burner.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/daily-team-status.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/daily-skill-optimizer.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/daily-secrets-analysis.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/craft.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/copilot-token-optimizer.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/contribution-check.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/code-simplifier.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/brave.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/bot-detection.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/archie.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/agent-performance-analyzer.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
| .github/workflows/ace-editor.lock.yml | Regenerated lock to call actions/copilot_harness.cjs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
actions/setup/js/copilot_harness.cjs:72
- In the renamed harness script, this comment still says "All driver messages" even though the prefix and file are now harness-based. Update the wording (and any nearby references like "driver" retry behavior) to consistently use "harness" to avoid confusion when grepping logs or reading the code.
- Files reviewed: 157/157 changed files
- Comments generated: 2
| if !strings.Contains(s, "custom_copilot_harness.cjs") { | ||
| t.Errorf("expected custom driver script in detection steps, got:\n%s", s) | ||
| } | ||
| if strings.Contains(s, "actions/copilot_driver.cjs") { | ||
| if strings.Contains(s, "actions/copilot_harness.cjs") { | ||
| t.Errorf("expected default driver to be replaced by custom override, got:\n%s", s) |
| TrialMode bool // whether the workflow is running in trial mode | ||
| TrialLogicalRepo string // target repository slug for trial mode (owner/repo) | ||
| FrontmatterName string // name field from frontmatter (for code scanning alert driver default) | ||
| FrontmatterName string // name field from frontmatter (for code scanning alert harness default) |
|
@copilot merge main and recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 7781a5d. Merged main (resolving the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Renames the "copilot driver" concept to "copilot harness" across Go, JavaScript, frontmatter schema, and docs.
Changes
JavaScript
copilot_driver.cjs→copilot_harness.cjs(and test file)[copilot-driver]log prefix →[copilot-harness]detect_copilot_errors.cjsGo
DriverProviderinterface →HarnessProviderGetDriverScriptName()→GetHarnessScriptName()EngineConfig.DriverScript→HarnessScriptvalidateEngineDriverScript()→validateEngineHarnessScript()engineRequiresNodeDriver()→engineRequiresNodeHarness()Frontmatter / schema
engine.driver→engine.harnessin JSON schema, extraction code, validation error messages, and docs (engines.md,frontmatter-full.md)Not renamed: SARIF
tool.driverfields increate_code_scanning_alert.*— that's a SARIF spec term, unrelated.All 204 workflow lock files recompiled.