Skip to content

Fix validation consistency across all safe output types - #17302

Merged
pelikhan merged 2 commits into
mainfrom
copilot/review-tools-and-validation-json
Feb 20, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/review-tools-and-validation-json

Conversation

Copilot AI commented Feb 20, 2026 •

Copy link
Copy Markdown
Contributor

ValidationConfig was missing entries for 7 types that existed in tools.json, and cross-repo types were missing repo field validation. Additionally, pkg/workflow/js/safe_outputs_tools.json and actions/setup/js/safe_outputs_tools.json had diverged.

Missing ValidationConfig entries (7 types)

Types present in safe_outputs_tools.json with no validation whatsoever:

  • update_discussion, remove_labels, unassign_from_user, hide_comment, missing_data, autofix_code_scanning_alert, mark_pull_request_as_ready_for_review

Missing repo field for cross-repo types

All 22 types handled by addRepoParameterIfNeeded now have repo: {Type: "string", MaxLength: 256} in ValidationConfig. Previously only create_issue and create_discussion had it.

Missing fields in existing ValidationConfig entries

  • update_issue: operation (enum), labels, assignees, milestone — all used by the handler but unvalidated
  • create_pull_request + update_pull_request: draft (boolean)
  • assign_to_agent: pull_request_repo (cross-repo PR target)

tools.json sync

The two copies of safe_outputs_tools.json had drifted:

Field pkg/workflow/js actions/setup/js
create_pull_request.draft ❌ missing ✅
update_pull_request.draft ❌ missing ✅
assign_to_agent.pull_request_repo ✅ ❌ missing
update_issue.operation/labels/assignees/milestone ✅ ❌ missing

Both files are now in sync.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GO111MODULE 64/bin/go git conf�� user.email test@example.com /usr/lib/git-core/git -json GO111MODULE 64/bin/go /usr/lib/git-core/git (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -trimpath ache/node/24.13.--verify git rev-�� --show-toplevel git nfig/composer/vendor/bin/bash k/gh-aw/gh-aw/.ggit -goversion /usr/bin/git git (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -ifaceassert -nilfunc git rev-�� --show-toplevel -tests /usr/bin/git --show-toplevel git /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha -json GO111MODULE 7020769/b362/vet.cfg GOINSECURE GOMOD GOMODCACHE go env -json nConfigConsistency 0/x64/bin/node GOINSECURE GOMOD GOMODCACHE 0/x64/bin/node (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/find vaScript13644733git GO111MODULE /opt/hostedtoolc--show-toplevel find /opt�� -maxdepth 4 /usr/bin/git d -name bin git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha runs/20260220-223830-35449/test-3101864136/.github/workflows git 2514722/b292/vet.cfg --show-toplevel git /tmp/go-build239--show-toplevel node js/f�� /usr/bin/git /tmp/go-build239453425/b001/workflow.test /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -test.timeout=10git -test.count=1 /usr/bin/git /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha g_.a GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env mkfi-Z6rc GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE ortcfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha --show-toplevel go /usr/bin/git -json GO111MODULE x_amd64/link git rev-�� --show-toplevel x_amd64/link /usr/bin/git -json GO111MODULE ache/go/1.25.0/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha --show-toplevel git ache/node/24.13.0/x64/bin/node --show-toplevel git /usr/bin/git git _cod�� 3507540738 git ache/node/24.13.0/x64/bin/node --show-toplevel git /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha vaScript1364473322/001/test-fronv1.0.0 GO111MODULE /opt/hostedtoolcache/go/1.25.0/x/tmp/gh-aw-git-clone-2966133085 GOINSECURE GOMOD GOMODCACHE go env 3453-27527/test-1071449421 GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha vaScript1364473322/001/test-fron-errorsas 7020769/b125/vet.cfg /opt/hostedtoolcache/go/1.25.0/x-nilfunc GOINSECURE GOMOD GOMODCACHE go env runs/20260220-223453-27527/test-3326924755/.github/workflows GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha -unreachable=false resolved$ /usr/bin/git -json GO111MODULE 64/bin/go git conf�� user.email test@example.com /usr/bin/git "prettier" --chegit GOPROXY 64/bin/go git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha r-test3653053630/existing.md 7020769/b413/_testmain.go e/git -s -w -buildmode=exe e/git -1 xterm-color -extld=gcc /usr/bin/infocmp g/repoutil/repougit g/repoutil/repourev-parse 64/bin/go infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha .github/workflows/test.md node /usr/bin/git --check **/*.cjs 64/bin/go git rev-�� --show-toplevel go /opt/hostedtoolcache/node/24.13.0/x64/bin/node -json GO111MODULE 64/bin/go /opt/hostedtoolcache/node/24.13.0/x64/bin/node (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha GOSUMDB GOWORK 64/bin/go GOINSECURE GOMOD GOMODCACHE go env e=false GO111MODULE 64/bin/go GOINSECURE %H %ct %D a096efd3154c4766-json go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha ck 'scripts/**/*GOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE npm (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE sh (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env 3453-27527/test-1071449421 GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha --show-toplevel go /usr/bin/git ithub/workflows GO111MODULE 0/x64/bin/node git rev-�� --show-toplevel go /usr/bin/git vaScript13644733git GO111MODULE /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha --show-toplevel git ache/go/1.25.0/x64/pkg/tool/linux_amd64/link --show-toplevel git /usr/bin/git ache/go/1.25.0/x64/pkg/tool/linux_amd64/link js/f�� 3830-35449/test-3507540738 git 2514722/b408/importcfg.link --show-toplevel git /snap/bin/bash aQk8wi30_HiVA/BWtOpPeD11gBK_BvlD86/pZ4ifq6VFAj2_JzA3LCk/gTAN7DWaremote.origin.url (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env runs/20260220-223453-27527/test-2329453655/.github/workflows GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha --show-toplevel go /usr/bin/git ithub/workflows GO111MODULE .cfg git rev-�� --show-toplevel go /usr/bin/git /ref/tags/v8 GO111MODULE (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha /existing.md git /opt/hostedtoolcache/node/24.13.0/x64/bin/node --show-toplevel git /usr/bin/git node js/f�� runs/20260220-223830-35449/test-1312148213/.github/workflows git /opt/hostedtoolcache/node/24.13.0/x64/bin/node l git /opt/hostedtoolc--show-toplevel node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 git 0/x64/bin/node bffd3e8a7113ebefgit --stdout /usr/bin/git git cjs --show-toplevel git ache/node/24.13.0/x64/bin/node --show-toplevel ache/go/1.25.0/xrev-parse /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env hub/workflows GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 git 0/x64/bin/node --exact-match --tags /usr/bin/git git cjs --show-toplevel git 64/pkg/tool/linux_amd64/compile --show-toplevel /opt/hostedtoolcrev-parse /usr/bin/git 64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env hub/workflows GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 git 0/x64/bin/node --exact-match --tags /usr/bin/git git cjs --show-toplevel git 64/pkg/tool/linux_amd64/link --show-toplevel 0/x64/bin/node /usr/bin/git 64/pkg/tool/linux_amd64/link (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 git 0/x64/bin/node --count bffd3e8a7113ebefinit (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 git At,event,headBranch,headSha,displayTitle --oneline bffd3e8a7113ebefrev-parse /usr/bin/git git cjs --show-toplevel git ser.test --show-toplevel /opt/hostedtoolcrev-parse /usr/bin/git ser.test (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 git 0/x64/bin/node --stat bffd3e8a7113ebefrev-parse /usr/bin/git git cjs --show-toplevel git outil.test --show-toplevel ache/go/1.25.0/xrev-parse /usr/bin/git outil.test (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 ls 0/x64/bin/node /tmp/gh-aw/aw.pagit go /usr/bin/git git cjs --show-toplevel git 64/pkg/tool/linux_amd64/vet --show-toplevel /tmp/go-build100/tmp/fuzz-expr-2210648936.js /usr/bin/git 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path g/sliceutil/slicGOINSECURE g/sliceutil/slicGOMOD 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 7707298/b403/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE go env w-DY/ufMS_jH8iB8GOSUMDB GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE 7707298/b416/importcfg (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha ty-test.md GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env 4096981974/.github/workflows GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha -lang=go1.25 go /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git tmatter-with-arrgit GO111MODULE At,event,headBra--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha --show-toplevel git /usr/bin/git --show-toplevel 64/pkg/tool/linuconfig /usr/bin/git git rev-�� ub/workflows git /usr/bin/git --show-toplevel go /usr/bin/git git (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha ty-test.md GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env 2395376472/.github/workflows GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha --show-toplevel go /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha --show-toplevel git /usr/bin/git --show-toplevel go /usr/bin/git git s --show-toplevel git /usr/bin/git --show-toplevel go /usr/bin/git git (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion --show-toplevel /opt/hostedtoolcrev-parse /usr/bin/git 64/pkg/tool/linux_amd64/compile rev-�� g_.a git ache/node/24.13.0/x64/bin/node --show-toplevel git $name) { hasdownload git (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 7707298/b407/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 7707298/b409/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo /usr/bin/git --show-toplevel go /usr/bin/git git rev-�� create_pull_request" git /usr/bin/git --show-toplevel go /usr/bin/git git (http block)
  • https://api.github.com/repos/owner/repo/contents/file.md
    • Triggering command: /tmp/go-build1007020769/b380/cli.test /tmp/go-build1007020769/b380/cli.test -test.testlogfile=/tmp/go-build1007020769/b380/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go m/_n�� -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /tmp/go-build1882514722/b001/cli.test /tmp/go-build1882514722/b001/cli.test -test.testlogfile=/tmp/go-build1882514722/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s rev-�� --show-toplevel git /usr/bin/git --show-toplevel x_amd64/link otOrdering120446058/001/go/1.25.--show-toplevel git rev-�� --show-toplevel git /usr/bin/git --show-toplevel go /usr/bin/git git (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name g/logger/exampleGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 7707298/b394/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name --show-toplevel git /usr/bin/git --show-toplevel x_amd64/vet /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel go /usr/bin/git git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Do a deep review of tools.json and validation.json entries for each safe output types (specially the ones that support cross repo).

Make sure validation is consistent.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ools.json files

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Review tools.json and validation.json for consistency Fix validation consistency across all safe output types Feb 20, 2026
@pelikhan
pelikhan marked this pull request as ready for review February 20, 2026 23:13
Copilot AI review requested due to automatic review settings February 20, 2026 23:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes validation consistency across all safe output types by adding missing validation entries, ensuring cross-repo types have proper repo field validation, and syncing the two diverged copies of safe_outputs_tools.json.

Changes:

  • Added ValidationConfig entries for 7 previously unvalidated types: update_discussion, remove_labels, unassign_from_user, hide_comment, missing_data, autofix_code_scanning_alert, and mark_pull_request_as_ready_for_review
  • Added repo field validation (type: string, maxLength: 256) to all 23 cross-repo safe output types to enable cross-repository operations
  • Added missing fields to existing ValidationConfig entries: operation, labels, assignees, milestone for update_issue; draft for create_pull_request and update_pull_request; and pull_request_repo for assign_to_agent
  • Synchronized pkg/workflow/js/safe_outputs_tools.json and actions/setup/js/safe_outputs_tools.json to have consistent field definitions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/workflow/safe_output_validation_config.go Added 7 new type validation configs, added repo field to 23 cross-repo types, added missing fields to update_issue, create_pull_request, update_pull_request, and assign_to_agent
pkg/workflow/safe_output_validation_config_test.go Updated test expectations to include the 7 new types and verify the repo field is present in create_issue validation config
pkg/workflow/js/safe_outputs_tools.json Added draft field to create_pull_request and update_pull_request, reformatted some required arrays for readability
actions/setup/js/safe_outputs_tools.json Added pull_request_repo to assign_to_agent, added operation, labels, assignees, milestone to update_issue, added draft to update_pull_request

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan
pelikhan merged commit 9450254 into main Feb 20, 2026
140 checks passed
@pelikhan
pelikhan deleted the copilot/review-tools-and-validation-json branch February 20, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants