Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,6 @@ clean:
rm -f sbom.spdx.json sbom.cdx.json
@# Remove security scan reports
rm -f gosec-report.json gosec-results.sarif govulncheck-results.sarif trivy-results.sarif
@# Remove downloaded logs (but keep .gitignore)
@if [ -d .github/aw/logs ]; then \
find .github/aw/logs -type f ! -name '.gitignore' -delete 2>/dev/null || true; \
find .github/aw/logs -type d -empty -delete 2>/dev/null || true; \
fi
@# Remove installed gh extension if it exists
@if [ -d "$$HOME/.local/share/gh/extensions/gh-aw" ]; then \
echo "Removing installed gh-aw extension..."; \
Expand Down
4 changes: 2 additions & 2 deletions pkg/cli/logs_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func TestLogsCommandFlagDefaults(t *testing.T) {
{"start-date", ""},
{"end-date", ""},
{"engine", ""},
{"output", ".github/aw/logs"}, // Updated to match actual default
{"output", "/tmp/gh-aw/logs"}, // Updated to use temp folder
{"ref", ""},
{"after-run-id", "0"},
{"before-run-id", "0"},
Expand Down Expand Up @@ -239,7 +239,7 @@ func TestLogsCommandOutputFlag(t *testing.T) {
assert.Equal(t, "o", outputFlag.Shorthand, "output shorthand should be 'o'")

// Output flag has default value
assert.Equal(t, ".github/aw/logs", outputFlag.DefValue, "output default should be '.github/aw/logs'")
assert.Equal(t, "/tmp/gh-aw/logs", outputFlag.DefValue, "output default should be '/tmp/gh-aw/logs'")
}

func TestLogsCommandHelpText(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/logs_models.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const (
// runSummaryFileName is the name of the summary file created in each run folder
runSummaryFileName = "run_summary.json"
// defaultLogsOutputDir is the default directory for downloaded workflow logs
defaultLogsOutputDir = ".github/aw/logs"
defaultLogsOutputDir = "/tmp/gh-aw/logs"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot get a cross platform temp folder

)

// Constants for the iterative algorithm
Expand Down
Loading