Repository navigation
Export DEBUG env var in MCP gateway setup and pass to container - #13539
Merged
Merged
Conversation
…d to use -e DEBUG Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update debug command settings for MCP gateway
Export DEBUG env var in MCP gateway setup and pass to container
Feb 3, 2026
Collaborator
|
@copilot please look at the comment for file mcp_setup_generator.go |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a shell globbing issue with the DEBUG environment variable in the MCP gateway setup. The changes prevent the asterisk (*) from being expanded by the shell when used as a literal value for debug logging configuration.
Changes:
- Added proper quoting to
export DEBUG="*"in the shell script to prevent globbing - Changed Docker command from
-e DEBUG="*"to-e DEBUGto properly pass the environment variable - Recompiled all 149 workflow lock files with the corrected generation logic
Reviewed changes
Copilot reviewed 150 out of 150 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/mcp_setup_generator.go | Added line 505 to export DEBUG="*" with proper quoting; changed line 547 to pass DEBUG env var to Docker without value assignment |
| .github/workflows/*.lock.yml (149 files) | Regenerated workflow files reflecting the corrected DEBUG environment variable handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the DEBUG environment variable export to prevent shell globbing issues.
export DEBUG="*"with proper quoting (wasexport DEBUG=*)-e DEBUG="*"to-e DEBUGin the MCP_GATEWAY_DOCKER_COMMANDChanges Made
Code Changes
File:
pkg/workflow/mcp_setup_generator.goexport DEBUG=*toexport DEBUG="*"to prevent shell globbing-e DEBUG="*"to-e DEBUGin the Docker command (from previous commit)Rationale
The
*character is a shell glob pattern and must be quoted when used as a literal value. Without quotes, the shell would expand*to match all files in the current directory, which is not the intended behavior for the DEBUG environment variable.Workflow Files Updated
All 149 workflow
.lock.ymlfiles were recompiled with the fix.Testing
Verification
The fix is correctly reflected in all compiled workflows:
export DEBUG="*"appears afterexport MCP_GATEWAY_API_KEY(properly quoted)-e DEBUG(without the value assignment)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.