Skip to content

Claim PR/discussion readback fails on fields other actors change within seconds #76460

Open

Description

@elefthei

Runs 42333626965 and 42556432224 failed after eslint-miner created a pull request. Run 42218969645 failed after daily-secrets-analysis created a discussion.

The PR runs logged:

✓ Message 1 (create_pull_request) completed successfully
##[error]One or more Claim deliveries remain unverified

All three claim-delivery-errors.json artifacts reported:

failures[0].error = "Independent scoped resource verification failed"

PRs #75594 and #76119 were later merged by a human.

Current readback policy

verifyPullRequest requires exact identity, number, URL, title, body, state === "open", draft status, head SHA/ref/repository, base SHA/ref/repository, repository IDs, labels, and assignees. verifyDiscussion also requires exact labels.

The Work queue specification requires identity, permitted repositories and refs, the expected head commit, commit/tree evidence, category for discussions, and expected content. It does not require exact labels, assignees, base.sha, state, or draft status.

Labels, assignees, base.sha, state, and draft status can change after creation but before readback. That makes a successful creation unverifiable even when the identity, content, branch, repositories, and commit evidence still match.

Proposed policy

Keep exact checks for identity, repositories, refs, head commit, commit/tree evidence, title, body, and discussion category. Treat labels and assignees as supersets of the values set by the handler. This is the rule already used for create_issue in verifyBuiltinDeliveryOutput. Stop requiring exact base.sha, state, and draft values.

The field-level diagnostics patch prepared alongside this issue will name the failed check in future claim-delivery-errors.json artifacts. It does not change the readback policy.

Acceptance criteria

  • A PR still verifies when labels, base.sha, or state changes between creation and readback.
  • A PR still fails when its head commit, title, body, branch, base/head repository, or permitted refs differ.
  • A discussion still verifies when its labels gain entries after creation, but fails when its identity, repository, category, title, or body differs.
  • actions/setup/js/work_queue_native_creation_delivery.test.cjs covers each mutable-field pass and immutable-field failure.

Activity

  1. github-actions commented on Nov 11, 2026

    @github-actions
    Contributor

    Assigned to @pelikhan for the work-queue area, since pelikhan recently merged work queue launch and run binding changes (#76331, #76253).

    Generated by 🔧 Daily Assign Issue To User · copilot · routed: haiku55 xhigh · ~5 AIC · ⌖ ~1 AIC · ⊞ 2.6K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions