Skip to content

[linter-miner] Add split-index-zero-prefer-cut custom linter #74909

Closed

Description

@github-actions

Tip

Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to a branch. Please review the protected files, then create the pull request when you are ready.

Create the pull request

The original pull request description is below.


Overview

Adds the split-index-zero-prefer-cut Go analyzer to flag strings.Split(s, sep)[0] when a provably non-empty separator causes unnecessary substring allocation.

Key changes

  • Handles constant index zero, parenthesized expressions, generated-file skipping, nolint directives, and coverage-aware hot-path gating.
  • Registers the analyzer and updates linter documentation and registry synchronization tests.
  • The code-pattern scan found a concrete occurrence in pkg/cli/edit_command.go; discussion mining found related candidates that are already implemented.

Validation

  • go test ./pkg/linters/split-index-zero-prefer-cut/... ./pkg/linters
  • go build ./cmd/linters
  • make test-unit
  • make fmt-go
  • make fmt reached successful Go formatting but stopped in fmt-cjs.

References:


Note

Protected files

This patch modifies protected files, which may affect project dependencies, CI/CD pipelines, or agent behaviour.

Protected files
  • README.md

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Allow intentional protected-file changes

If this workflow is intended to modify these files, add specific filenames or folder prefixes to safe-outputs.create-pull-request.protected-files.exclude in the workflow Markdown frontmatter. For example, to allow .changeset/*, exclude the folder using .changeset/:

safe-outputs:
  create-pull-request:
    protected-files:
      policy: fallback-to-issue
      exclude:
        - .changeset/

Keep your existing policy and exclusions. Folder exclusions use path prefixes, not glob patterns, and allow all files beneath that folder, including subfolders. Other protected files still follow the configured policy. If allowed-files is configured, these paths must also match it. Run gh aw compile after updating the workflow.

  • expires on Nov 11, 2026, 9:41 AM UTC-08:00

Generated by Linter Miner · copilot · routed: gpt56 max · ~50 AIC · ⌖ ~2 AIC · ⊞ 3.7K · ◷

Activity

  1. github-actions commented on Nov 8, 2026

    @github-actions
    ContributorAuthor

    🍪 Issue Monster selected this for Copilot

    I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

    If assignment succeeds, Copilot will analyze the issue and create a pull request with the fix.

    Om nom nom! 🍪

    🍪 Om nom nom by Issue Monster · pi · gpt50 · ~1 AIC · ⌖ ~1 AIC · ⊞ 12.3K · ◷

  2. linked a pull request that will close this issueUse strings.Cut for the first path component #75920on Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions