Skip to content

[linter-miner] Add stringssplitfirst linter #73891

Closed

Description

@github-actions

Tip

Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to a branch. Please review the protected files, then create the pull request when you are ready.

Create the pull request

The original pull request description is below.


Adds the stringssplitfirst analyzer, which reports strings.Split(s, sep)[0] with a non-empty constant separator and suggests strings.Cut, avoiding a slice allocation.

Evidence: the pattern appears in production code (pkg/cli/edit_command.go) and several tests; it is not covered by an existing linter in pkg/linters/. Sub-agents were not run; the idea came from direct source scanning.

Includes testdata (bad/good/nolint/generated cases), registration in registry.go, and README/doc.go/spec_test/doc_sync updates. Not yet CI-enforced (listed in notYetEnforced). go test ./pkg/linters/... passes.


Note

Protected files

This patch modifies protected files, which may affect project dependencies, CI/CD pipelines, or agent behaviour.

Protected files
  • README.md

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Allow intentional protected-file changes

If this workflow is intended to modify these files, add specific filenames or folder prefixes to safe-outputs.create-pull-request.protected-files.exclude in the workflow Markdown frontmatter. For example, to allow .changeset/*, exclude the folder using .changeset/:

safe-outputs:
  create-pull-request:
    protected-files:
      policy: fallback-to-issue
      exclude:
        - .changeset/

Keep your existing policy and exclusions. Folder exclusions use path prefixes, not glob patterns, and allow all files beneath that folder, including subfolders. Other protected files still follow the configured policy. If allowed-files is configured, these paths must also match it. Run gh aw compile after updating the workflow.

Generated by Linter Miner · copilot · sonnet55 · ~28 AIC · ⌖ ~22 AIC · ⊞ 10.4K · ◷

  • expires on Nov 8, 2026, 11:55 AM UTC-08:00

Activity

  1. github-actions commented on Nov 7, 2026

    @github-actions
    ContributorAuthor

    🍪 Issue Monster selected this for Copilot

    I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

    If assignment succeeds, Copilot will analyze the issue and create a pull request with the fix.

    Om nom nom! 🍪

    🍪 Om nom nom by Issue Monster · pi · gpt50 · ~1 AIC · ⌖ ~2 AIC · ⊞ 12.7K · ◷

  2. linked a pull request that will close this issueAdd `stringssplitfirst` analyzer #75753on Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions