Skip to content

[deep-report] Convert domains.go/claude_tools.go invariant panics on the compile path to returned errors #65081

Closed as not planned

Description

@github-actions

Description

Two invariant checks on the per-workflow compile path panic instead of returning errors: mustGetAllowedDomainsForEngineWithModel (pkg/workflow/domains.go:691, called from universal_llm_consumer_engine.go:295, pi_engine.go:423, behavior_defined_engine.go:734, which itself panics again at its own call site at behavior_defined_engine.go:729), and the tool-map shape check in computeAllowedClaudeToolsString (pkg/workflow/claude_tools.go:142, which only logs "ERROR" before panicking). Both rely on upstream validation always catching bad input first — a custom engine definition or a model-alias edge case that bypasses validateModelAliasMap kills the compile process.

Expected Impact

Removes two concrete crash points in gh aw compile reachable from user-authored workflow files (custom engine configs, model aliases), converting them into ordinary compile errors with workflow context instead of process-ending panics.

Suggested Agent

GitHub Copilot coding agent — change mustGetAllowedDomainsForEngineWithModel and computeAllowedClaudeToolsString to return (..., error), update all four call sites to propagate the error with workflow context, and add tests covering an invalid model and a malformed claude tools section.

Estimated Effort

Medium (1-4 hours)

Data Source

DeepReport Intelligence Briefing — 2026-10-02, sourced from Repository Quality Improvement Report #65022 ("Compiler Panic Containment"), Task 2.

Generated by 🔬 Deep Report · claude · agent · 212 AIC · ⌖ 7.99 AIC · ⊞ 7.3K · ◷

  • expires on Oct 4, 2026, 10:42 AM UTC-08:00

Activity

  1. github-actions commented on Oct 4, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-10-04T18:42:34.874Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions