You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[deep-report] Convert domains.go/claude_tools.go invariant panics on the compile path to returned errors #65081
Two invariant checks on the per-workflow compile path panic instead of returning errors: mustGetAllowedDomainsForEngineWithModel (pkg/workflow/domains.go:691, called from universal_llm_consumer_engine.go:295, pi_engine.go:423, behavior_defined_engine.go:734, which itself panics again at its own call site at behavior_defined_engine.go:729), and the tool-map shape check in computeAllowedClaudeToolsString (pkg/workflow/claude_tools.go:142, which only logs "ERROR" before panicking). Both rely on upstream validation always catching bad input first — a custom engine definition or a model-alias edge case that bypasses validateModelAliasMap kills the compile process.
Expected Impact
Removes two concrete crash points in gh aw compile reachable from user-authored workflow files (custom engine configs, model aliases), converting them into ordinary compile errors with workflow context instead of process-ending panics.
Suggested Agent
GitHub Copilot coding agent — change mustGetAllowedDomainsForEngineWithModel and computeAllowedClaudeToolsString to return (..., error), update all four call sites to propagate the error with workflow context, and add tests covering an invalid model and a malformed claude tools section.
Activity
github-actions commentedon Oct 4, 2026
This issue was automatically closed because it expired on 2026-10-04T18:42:34.874Z.