[step-names] Align "Download safe-output temporary ID map" with Safe Outputs capitalization convention #63553

Overview

pkg/workflow/repo_memory.go:633 generates a step named Download safe-output temporary ID map — lowercase and hyphenated, singular "safe-output" — while every sibling Safe-Outputs step generated elsewhere in the compiler consistently capitalizes the term as Title Case, unhyphenated, plural "Safe Outputs". This step runs whenever hasConsolidatedSafeOutputsJob is true, so it appears in the compiled push_repo_memory_download_steps sequence across a large share of the .lock.yml fleet.

Finding

[High Priority] Capitalization/hyphenation inconsistency

This is the same class of issue previously fixed in #50174 (Download safe outputs items manifest → Download Safe Outputs Items Manifest, in notify_comment.go), but in a different, newer source location that was not covered by that fix.

Per the project glossary, safe-outputs (hyphenated, lowercase) is correct in frontmatter/technical/config contexts, but the established convention for compiler-generated step names shown to users in the Actions UI is Title Case, unhyphenated, plural: Safe Outputs.

Suggested fix:

Download safe-output temporary ID map  ->  Download Safe Outputs Temporary ID Map

Suggested Task

1. Edit pkg/workflow/repo_memory.go:633: change " - name: Download safe-output temporary ID map\n" to " - name: Download Safe Outputs Temporary ID Map\n".
2. Update the matching assertion in pkg/workflow/compiler_jobs_memory_test.go:80, which currently checks for the literal string Download safe-output temporary ID map.
3. Recompile affected workflows (make recompile) so all .lock.yml occurrences pick up the change.
4. Run go test ./pkg/workflow/... to confirm updated assertions pass.

Related Files

• Source: pkg/workflow/repo_memory.go
• Test: pkg/workflow/compiler_jobs_memory_test.go
• Sibling implementations: pkg/workflow/mcp_setup_safe_outputs.go, pkg/workflow/compiler_yaml_step_lifecycle.go, pkg/workflow/compiler_safe_outputs_steps.go, pkg/workflow/notify_comment.go, pkg/workflow/publish_assets.go
• Project glossary: docs/src/content/docs/reference/glossary.md
• Precedent: [step-names] Align step names in notify_comment.go with Safe Outputs capitalization convention #50174 (same capitalization-convention issue, different source file, already fixed)

Generated by 📋 Step Name Alignment · claude · agent · 109.2 AIC · ⌖ 6.72 AIC · ⊞ 10.4K · ◷

• expires on Sep 27, 2026, 8:00 PM UTC-08:00