Repository navigation
[deep-report] Consolidate JobStep / JobStepData identical structs in pkg/cli #52090
Description
Description
pkg/cli/logs_models.go defines JobStep struct { Name, Status, Conclusion string } and pkg/cli/audit_report.go independently defines an identical JobStepData struct { Name, Status, Conclusion string }. The two types are 100% structurally identical, yet every place they cross paths requires an explicit conversion (JobStepData(step)). This is pure duplication with no behavioral difference — a good candidate for merging into a single type (or a type alias) used by both call sites.
Expected Impact
Removes a redundant type + manual conversion boilerplate, reducing maintenance surface and confusion about which type to use where.
Suggested Agent
General-purpose refactor agent (mechanical rename + conversion removal), verified by existing _test.go coverage for both files.
Estimated Effort
Quick (< 1 hour)
Data Source
DeepReport analysis 2026-08-11, sourced from Typist Go Type Consistency Analysis discussion #52015 (2026-08-11).
Generated by 🔬 Deep Report · agent · 142.3 AIC · ⌖ 47.8 AIC · ⊞ 11.4K · ◷
- expires on Aug 13, 2026, 7:07 AM UTC-08:00
Activity
github-actions commentedon Aug 11, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪