Skip to content

[Code Quality] Consolidate duplicate ExperimentState/ExperimentRunRecord types in pkg/cli #46071

Closed as not planned

Description

@github-actions

Description

The pkg/cli package contains duplicate type definitions for ExperimentState and ExperimentRunRecord. These clusters were identified by the Typist Go Type Consistency Analysis agent as redundant type definitions that should be merged.

Suggested Changes

  • Audit all usages of ExperimentState and ExperimentRunRecord across pkg/cli
  • Consolidate duplicates into single canonical definitions
  • Update all call sites to use the canonical types
  • Remove unused/duplicate type declarations

Files Affected

  • pkg/cli/ (multiple files containing duplicate type clusters)

Success Criteria

  • Zero duplicate type definitions for ExperimentState and ExperimentRunRecord
  • All existing tests pass
  • No regression in functionality

Source

Extracted from [typist] 🔤 Typist: Go Type Consistency Analysis — 8 duplicate clusters + enum-typing opportunities #45983

Priority

Medium — Improves maintainability and reduces type confusion

🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · 200.6 AIC · ⌖ 7.37 AIC · ⊞ 7K · ◷

  • expires on Jul 17, 2026, 11:18 AM UTC-08:00

Activity

  1. github-actions commented on Jul 17, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-07-17T19:18:32.534Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions