You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Code Quality] Embed AggregatedSummaryBase in MCPFailureSummary (logs_models.go) #46002
MCPFailureSummary in pkg/cli/logs_models.go (line 173) re-declares 4 fields — Count, Workflows, WorkflowsDisplay, and RunIDs — that are already defined in AggregatedSummaryBase (line 157). The sibling types MissingToolSummary and MissingDataSummary already correctly embed AggregatedSummaryBase, but MCPFailureSummary does not, creating copy-paste drift. The base type's doc comment even flags that sibling types should embed it.
Suggested Changes
Replace the four duplicate field declarations in MCPFailureSummary with AggregatedSummaryBase embedding
Align with the existing pattern used by MissingToolSummary and MissingDataSummary
Activity
github-actions commentedon Jul 17, 2026
This issue was automatically closed because it expired on 2026-07-17T13:23:16.109Z.